A few comments when reviewing the package:
- could artofillusion.sh and build.xml be made part of a patch (in debian/patches) or somehow else placed in the debian/ directory?
- Could you make "(Closes: LP:#185810)" be "(LP: #185810)" in debian/changelog?
- you could set debian/source/format to "3.0 (quilt)"
- can you have a closer look at the licenses of the files again? some are GPL (v2), others are GPL (v2 or later)
This snippet could be useful: for i in `find . -type f`; do licensecheck $i; done
- current Standards-Version is 3.9.5
- a debian/watch would be nice to have
- The synopsis (first line in the package "Description:" field, the short description) ends with a full stop "." character.
- empty directories
usr/share/lib/artofillusion/HelpPlugin/AOIHelp/helpset/FurtherHelp/images/
usr/share/lib/artofillusion/HelpPlugin/AOIHelp/helpset/HowTo/images/
usr/share/lib/artofillusion/HelpPlugin/AOIHelp/helpset/Plugins/Help/
usr/share/lib/artofillusion/HelpPlugin/AOIHelp/helpset/Problems/
usr/share/lib/artofillusion/HelpPlugin/docs/
usr/share/lib/artofillusion/Scripts/Objects/
usr/share/lib/artofillusion/Scripts/Startup/
usr/share/lib/artofillusion/Scripts/Tools/
- maybe an artofillusion-common (or -data) (arch: all) package would be useful to ship everything that's in usr/share (16M)
- manpage for usr/bin/artofillusion would be nice to have
- LICENSE contains lots of ^M chars
Of the above the debian/copyright review is the most important. A lot of other things are nice to have.
A few comments when reviewing the package: source/ format to "3.0 (quilt)" share/lib/ artofillusion/ HelpPlugin/ AOIHelp/ helpset/ FurtherHelp/ images/ share/lib/ artofillusion/ HelpPlugin/ AOIHelp/ helpset/ HowTo/images/ share/lib/ artofillusion/ HelpPlugin/ AOIHelp/ helpset/ Plugins/ Help/ share/lib/ artofillusion/ HelpPlugin/ AOIHelp/ helpset/ Problems/ share/lib/ artofillusion/ HelpPlugin/ docs/ share/lib/ artofillusion/ Scripts/ Objects/ share/lib/ artofillusion/ Scripts/ Startup/ share/lib/ artofillusion/ Scripts/ Tools/ common (or -data) (arch: all) package would be useful to ship everything that's in usr/share (16M) artofillusion would be nice to have
- could artofillusion.sh and build.xml be made part of a patch (in debian/patches) or somehow else placed in the debian/ directory?
- Could you make "(Closes: LP:#185810)" be "(LP: #185810)" in debian/changelog?
- you could set debian/
- can you have a closer look at the licenses of the files again? some are GPL (v2), others are GPL (v2 or later)
This snippet could be useful: for i in `find . -type f`; do licensecheck $i; done
- current Standards-Version is 3.9.5
- a debian/watch would be nice to have
- The synopsis (first line in the package "Description:" field, the short description) ends with a full stop "." character.
- empty directories
usr/
usr/
usr/
usr/
usr/
usr/
usr/
usr/
- maybe an artofillusion-
- manpage for usr/bin/
- LICENSE contains lots of ^M chars
Of the above the debian/copyright review is the most important. A lot of other things are nice to have.