offlineimap crashes with python 2.7.2rc1

The exception message is a lie I think, so ignore that. ;)

It is for some reason getting an AttributeError in __getattr__(), but the question is why `self.file` doesn't exist.

Based on the traceback I'm guessing you're using SSL, and in particular IMAP4_SSL class. This is fairly different between 2.6 and 2.7. Whereas in 2.6 there is no self.file attribute, in 2.7 there is. That doesn't really explain why 2.7 tracebacks though! self.file gets assigned in IMAP4_SSL.open() so, is it at all possible that the open method isn't getting called? (Seems unlikely).

Any possibility you have a reproducible test case? Have you looked upstream for any related problems?

i did a bit of a search on upstream archives, and nothing.
then, tried with current git trunk, and I see the same set of issues. I'll debug a bit.

Hi all,
   I'm using Ubuntu Oneiric (development branch), and this week brought
python version 2.7.2rc1 into the archive.
   That broke offlineimap with SSL for me. I've opened bug 792043 [1],
and then done some debugging. The breakage is caused by a change that
went into python imaplib for python issue 1441530 [2]. You can see the
specific patch that caused the problem at [3].

   Locally, I've tested the fix below. It seems to work both with
python2.6 and python2.7.

--
[1] http://pad.lv/792043
[2] http://bugs.python.org/issue1441530
[3] http://bugs.python.org/file22063/imaplib_recv_27.diff

diff --git a/offlineimap/imaplibutil.py b/offlineimap/imaplibutil.py
index a60242b..21ee3d2 100644
--- a/offlineimap/imaplibutil.py
+++ b/offlineimap/imaplibutil.py
@@ -172,6 +172,7 @@ def new_open_ssl(self, host = '', port = IMAP4_SSL_PORT):
             # FIXME
             raise socket.error(last_error)
         self.sslobj = ssl_wrap(self.sock, self.keyfile, self.certfile)
+ self.file = self.sslobj.makefile('rb')
         self.sslobj = sslwrapper(self.sslobj)

 mustquote = re.compile(r"[^\w!#$%&'+,.:;<=>?^`|~-]")

previous comment was also posted to offlineimap mailing list:
http://article.gmane.org/gmane.mail.imap.offlineimap.general/3748

Well, my fix was apparently not complete. now UsefulIMAP4_SSL:read is hanging for me on copying [some] messages.

OK, the patch I'm attaching here has worked for me for the 3 accounts that I use.

It just basically gets rid of the WrappedIMAP4_SSL class. I've left 'UsefulIMAP4_SSL' in hoping that what is there will still satisfy the issue that it is present for on darwin.

It also, "works for me" on python2.6 at the moment.

On Fri, 3 Jun 2011, Scott Moser wrote:

> Hi all,
> I'm using Ubuntu Oneiric (development branch), and this week brought
> python version 2.7.2rc1 into the archive.
> That broke offlineimap with SSL for me. I've opened bug 792043 [1],
> and then done some debugging. The breakage is caused by a change that
> went into python imaplib for python issue 1441530 [2]. You can see the
> specific patch that caused the problem at [3].
>
> [1] http://pad.lv/792043
> [2] http://bugs.python.org/issue1441530
> [3] http://bugs.python.org/file22063/imaplib_recv_27.diff

Ok.. So, a lot more digging.

This issue appears to be fixed in offlineimap trunk, and is largely a dupe
of http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=569068.
, and in released version 6.3.3. Additionally, debian has 6.3.3-3, so I
will get that pulled into Ubuntu. I obviously should have checked there
first, and have requested sync from debian under bug 793574.

Previously, I had arrived at https://github.com/jgoerzen/offlineimap/wiki
(its the top hit on google), and then at
https://github.com/jgoerzen/offlineimap and, as a result was looking at
the wrong trunk. Apparently, I can't read a file named 'README'. Sorry
for that.

The only thing I would suggest is to remove or update the obsolete comment
in offlineimap/imaputil.py:WrappedIMAP4_SSL, that says:

    It provides a better readline() implementation as impaplib's
    readline() is extremly inefficient. It can also connect to IPv6
    addresses."""

This class no longer has a 'readline', and python's socket performance
issues may have been fixed under current releases of 2.5, 2.6, 2.7, and
3.X (http://bugs.python.org/issue2632).

Again, sorry for the spam, and thanks for offlineimap.

I'm marking as fix-released based on bug 793574 being fixed.
Offlineimap 6.3.3-3 is now in the archive and does not exhibit this issue.