Ubuntu
libcgi-application-plugin-authentication-perl package

build time tests fail with libcgi-pm-perl >=4.58

Bug #2047961 reported by Chris Peterson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libcgi-application-plugin-authentication-perl (Debian)
Fix Released
Unknown
libcgi-application-plugin-authentication-perl (Ubuntu)
Fix Released
High
Chris Peterson

Bug Description

Certain build test outputs are failing to match the expected output.

An example from build log:

696s t/80_devpopup.t .....................
696s 1..4
696s ok 1 - taint checking is on
696s # Subtest: front page
696s 1..2
696s ok 1 - frontpage
696s ok 2 - not authenticated
696s ok 2 - front page
696s # Subtest: interception
696s 1..2
696s ok 1 - login
696s ok 2 - not authenticated
696s ok 3 - interception
696s # Subtest: successful login
696s 1..4
696s not ok 1 - success
696s
696s # Failed test 'success'
696s # at /usr/share/perl5/Test/Regression.pm line 92.
696s # +---+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------+
696s # | Ln|Got |Expected |
696s # +---+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------+
696s # * 1|'Set-Cookie: CAPAUTH_DATA=bGFzdF9hY2Nlc3M9MTcwMzQ1Nzg3MABjPXZWZnEreUdSNFQ3NVZ4ZWFOWXNFQjJoTjJ2OABsb2dpbl9hdHRlbXB0cz0wAHVzZXJuYW1lPXVzZXIxAGxhc3RfbG9naW49MTcwMzQ1Nzg3MA%3D%3D; path=/; expires=Mon, 23 Dec 2024 22:44:30 GMT |'Set-Cookie: CAPAUTH_DATA=; path=/; expires=; *
696s # | 2|Date |Date |
696s # | 3|Content-Type: text/html; charset=ISO-8859-1 |Content-Type: text/html; charset=ISO-8859-1 |
696s # | 4| | |
696s # +---+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------+

This is because the cookies expires date format changed in libcgpi-pm-perl in version 4.58, which the test normally strips out but is now using the incorrect regex.

Revision history for this message
Chris Peterson (cpete) wrote :
tags: added: update-excuse
Changed in libcgi-application-plugin-authentication-perl (Ubuntu):
assignee: Chris Peterson (cpete) → nobody
Revision history for this message
Chris Peterson (cpete) wrote :

I can't edit my previous comment, but attached is a fix which updates the failing tests.

Chris Peterson (cpete)
Changed in libcgi-application-plugin-authentication-perl (Ubuntu):
status: In Progress → New
Revision history for this message
Simon Quigley (tsimonq2) wrote :

Uploaded to Debian as an NMU.

Changed in libcgi-application-plugin-authentication-perl (Ubuntu):
status: New → In Progress
assignee: nobody → Chris Peterson (cpete)
importance: Undecided → High
Revision history for this message
Chris Peterson (cpete) wrote :

For clarity, I also forwarded this to the Debian vcs here:

https://salsa.debian.org/perl-team/modules/packages/libcgi-application-plugin-authentication-perl/-/merge_requests/1

Thanks Simon for the sponsorship!

Bug Watch Updater (bug-watch-updater)
Changed in libcgi-application-plugin-authentication-perl (Debian):
status: Unknown → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libcgi-application-plugin-authentication-perl - 0.23+~cs0.5-4

---------------
libcgi-application-plugin-authentication-perl (0.23+~cs0.5-4) unstable; urgency=medium

  * Update update-date-regex.patch to also work with CGI.pm < 4.58.
  * debian/rules: change component handling.
    Explicitly set --sourcedirectory for "main" component, and run it
    after the sub-components.
  * Declare compliance with Debian Policy 4.6.2.

 -- gregor herrmann <email address hidden> Fri, 05 Jan 2024 01:40:34 +0100

Changed in libcgi-application-plugin-authentication-perl (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.