drop python3-keyring from Recommends to Suggests

Bug #2045082 reported by Chris Peterson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-launchpadlib (Ubuntu)
Fix Released
Undecided
Dan Bungert

Bug Description

We should drop python3-keyring from Recommnds to Suggests. Having python3-keyring
as Recommends means it will always be installed when python-launchpadlib is
installed unless --no-install-recommends is specified. Many headless systems,
such as ubuntu-server, may require python-launchpadlib; but as far as I can
tell, there is no/limited need for a keyring service on a headless system.

The maintainers of python-launchpadlib have previously stated that
python3-keyring is not a hard dependency of python-launchpadlib and dropped
it from Depends to Suggests explicitly to avoid including unnecessary packages
on non-desktop machines[1]. There is a mismatch between the control file,
which moved python3-keyring to Recommends, and the changelog, which stated
Suggests. The wording in the changelog was updated to "Drop from Depends to
Recommends" in a later commit[2] (not currently in the imported source tree),
however if the motivation for the change is correct (which I believe it is),
then [2] should have moved python3-keyring from Recommends to Suggests.

A delta was previously introduced in python-secretstorage[3] to stop these
larger dependency packages from automatically being installed on server/cloud
images, however we should move the change here to python-launchpadlib as I
think it makes more sense semantically. The author of python-secretstorage has
also raised their concerns[4] with the delta we've introduced in that package,
which points out we are making python-secretstorage useless, and therefore the
dependent functionality in python3-keyring always useless (unless a Secret
Service package is already installed on the system).

I have already submitted a bug report[5] on Debian BTS to discuss this change
upstream, as well as a merge request[6] on the upstream VCS.

I will attach a debdiff with my proposed change.

[1] https://salsa.debian.org/python-team/packages/python-launchpadlib/-/commit/842dd5191ca3ef1acb800579b7a02cda6cbeeb31

[2] https://salsa.debian.org/python-team/packages/python-launchpadlib/-/commit/9ec5e3b0278f4c43422174a3a77d4075a88d7103

[3] http://changelogs.ubuntu.com/changelogs/pool/main/p/python-secretstorage/python-secretstorage_3.3.3-1ubuntu1/changelog

[4] https://bugs.launchpad.net/ubuntu/+source/python-secretstorage/+bug/2041695/comments/1

[5] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1056553

[6] https://salsa.debian.org/python-team/packages/python-launchpadlib/-/merge_requests/4

Revision history for this message
Chris Peterson (cpete) wrote :

Here are my changes. I'm not 100% sure if I've set the Maintainer field correctly though. Since this package is in main, it should be set to "Ubuntu Developers <email address hidden>", right?

Changed in python-launchpadlib (Ubuntu):
assignee: nobody → Ubuntu Sponsors (ubuntu-sponsors)
Chris Peterson (cpete)
Changed in python-launchpadlib (Ubuntu):
assignee: Ubuntu Sponsors (ubuntu-sponsors) → nobody
Revision history for this message
Chris Peterson (cpete) wrote :

I realized I did not build with -proposed enabled, so it did not build with Python3.12. Building with 3.12 shows this is blocked on the pending proposed migration for this package, which blocked on a change for lazr.restfulclient. See: https://bugs.launchpad.net/ubuntu/+source/python-launchpadlib/+bug/2045169

Revision history for this message
Dan Bungert (dbungert) wrote :

Can you tweak the comment in the changelog? It mentions demoting to Suggests but that's redundant with the v1.10.16-1.1 upload. I suggest a clarification in the changelog that the 1.10.16-1.1 upload didn't actually demote to Suggests the python3-keyring dependency.

Changed in python-launchpadlib (Ubuntu):
assignee: nobody → Dan Bungert (dbungert)
Revision history for this message
Chris Peterson (cpete) wrote :

Sure thing, thanks for the feedback. Here's a patch with the updated changelog.

Revision history for this message
Dan Bungert (dbungert) wrote :

Uploaded, thanks.

Changed in python-launchpadlib (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-launchpadlib - 1.11.0-1ubuntu1

---------------
python-launchpadlib (1.11.0-1ubuntu1) noble; urgency=medium

  * d/control: Drop python3-keyring from Recommends to Suggests (LP: #2045082)
    - Changelog v1.10.16-1.1 upload did not actually drop python3-keyring
      from Depends to Suggests, but Depends to Recommends instead.

 -- Chris Peterson <email address hidden> Tue, 28 Nov 2023 15:36:23 -0800

Changed in python-launchpadlib (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.