package network-manager 1.44.2-1ubuntu1 failed to install/upgrade: installed network-manager package post-installation script subprocess returned error exit status 10

other connections also had . in the name and had no problem migrating.

Thank you for providing the keyfiles as a reproducer!

I think this line in the migration script [1] is failing here. We need to catch and handle the error.
> ORIG_NAME=$(nmcli --get-values connection.id con show "$UUID")

The issue is, that this connection profile is apparently very old and doesn't get loaded into memory by modern NetworkManager anymore, therefor we cannot query NM about it. When trying to load it manually, I can see the following error in the journal:

$ nmcli con load UPTOWN.guests
$ journalctl -u NetworkManager -e
NetworkManager[126986]: <warn> [1697527301.3708] settings: load: failure to load "/etc/NetworkManager/system-connections/UPTOWN.guests": filename is not valid for a keyfile

[1] https://git.launchpad.net/network-manager/tree/debian/network-manager.postinst#n67

I created a patch which should fix the issue: https://code.launchpad.net/~slyon/network-manager/+git/network-manager/+merge/453731

This also needs SRU

Is the only problem the filename extension? Renaming it to UPTOWN.guests.nmconnection makes it loadable.

Should we still try to load these files by renaming them first? Or, should we iterate over the *.nmconnection files only instead of *?

NM can load keyfiles without any suffix, AFAIR. With my proposed patch it would migrate any keyfiles that are actually loaded by NM, skipping the other. We should not try to make it load (re-activate) old keyfiles, which NM isn't loading anymore itself, by renaming them.

hm Ok, in this case, the problem was the suffix actually:

root@mantic:/etc/NetworkManager/system-connections# nmcli con load /etc/NetworkManager/system-connections/UPTOWN.guests
Could not load file '/etc/NetworkManager/system-connections/UPTOWN.guests'
root@mantic:/etc/NetworkManager/system-connections# mv /etc/NetworkManager/system-connections/UPTOWN.guests /etc/NetworkManager/system-connections/UPTOWN
root@mantic:/etc/NetworkManager/system-connections# nmcli con load /etc/NetworkManager/system-connections/UPTOWN
root@mantic:/etc/NetworkManager/system-connections# nmcli con show
NAME UUID TYPE DEVICE
netplan-enp5s0 e1419a5e-5e1d-3fff-a17c-b2fc6d2cef99 ethernet enp5s0
lo e71fd408-7b42-49a1-af17-072edc915266 loopback lo
UPTOWN.guests 491fa5c8-68ef-4140-8679-dca422f5c262 wifi --
root@mantic:/etc/NetworkManager/system-connections#

It's considering the .guests a bad extension as far as I can see. Only removing the .guests makes it loadable. So we shouldn't load only .nmconnection files.

Right. The .guests suffix seems to be a problem here. But I don't know which suffixes are accepted/ignored now and in the future, so I'd avoid changing file names, as that will probably get us into other issues down the road (e.g. overwriting an already existing file of that new name).

The bugfix was staged for the "devel" series, as the archive is still frozen: https://git.launchpad.net/network-manager/log/

I'm uploading this into Mantic: https://git.launchpad.net/network-manager/log/?h=ubuntu/mantic

After restoring git history for bug #2038439 I've now uploaded this SRU into Mantic, using the `ubuntu-mantic` branch (tag: ubuntu/1.44.2-1ubuntu1.1):

https://launchpad.net/ubuntu/mantic/+queue?queue_state=1&queue_text=network-manager

Hello Steve, or anyone else affected,

Accepted network-manager into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network-manager/1.44.2-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I tested network-manager 1.44.2-1ubuntu1.1 inside a Mantic LXD container. Package installation/upgrade and Netplan migration of (valid) connection profiles worked nicely, according to the "Test Plan":

# Previous version of NM is installed
root@mm-nm-sru:~# dpkg -l network-manager
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-===============-===============-============-=========================================================
ii network-manager 1.44.2-1ubuntu1 amd64 network management framework (daemon and userspace tools)

# Creating test files
root@mm-nm-sru:~# cat /etc/NetworkManager/system-connections/UPTOWN.guests
[connection]
id=UPTOWN.guests
uuid=491fa5c8-68ef-4140-8679-dca422f5c262
type=wifi

[wifi]
ssid=UPTOWN.guests
mode=infrastructure
mac-address=E0:9D:31:09:84:54

[ipv6]
method=auto

[ipv4]
method=auto
root@mm-nm-sru:~# cat /etc/NetworkManager/system-connections/aaaUPTOWN
[connection]
id=aaaUPTOWN
uuid=491fa5c8-68ef-0000-1111-dca422f5c262
type=wifi

[wifi]
ssid=aaaUPTOWN
mode=infrastructure
mac-address=E0:9D:31:09:84:54

[ipv6]
method=auto

[ipv4]
method=auto
root@mm-nm-sru:~# sudo chmod 600 /etc/NetworkManager/system-connections/*UPTOWN*

# Valid connection profiles are loaded into the old NM version as keyfiles in /etc/NetworkManager/
root@mm-nm-sru:~# ls -la /etc/NetworkManager/system-connections/
total 16
drwxr-xr-x 2 root root 4096 Oct 18 13:11 .
drwxr-xr-x 7 root root 4096 Oct 18 13:11 ..
-rw------- 1 root root 199 Oct 18 13:11 UPTOWN.guests
-rw------- 1 root root 191 Oct 18 13:11 aaaUPTOWN
root@mm-nm-sru:~# sudo nmcli con reload
root@mm-nm-sru:~# nmcli c
NAME UUID TYPE DEVICE
aaaUPTOWN 491fa5c8-68ef-0000-1111-dca422f5c262 wifi --

# Upgrade to SRU version of NetworkManager
root@mm-nm-sru:~# vim /etc/apt/sources.list # enable -proposed
root@mm-nm-sru:~# apt update && apt install -t mantic-proposed network-manager
Hit:1 http://archive.ubuntu.com/ubuntu mantic InRelease
Hit:2 http://archive.ubuntu.com/ubuntu mantic-updates InRelease
Get:3 http://archive.ubuntu.com/ubuntu mantic-proposed InRelease [256 kB]
Hit:4 http://security.ubuntu.com/ubuntu mantic-security InRelease
Hit:5 http://archive.ubuntu.com/ubuntu mantic-backports InRelease
Get:6 http://archive.ubuntu.com/ubuntu mantic-proposed/main amd64 Packages [9428 B]
Get:7 http://archive.ubuntu.com/ubuntu mantic-proposed/main Translation-en [3480 B]
Get:8 http://archive.ubuntu.com/ubuntu mantic-proposed/main amd64 DEP-11 Metadata [7604 B]
Get:9 http://archive.ubuntu.com/ubuntu mantic-proposed/main amd64 c-n-f Metadata [292 B]
Get:10 http://archive.ubuntu.com/ubuntu mantic-proposed/restricted amd64 c-n-f Metadata [116 B]
Fetched 277 kB in 1s (532 kB/s)
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
3 packages can be upgraded. Run 'apt list --upgradable' to see them.
Reading package lists... Done
Building dependency tree... Done
R...

This bug was fixed in the package network-manager - 1.44.2-1ubuntu1.1

---------------
network-manager (1.44.2-1ubuntu1.1) mantic; urgency=medium

  * network-manager.postinst: Skip unknown connection profiles (LP: #2039503)
  * Update debian/gbp.conf

 -- Lukas Märdian <email address hidden> Wed, 18 Oct 2023 10:45:22 +0200

The verification of the Stable Release Update for network-manager has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.