Inetutils is failing almost all autopkgtests

Bug #2009814 reported by Dominik Viererbe
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
inetutils (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[Problem]

* All inetutils autopkgtests [1] fail (except for i386).

* The reason for the failures is a conflict between inetutils-ping and
  iputils-ping. The autopkgtests pass for i386, because iputils-ping does
  not build for i386 (See [2]).

[Proposed Changes]

* Stop building the inetutils-ping binary package. This solution was
  proposed/endorsed in the last #ubuntu-meeting (16.03.2023; [3]).

* Commit: [4]

* PPA: [5]

[Rationale]

* The package inetutils-telnet is required in Ubuntu main (See pending
  MIR [6]), because Debian transitioned its default `telnet` client from
  netkit-telnet to inetutils-telnet. This transition was postponed in
  Ubuntu for kinetic by having ubuntu-standard Recommend `netkit-telnet`
  instead of `telnet`.
  But now, netkit-telnet has been dropped altogether from Debian and
  process-removals is prompting us to also delete it from lunar [7].

* The package inetutils-telnet is required in Ubuntu main no later than
  April 13th 2023 due to the Ubuntu 23.04 Lunar Lobster release date.

* A working prototype using update-alternatives was created (See the
  comments below). This solution was discussed during the ubuntu-meeting.
  However, it was deemed unnecessary, because it increases runtime
  complexity, so it was ultimately not pursued in favor of dropping
  inetutils-ping.

[Test Plan]

1. Download the ubuntu lunar autopkgtest image with:
   autopkgtest-buildvm-ubuntu-cloud -r lunar

2. Checkout the proposed changes with:
   git clone -b ubuntu/devel https://git.launchpad.net/~dviererbe/ubuntu/+source/inetutils

3. Run the autopkgtests with:
   autopkgtest ./inetutils -- qemu autopkgtest-lunar-amd64.img

4. Check that the test pass. Expected output should contain:

@@@@@@@@@@@@@@@@@@@@ summary
test-commands PASS
test-root-commands PASS

[Other]

* inetutils-telnet is already seeded in lunar.standard as a replacement for netkit-telnet [8]

* This conflict demonstrates a problem for the MIR of inetutils-telnet.
  Assuming that inetutils-telnet will get into main; inetutils-telnet
  tests will fail every time a inetutils-* package fails, although they
  are in universe and the failure is unrelated.

[1] https://autopkgtest.ubuntu.com/packages/i/inetutils
[2] https://packages.ubuntu.com/lunar/iputils-ping
[3] https://ubottu.com/meetingology/logs/ubuntu-meeting/2023/ubuntu-meeting.2023-03-16-15.01.moin.txt
[4] https://code.launchpad.net/~dviererbe/ubuntu/+source/inetutils/+git/inetutils/+ref/ubuntu/devel
[5] https://launchpad.net/~dviererbe/+archive/ubuntu/lp-2009814-drop-ping/+packages
[6] https://launchpad.net/bugs/2008789
[7] https://packages.debian.org/bookworm/telnet
[8] https://git.launchpad.net/~dviererbe/ubuntu/+source/inetutils/commit/?id=3c0a08ea20c21bc0b9d98075510f8a3d6c0ec9df

Tags: patch

Related branches

description: updated
description: updated
Lukas Märdian (slyon)
Changed in inetutils (Ubuntu):
assignee: nobody → Dominik Viererbe (dviererbe)
tags: added: foundations-todo
removed: rls-ll-incoming
Revision history for this message
Lukas Märdian (slyon) wrote :

We'll try to implement update-alternatives for the ping binary, to make it co-installable.

Revision history for this message
Dominik Viererbe (dviererbe) wrote :

I added the update-alternatives capability for ping to inetutils-ping and iputils-ping.

I did some initial testing and everything seems to work. I configured it, so that iputils-ping will be used by default.

You can try out the patches here:
https://launchpad.net/~dviererbe/+archive/ubuntu/lp-2009814

I also attached the .debdiffs for inetutils and iputils.

It would be nice if we could upstream the changes to avoid ubuntu deltas. I will investigate this tomorrow.

Changed in inetutils (Ubuntu):
status: New → In Progress
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "patches.tar.xz" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Dominik Viererbe (dviererbe) wrote :

1. I found a typo in the debian/control file of both patches (notice duplicate ping6 instead of ping4/ping6):

Provides: ping (= 1.0), ping6 (= 1.0), ping6 (= 1.0)
Conflicts: ping (<< 1.0), ping6 (<< 1.0), ping6 (<< 1.0)

instead of:

Provides: ping (= 1.0), ping4 (= 1.0), ping6 (= 1.0)
Conflicts: ping (<< 1.0), ping4 (<< 1.0), ping6 (<< 1.0)

I attached a new tar that contains the fixed patches

2. I have trouble verifying that the patch fixes the problem

When I run autopkgtest in the source tree it passes all tests
"autopkgtest ./inetutils-2.4/ -- schroot lunar-amd64"

but when I run autopkgtest with my PPA (https://launchpad.net/~dviererbe/+archive/ubuntu/lp-2009814) installed I get

ERROR: erroneous package: rules extract failed with exit code 1

Revision history for this message
Dominik Viererbe (dviererbe) wrote :
Revision history for this message
Dominik Viererbe (dviererbe) wrote :

We decided in the Ubuntu-Meeting today that we want to drop the inetutils-ping package with an ubuntu delta.

summary: - Inetutils is failing almost all autopkgtests
+ [FFe] Inetutils is failing almost all autopkgtests
description: updated
Changed in inetutils (Ubuntu):
status: In Progress → New
Revision history for this message
Dominik Viererbe (dviererbe) wrote : Re: [FFe] Inetutils is failing almost all autopkgtests

Here is the autopkgtest output for lunar on an amd64 architecture.

Graham Inggs (ginggs)
Changed in inetutils (Ubuntu):
status: New → Incomplete
Revision history for this message
Graham Inggs (ginggs) wrote :

Why don't we just not test the inetutils-ping package during the autopkgtest?

This patch heavily borrows from dviererbe's patch.

Revision history for this message
Lukas Märdian (slyon) wrote :

Thanks ginggs, that works for me, too (and should make the MIR reviewer happy as well IMO).

Revision history for this message
Graham Inggs (ginggs) wrote :

If we only stop testing the inetutils-ping package instead of dropping it entirely, then we don't need to worry about users who may already be using inetutils-ping, and don't need to consider adding an inetutils-ping transitional package to iputils to migrate them over to iputils-ping.

Also, I don't believe a FeatureFreeze exception would be needed.

Revision history for this message
Dominik Viererbe (dviererbe) wrote :

I agree. Keeping inetutils-ping without a drawback for the inetutils-telnet MIR is a win-win.

Graham Inggs (ginggs) already build and tested it. Thanks!
- See PPA: https://launchpad.net/~ginggs/+archive/ubuntu/testing/+packages
- See autopkgtests: https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/?format=plain

Here are the direct links to the relevant test results. They all PASS.
amd64 test results:
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/amd64/i/inetutils/20230322_170634_c0ebb@/artifacts.tar.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/amd64/i/inetutils/20230322_170634_c0ebb@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/amd64/i/inetutils/20230322_170634_c0ebb@/result.tar

arm64 test results:
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/arm64/i/inetutils/20230322_143055_a1d82@/artifacts.tar.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/arm64/i/inetutils/20230322_143055_a1d82@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/arm64/i/inetutils/20230322_143055_a1d82@/result.tar

armhf test results:
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/armhf/i/inetutils/20230322_142058_b03f1@/artifacts.tar.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/armhf/i/inetutils/20230322_142058_b03f1@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/armhf/i/inetutils/20230322_142058_b03f1@/result.tar

i386 test results:
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/i386/i/inetutils/20230322_151133_67c9a@/artifacts.tar.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/i386/i/inetutils/20230322_151133_67c9a@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/i386/i/inetutils/20230322_151133_67c9a@/result.tar

ppc64el test results:
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/ppc64el/i/inetutils/20230322_141751_2d8f5@/artifacts.tar.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/ppc64el/i/inetutils/20230322_141751_2d8f5@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/ppc64el/i/inetutils/20230322_141751_2d8f5@/result.tar

s390x test results:
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/s390x/i/inetutils/20230322_162636_1d326@/artifacts.tar.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/s390x/i/inetutils/20230322_162636_1d326@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-lunar-ginggs-testing/lunar/s390x/i/inetutils/20230322_162636_1d326@/result.tar

Revision history for this message
Lukas Märdian (slyon) wrote :

Thanks, sponsored!

Changed in inetutils (Ubuntu):
status: Incomplete → Fix Committed
Graham Inggs (ginggs)
summary: - [FFe] Inetutils is failing almost all autopkgtests
+ Inetutils is failing almost all autopkgtests
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package inetutils - 2:2.4-2ubuntu1

---------------
inetutils (2:2.4-2ubuntu1) lunar; urgency=medium

  * Do not test the inetutils-ping package (LP: #2009814)

 -- Dominik Viererbe <email address hidden> Thu, 23 Mar 2023 11:32:35 +0200

Changed in inetutils (Ubuntu):
status: Fix Committed → Fix Released
Benjamin Drung (bdrung)
tags: removed: foundations-todo
Changed in inetutils (Ubuntu):
assignee: Dominik Viererbe (dviererbe) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.