Add ACCEL_LOCATION=base property for Dell clamshell models

Bug #1999782 reported by Andy Chi
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Critical
Andy Chi
systemd-hwe (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned

Bug Description

[ Impact ]

 * This fixes unwanted rotations on certain Dell clamshell laptop models with accelerator.
 * Dell would like to disable screen rotation of the platform eternally.
   Mark the accel sensor location to base to disable it.

[ Test Plan ]

 * On Dell laptops with model SKU 0C00 or 0C02 or 0C40 or 0C41 or 0C42

 * Rotate the laptop and the display should not be rotated, and has not orientation locker in UI

[ Where problems could occur ]

 * This is to add parameters for certain models in hwdb, and does not affect any other part of systemd.

[ Other info ]
 * Commit backport from Upstream:
   https://github.com/systemd/systemd/pull/25724
 * Commit backport from Upstream: https://github.com/systemd/systemd/commit/8d4f1337e89eee222ff2e138980681d64e25c053
 * Commit backport from Upstream:
   https://github.com/systemd/systemd/pull/25935

Related branches

Andy Chi (andch)
tags: added: oem-priority originate-from-1998072 somerville
Andy Chi (andch)
affects: systemd-hwe (Ubuntu) → systemd (Ubuntu)
Changed in oem-priority:
importance: Undecided → Critical
assignee: nobody → Andy Chi (andch)
Andy Chi (andch)
affects: systemd (Ubuntu) → systemd-hwe (Ubuntu)
Revision history for this message
Nick Rosbrook (enr0n) wrote :

Are Jammy and Kinetic the SRU targets for this?

Revision history for this message
Andy Chi (andch) wrote :

Hi Nick,
Yes, Jammy and Kinetic are the SRU targets.

Revision history for this message
Andy Chi (andch) wrote :

Upload debdiff of jammy

Revision history for this message
Andy Chi (andch) wrote :

Upload debdiff of Kinetic

Revision history for this message
Nick Rosbrook (enr0n) wrote :

Thanks for the patches. For future reference we have a git repo for this package[1]. I have converted your debdiffs into git commits and opened PRs (linked to this bug now).

[1] https://code.launchpad.net/~canonical-foundations/+git/systemd-hwe

Revision history for this message
Nick Rosbrook (enr0n) wrote :

I also created the ubuntu-lunar branch for systemd-hwe and pushed this change. It has not been uploaded yet, however.

Changed in systemd-hwe (Ubuntu):
status: New → Fix Committed
Revision history for this message
Andy Chi (andch) wrote :

Hi Nick,
Thanks for your information.

Lukas Märdian (slyon)
Changed in systemd-hwe (Ubuntu Jammy):
status: New → In Progress
Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you very much for the git merge proposals, this makes it very easy to review and compare!

The changes match systemd's upstream changes and LGTM! Some remarks:

Jammy:
ACK. sponsored into the UNAPPROVED queue for SRU review

Kinetic:
LGTM, but I think we should adopt the version string to "251.4.1" to match the corresponding systemd version in Kinetic. Please update this MP

Lunar:
LGTM. Is the "ubuntu-lunar" branch ready for sponsorship? Is so, feel free to "gbp tag" that release inside the git repo and I can sponsor it.

Lukas Märdian (slyon)
Changed in systemd-hwe (Ubuntu Kinetic):
status: New → In Progress
Revision history for this message
Lukas Märdian (slyon) wrote :

All sponsored. Thank you!

Revision history for this message
Andy Chi (andch) wrote :

Thank you Lukas!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd-hwe - 252.1.1

---------------
systemd-hwe (252.1.1) lunar; urgency=medium

  [ Lukas Märdian ]
  * Add d/gbp.conf

  [ Andy Chi ]
  * hwdb.d: add Dell models that need ACCEL_LOCATION=base (LP: #1999782)

  [ Nick Rosbrook ]
  * debian/gbp.conf: update for lunar

 -- Nick Rosbrook <email address hidden> Wed, 04 Jan 2023 13:01:18 -0500

Changed in systemd-hwe (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Lukas Märdian (slyon) wrote :

We might want to bundle this SRU with bug #2002388 before doing the SRUs...

Lukas Märdian (slyon)
description: updated
Revision history for this message
Lukas Märdian (slyon) wrote :

I bundled the changes for SKU 0C40 (LP: #2002388) into this upload (and adopted the SRU template in the description accordingly). re-uploaded into the corresponding SRU review queues.

Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Bundling bug #2002065 as well, and adopted this bug's description accordingly. (SKU 0C41 & 0C42)

description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Andy, or anyone else affected,

Accepted systemd-hwe into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd-hwe/251.4.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in systemd-hwe (Ubuntu Kinetic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-kinetic
Changed in systemd-hwe (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Andy, or anyone else affected,

Accepted systemd-hwe into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd-hwe/249.11.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Andy Chi (andch) wrote :

Install systemd-hwe/249.11.2 on ACS4-DVT1-C2_202209-30610, the screen won't rotate and no orientation locker in UI.

Revision history for this message
Andy Chi (andch) wrote :

Install systemd-hwe/251.4.3 on ACS4-DVT1-C2_202209-30610, the screen won't rotate and no orientation locker in UI.

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

The screen rotation is disabled on OCBYM-DVT1.1-C1_202211-30882 after installing the package in jammy-proposed.

systemd-hwe-hwdb:
  Installed: 249.11.2
  Candidate: 249.11.2
  Version table:
 *** 249.11.2 500
        500 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     249.11.1 500
        500 http://tw.archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
        500 http://tw.archive.ubuntu.com/ubuntu jammy-updates/main i386 Packages

Andy Chi (andch)
tags: added: verification-done verification-done-jammy verification-done-kinetic
removed: verification-needed verification-needed-jammy verification-needed-kinetic
Revision history for this message
Dirk Su (dirksu) wrote :

Install systemd-hwe-hwdb 249.11.2 on CBM16P-DVT2-C1_202301-31088 (0C41), screen rotation is disabled.

Andy Chi (andch)
Changed in oem-priority:
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd-hwe - 251.4.3

---------------
systemd-hwe (251.4.3) kinetic; urgency=medium

  * Add ACCEL_LOCATION=base property for Dell clamshell models (LP: #1999782)

  [ Kai-Chuan Hsieh ]
  * hwdb: Mark Dell platform accel sensor location to base

  [ Andy Chi ]
  * hwdb.d: add Dell models that need ACCEL_LOCATION=base

  [ Dirk Su ]
  * hwdb: Add Dell models that require ACCEL_LOCATION=base

 -- Lukas Märdian <email address hidden> Tue, 10 Jan 2023 15:04:48 +0100

Changed in systemd-hwe (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for systemd-hwe has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd-hwe - 249.11.2

---------------
systemd-hwe (249.11.2) jammy; urgency=medium

  * Add ACCEL_LOCATION=base property for Dell clamshell models (LP: #1999782)

  [ Kai-Chuan Hsieh ]
  * hwdb: Mark Dell platform accel sensor location to base

  [ Andy Chi ]
  * hwdb.d: add Dell models that need ACCEL_LOCATION=base

  [ Dirk Su ]
  * hwdb: Add Dell models that require ACCEL_LOCATION=base

 -- Lukas Märdian <email address hidden> Tue, 10 Jan 2023 15:10:55 +0100

Changed in systemd-hwe (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.