FTBFS due to syntax error in test.sh

Bug #1990578 reported by Nick Rosbrook
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
socat (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Due to incorrect quoting in some awk statements in test.sh, socat FTBFS: https://launchpadlibrarian.net/624292174/buildlog_ubuntu-kinetic-amd64.socat_1.7.4.1-3ubuntu4_BUILDING.txt.gz. The relevant portion is this:

make[2]: Entering directory '/<<PKGBUILDDIR>>'
./test.sh
Using temp directory /tmp/buildd/7466
testing if address array is sorted... ok
testing if address options are sorted... ok
./test.sh: line 1924: syntax error near unexpected token `}'
./test.sh: line 1924: ` CYGWIN*) l="$(ps -pafe |grep "^[^ ]*[ ][ ]*[^ ][^ ]*[ ][ ]*$1[ ]" |awk '{print($2)';})" ;;'
make[2]: *** [Makefile:186: test] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: error: make -j4 test "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 returned exit code 2
make[1]: *** [debian/rules:19: override_dh_auto_test] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:25: binary-arch] Error 2
dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit status 2

This is fixed upstream by a larger commit (https://repo.or.cz/socat.git/commit/ff51262e). It would probably be best at this stage in the Kinetic cycle to add a patch just the quoting fix.

Tags: ftbfs
Nick Rosbrook (enr0n)
tags: added: ftbfs
Nick Rosbrook (enr0n)
Changed in socat (Ubuntu):
status: New → In Progress
assignee: nobody → Nick Rosbrook (enr0n)
importance: Undecided → Medium
Revision history for this message
Nick Rosbrook (enr0n) wrote :
Changed in socat (Ubuntu):
status: In Progress → Confirmed
status: Confirmed → New
assignee: Nick Rosbrook (enr0n) → nobody
Revision history for this message
Robie Basak (racb) wrote :

Sponsored, thanks. Looks like bash changed behaviour and now fails at the time the function is defined, whereas previously that code path never ran so it never failed.

Changed in socat (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package socat - 1.7.4.1-3ubuntu5

---------------
socat (1.7.4.1-3ubuntu5) kinetic; urgency=medium

  * debian/patches/09-test.sh-fix-awk-statement-quoting.sh: Fix FTBFS by using
    correct quoting around awk statements in test.sh (LP: #1990578).

 -- Nick Rosbrook <email address hidden> Thu, 22 Sep 2022 15:26:22 -0400

Changed in socat (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.