Microrelease update in all supported releases

Bug #1987914 reported by Lucas Kanashiro
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
haproxy (Ubuntu)
Invalid
Undecided
Unassigned
Bionic
Won't Fix
Undecided
Unassigned
Focal
Fix Released
Undecided
Lucas Kanashiro
Jammy
Fix Released
Undecided
Lucas Kanashiro

Bug Description

This bug tracks an update for the HAProxy package in the following Ubuntu releases to the versions below:

 * Jammy (22.04): HAProxy 2.4.18
 * Focal (20.04): HAProxy 2.0.29

These updates include bugfixes only following the SRU policy exception defined at https://wiki.ubuntu.com/HAProxyUpdates.

[Upstream changes]

* Jammy - HAProxy 2.4.18 changelog

http://git.haproxy.org/?p=haproxy-2.4.git;a=blob;f=CHANGELOG;h=f9eec74b396acad56a0b6ad848506d3e8117f197;hb=HEAD

* Focal - HAProxy 2.0.29 changelog

http://git.haproxy.org/?p=haproxy-2.0.git;a=blob;f=CHANGELOG;h=6ae4bedc8287458d6378b901993c6c92568fbc97;hb=HEAD

[Test Plan]

Upstream is not hosting those minor versions of LTS releases on GitHub, only in git.haproxy.org. In order to workaround that, I created a fork on GitHub, pulled the tags from git.haproxy.org and pushed them to the fork, then triggered GitHub Actions (TravisCI was not triggered because it requires a subscription).

* Jammy - HAProxy 2.4.18

https://github.com/lucaskanashiro/haproxy/actions?query=branch%3Abranch-v2.4.18++

autopkgtest local run:

autopkgtest [16:34:24]: @@@@@@@@@@@@@@@@@@@@ summary
cli PASS
proxy-localhost PASS

* Focal - HAProxy 2.0.29

https://github.com/lucaskanashiro/haproxy/actions?query=branch%3Abranch-v2.0.29++

There is a failing test but when it was executed in MacOS which does not impact Ubuntu.

autopkgtest local run:

autopkgtest [09:41:25]: @@@@@@@@@@@@@@@@@@@@ summary
cli PASS
proxy-localhost PASS

I sent an email to the upstream mailing list asking to also host those minor versions of LTS releases on GitHub, so next time we do not need to do all of that.

https://<email address hidden>/msg42674.html

[Regression Potential]

HAProxy itself does not have many reverse dependencies, however, any upgrade is a risk to introduce some breakage to other packages. Whenever a test failure is detected, we will be on top of it and make sure it doesn't affect existing users.

Related branches

CVE References

description: updated
description: updated
Changed in haproxy (Ubuntu):
status: New → Invalid
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

The HAProxy 1.8 stable branch does not have any CI tests definition. Due to that, I am aborting the update in Bionic since we do not have an automated way to check if everything is all right, and according to the MRE doc we do need the CI logs to move on with the update.

description: updated
Changed in haproxy (Ubuntu Bionic):
status: New → Won't Fix
description: updated
Changed in haproxy (Ubuntu Focal):
status: New → In Progress
Changed in haproxy (Ubuntu Jammy):
status: New → In Progress
Changed in haproxy (Ubuntu Focal):
assignee: nobody → Lucas Kanashiro (lucaskanashiro)
Changed in haproxy (Ubuntu Jammy):
assignee: nobody → Lucas Kanashiro (lucaskanashiro)
tags: added: server-todo
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Lucas, or anyone else affected,

Accepted haproxy into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/haproxy/2.4.18-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in haproxy (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Changed in haproxy (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Lucas, or anyone else affected,

Accepted haproxy into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/haproxy/2.0.29-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

The package built fine in both Jammy and Focal and the autopkgtest is still passing for both (no regressions found).

## Jammy

autopkgtest [11:34:24]: @@@@@@@@@@@@@@@@@@@@ summary
cli PASS
proxy-localhost PASS

## Focal

autopkgtest [11:44:34]: @@@@@@@@@@@@@@@@@@@@ summary
cli PASS
proxy-localhost PASS

tags: added: verification-done verification-done-focal verification-done-jammy
removed: verification-needed verification-needed-focal verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package haproxy - 2.4.18-0ubuntu1

---------------
haproxy (2.4.18-0ubuntu1) jammy; urgency=medium

  * New upstream release (LP: #1987914). Major bug fixes according to the
    upstream changelog:
    - mux-pt: Always destroy the backend connection on detach
    - mux_pt: always report the connection error to the conn_stream
    - connection: Never remove connection from idle lists outside the lock
    - dns: multi-thread concurrency issue on UDP socket

 -- Lucas Kanashiro <email address hidden> Thu, 25 Aug 2022 15:52:23 -0300

Changed in haproxy (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for haproxy has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package haproxy - 2.0.29-0ubuntu1

---------------
haproxy (2.0.29-0ubuntu1) focal; urgency=medium

  * New upstream release (LP: #1987914).
    - Major and critical bug fixes according to the upstream changelog:
      + http-ana: Always abort the request when a tarpit is triggered
      + list: fix invalid element address calculation
      + proxy_protocol: Properly validate TLV lengths
      + hpack: never index a header into the headroom after wrapping
      + stream-int: always detach a faulty endpoint on connect failure
      + stream: Mark the server address as unset on new outgoing connection
      + dns: Make the do-resolve action thread-safe
      + contrib/spoa-server: Fix unhandled python call leading to memory leak
      + mux-h2: Don't try to send data if we know it is no longer possible
      + spoe: Be sure to remove all references on a released spoe applet
      + filters: Always keep all offsets up to date during data filtering
      + peers: fix partial message decoding
      + spoa/python: Fixing return None
      + dns: fix null pointer dereference in snr_update_srv_status
      + dns: disabled servers through SRV records never recover
      + mux-h2: Properly detect too large frames when decoding headers
      + server: prevent deadlock when using 'set maxconn server'
      + htx: Fix htx_defrag() when an HTX block is expanded
      + queue: set SF_ASSIGNED when setting strm->target on dequeue
      + server: fix deadlock when changing maxconn via agent-check
      + h2: enforce stricter syntax checks on the :method pseudo-header
      + htx: fix missing header name length check in htx_add_header/trailer
      + lua: use task_wakeup() to properly run a task once
      + http/htx: prevent unbounded loop in http_manage_server_side_cookies
      + spoe: properly detach all agents when releasing the applet
      + mux-h2: Be sure to always report HTX parsing error to the app layer
      + sched: prevent rare concurrent wakeup of multi-threaded tasks
      + mux-pt: Always destroy the backend connection on detach
      + dns: multi-thread concurrency issue on UDP socket
      + mux_pt: always report the connection error to the conn_stream
    - Refresh haproxy.service-*.patch.
    - Remove patches applied by upstream in debian/patches:
      + 0001-2.0-2.3-BUG-MAJOR-htx-fix-missing-header-name-length-check-i.patch
      + 0001-BUG-CRITICAL-hpack-never-index-a-header-into-the-hea.patch
      + 2.0-0001-BUG-MAJOR-h2-enforce-checks-on-the-method-syntax-bef.patch
      + CVE-2022-0711.patch
      + lp1894879-BUG-MEDIUM-dns-*.patch

 -- Lucas Kanashiro <email address hidden> Fri, 26 Aug 2022 17:07:24 -0300

Changed in haproxy (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.