Ubuntu
netplan.io package

netplan.io autopkgtest failures with NetworkManager 1.39.90

Bug #1987001 reported by Jeremy Bícha
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
NetworkManager
Fix Released
Unknown
netplan.io (Ubuntu)
Invalid
Undecided
Unassigned
network-manager (Ubuntu)
Fix Released
High
Unassigned

Bug Description

netplan.io's autopkgtests are failing with NetworkManager 1.40 RC1 (1.39.90).

https://autopkgtest.ubuntu.com/packages/n/netplan.io/kinetic/amd64

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/nm-1-40/NEWS

log excerpt:

======================================================================
FAIL: test_bond_mode_8023ad_adselect (__main__.TestNetworkManager)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.iNCkRv/build.oDI/src/tests/integration/bonds.py", line 147, in test_bond_mode_8023ad_adselect
    self.assertEqual(f.read().strip(), 'bandwidth 1')
AssertionError: 'stable 0' != 'bandwidth 1'
- stable 0
+ bandwidth 1

======================================================================
FAIL: test_bond_mode_balance_tlb_learn_interval (__main__.TestNetworkManager)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.iNCkRv/build.oDI/src/tests/integration/bonds.py", line 670, in test_bond_mode_balance_tlb_learn_interval
    self.assertEqual(f.read().strip(), '15')
AssertionError: '1' != '15'
- 1
+ 15
? +

Revision history for this message
Lukas Märdian (slyon) wrote :

I think this might be a real regression in NM.

Netplan is testing something like this (which worked nicely in the past):
    mybond:
      parameters:
        mode: 802.3ad
        ad-select: bandwidth

Therefore, /sys/class/net/mybond/bonding/ad_select should actually contain "bandwidth 1", not the default "stable 0" value.

Might be related to this?
https://github.com/NetworkManager/NetworkManager/commit/e064eb9d1361f5f17a092097807c452add8040bc

Same for learn-interval:
    mybond:
      parameters:
        mode: balance-tlb
        mii-monitor-interval: 5
        learn-packet-interval: 15

=> /sys/class/net/mybond/bonding/lp_interval should actually be "15"

Changed in netplan.io (Ubuntu):
status: Confirmed → Triaged
Changed in network-manager (Ubuntu):
importance: Undecided → High
Changed in netplan.io (Ubuntu):
importance: High → Undecided
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Lukas, could you report your findings to https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues ? Thanks!

Changed in network-manager (Ubuntu):
status: New → Triaged
Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Done: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1072 (I might not have the time to follow through with this, though)

Changed in netplan.io (Ubuntu):
status: Triaged → Invalid
Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Upstream is working on a solution.

Edit: a patch is available here: https://paste.centos.org/view/raw/514cdb0e

Changed in network-manager (Ubuntu):
status: Triaged → In Progress
Jeremy Bícha (jbicha)
Changed in network-manager (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 1.39.90-1ubuntu3

---------------
network-manager (1.39.90-1ubuntu3) kinetic; urgency=medium

  * Cherry-pick 2 patches to fix bonding regressions discovered
    with failing netplan autopkgtests. Thanks Lukas Märdian.
    (LP: #1987001)

 -- Jeremy Bicha <email address hidden> Thu, 25 Aug 2022 13:26:02 -0400

Changed in network-manager (Ubuntu):
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in network-manager:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.