Minimizing windows in gnome-flashback changes button colors

Bug #1986681 reported by voidstarstar
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Undecided
Unassigned
compiz (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

This bug causes users of gnome-flashback (specifically with the Yaru theme) to see colors change in the gnome-panels. The colors make it difficult to read window titles.

This was a regression that I did not notice in 16.04, but I did notice in 20.04. I have not tested it with 18.04 (or any other version).

[Test Plan]

Environment:
Ubuntu 20.04.4 LTS
GNOME 3.36.8
gnome-flashback 3.36.5
Yaru 20.04.10.1
Gnome Tweak Tool 3.34.0
Compiz 0.9.14.1

To reproduce:
1. Enable the Yaru-dark theme. Open Gnome Tweaks -> Appearance. Under Themes, set Applications to "Yaru-dark".
2. Open multiple windows.
3. Minimize the window that currently has focus by clicking on the associated button on the bottom panel.
4. Observe that the button colors on the panel have changed.

[Where problems could occur]

No known potential issues. The patch is very simple so it likely has no undesired side effects. If a new regression occurs, it will probably be related to the focus status of a window being incorrect.

[Other info]

This issue was previously submitted as a bug to gnome-flashback. A more in depth report and debugging history can be found there:
https://gitlab.gnome.org/GNOME/gnome-flashback/-/issues/76

Related branches

Revision history for this message
voidstarstar (voidstarstar) wrote :
Revision history for this message
voidstarstar (voidstarstar) wrote :
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

This was fixed in today's compiz upload to kinetic.

Changed in compiz:
status: New → Fix Committed
Changed in compiz (Ubuntu):
status: New → Fix Released
Revision history for this message
voidstarstar (voidstarstar) wrote :

The fix was tested on focal and jammy and I can confirm the bug is indeed squashed.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I have released upstream version 0.9.14.2 today, which includes this fix. So marking the upstream task as Fix Released.

Packages for Ubuntu focal and jammy are still in Unapproved queue.

Changed in compiz:
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello voidstarstar, or anyone else affected,

Accepted compiz into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/compiz/1:0.9.14.1+22.04.20220820-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in compiz (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
voidstarstar (voidstarstar) wrote :

I tested version 1:0.9.14.1+22.04.20220820-0ubuntu1 from -proposed in jammy on a clean livecd image.

Minimal testing was done:
1. Verified the bug exists by minimizing windows
2. Installed the -proposed packages and replaced/restarted compiz
3. Verified the bug no longer exists by minimizing windows
4. Tested a few very basic tasks to see if anything obvious is broken

Please let me know if anything else is needed.

Everything seems to work fine for me on jammy. I would be happy to test on focal as well. Thanks!

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.14.1+22.04.20220820-0ubuntu1

---------------
compiz (1:0.9.14.1+22.04.20220820-0ubuntu1) jammy; urgency=medium

  * event: use correct window when deciding if it should appear focused.
    Patch by Alberts Muktupāvels (LP: #1986681)

 -- Dmitry Shachnev <email address hidden> Sat, 20 Aug 2022 04:28:36 +0000

Changed in compiz (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for compiz has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello voidstarstar, or anyone else affected,

Accepted compiz into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/compiz/1:0.9.14.1+20.04.20220820-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in compiz (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
voidstarstar (voidstarstar) wrote :

Thank you for accepting this for focal!

I tested 1:0.9.14.1+20.04.20220820-0ubuntu1 from focal-proposed on a clean focal livecd image.

The same testing was done for focal as was done in jammy. Minimal testing was done:
1. Verified the bug exists by minimizing windows
2. Installed the -proposed packages and replaced/restarted compiz
3. Verified the bug no longer exists by minimizing windows
4. Tested a few very basic tasks to see if anything obvious is broken

Please let me know if anything else is needed.

Thanks again to everyone that helped work on this bug!

tags: added: verification-done-focal
removed: verification-needed-focal
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.14.1+20.04.20220820-0ubuntu1

---------------
compiz (1:0.9.14.1+20.04.20220820-0ubuntu1) focal; urgency=medium

  * event: use correct window when deciding if it should appear focused.
    Patch by Alberts Muktupāvels (LP: #1986681)

 -- Dmitry Shachnev <email address hidden> Sat, 20 Aug 2022 14:02:27 +0000

Changed in compiz (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.