[fwupd][SRU] Hide inhibited usb4 device in dell-dock plugin

We will also need https://github.com/fwupd/fwupd/commit/6b5d933e99dce7f2bf2b771176001191a3bab644
to be backported to 1.7 branches.

However, that will add a new API to libfwupdplugin, sound not something we should do.

kinetic already has 1.8.3 and that fix is landed in 1.8.2, so marking it fixed.

I agree with YC - we shouldn't be introducing new symbols to libfwupdplugin in 1.7.x release.

YC is already in progress to do an SRU for 1.8.3 to Jammy for a bunch of other bugs. I think just adding changelog item for this bug will solve it for Jammy.

Update jammy 1.8.3 change in ppa:

https://launchpad.net/~ycheng-twn/+archive/ubuntu/fwupd-jammy-4

I tried the version 1.8.3-1~22.04.1 on the ppa,
the result of get-devices works as expected,
I also tried to upgrade/downgrade the fws on my dell-dock-wd22tb4,
it also works well.

Hello hugh, or anyone else affected,

Accepted fwupd into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.8.3-1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

not sure why the binary packages are not ready?

needs extra action for it have a new deb binary compare to the one before SRU. It will be there very soon.

All autopkgtests for the newly accepted fwupd (1.8.3-1~22.04.1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.8.3-1~22.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#fwupd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

I tried the version - 1.8.3-1~22.04.1 in Jammy-Proposed channel,
it works well on "get-device","upgrade","downgrade",
everything works as expected.

And for the Error on #8,
Mario suspects it's related to the specific autopkgtest environment [0],
so I'm not going to change the tag further until the regressions has been identified.

[0] https://bugs.launchpad.net/oem-priority/+bug/1979963/comments/13

as mentions in [0], Please waive the autopkgtest error for the purpose of the SRU.
another commit [1] will skip this autopkgtest mtdram tests.

[0] https://bugs.launchpad.net/oem-priority/+bug/1979963/comments/14
[1] https://bugs.launchpad.net/oem-priority/+bug/1979963/comments/15

All autopkgtests for the newly accepted fwupd (1.8.3-1~22.04.1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.8.3-1~22.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#fwupd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

@ycheng-twn,

may I ask that any plan to release a new version for Focal in Q1 2023 ?

I believe the next target version would be 1.8.5+[1]

% rmadison fwupd
 fwupd | 0.7.0-0ubuntu4 | xenial | source, amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
 fwupd | 0.8.3-0ubuntu5.1 | xenial-security | source, amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
 fwupd | 0.8.3-0ubuntu5.1 | xenial-updates | source, amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
 fwupd | 1.0.6-2 | bionic | source, amd64, arm64, armhf, i386, ppc64el, s390x
 fwupd | 1.2.10-1ubuntu2~ubuntu18.04.5 | bionic-security | source, amd64, arm64, armhf, i386, ppc64el, s390x
 fwupd | 1.2.14-0~18.04.2 | bionic-updates | source, amd64, arm64, armhf, i386, ppc64el, s390x
 fwupd | 1.3.9-4 | focal | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.3.9-4ubuntu0.1 | focal-security | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.7.5-3 | jammy | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.7.9-1~20.04.1 | focal-updates | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.7.9-1~20.04.2 | focal-proposed | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.7.9-1~22.04.1 | jammy-updates | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.7.9-1~22.04.2 | jammy-proposed | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.8.4-2 | kinetic | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
 fwupd | 1.8.6-2 | lunar | source, amd64, arm64, armhf, ppc64el, riscv64, s390x

[1] Bug #1979963 “Upgrade fwupd to 1.8.3 in jammy to support HP Thun...” : Bugs : OEM Priority Project - https://bugs.launchpad.net/bugs/1979963

@hugh

Does focal's fwupd needs to bump version or SRU the commit [1] is enough?

[1] https://github.com/fwupd/fwupd/commit/4bf53196fc1198a0688b49bcd16cd0126823f434

The question i asked is because a lot of package dependency of 1.8.5-1 is not exist in focal. It requires more discussion with foundation team if we really need to bump the version to 1.8 for focal.

@kchsieh

Currently it needs to backport "fu_device_has_inhibit" function to make [1] work,
but as #1 and #2, they were not agreed to backport the symbol.

And as you said too many dependency of 1.8.5-1 is not exist in focal, so I am ok if we can just backport this commit or I don't think fwupd in focal can go any further?

[1] https://github.com/fwupd/fwupd/commit/4bf53196fc1198a0688b49bcd16cd0126823f434

the SRU for Jammy was not finished either, set it back to confirm.

@kchsieh

Do you think it's possible to go up 1.8.5 for Jammy?

@hugh712

we propose to transit to snap package, can you help to reply my question?

https://bugs.launchpad.net/somerville/+bug/2018980/comments/2

Regarding going to fwupd snap, there are a few open issues that still need to be fixed before the confined snap can promote to stable channel.

https://github.com/fwupd/fwupd/labels/snap

@superm1

Hello,

The classic fwupd snap in stable channel seems to be enough for this bug, do you know why we can't transit to it directly, but need to wait the confined snap to be in stable?

Thank,

It's less secure to let a classic snap be installed by default.

I build the fwupd [0] which includes [1] and [2].

[0] https://launchpad.net/~kchsieh/+archive/ubuntu/fwupd?field.series_filter=focal
[1] https://github.com/fwupd/fwupd/commit/6b5d933e99dce7f2bf2b771176001191a3bab644
[2] https://github.com/fwupd/fwupd/commit/4bf53196fc1198a0688b49bcd16cd0126823f434

I believe this commit [0] is also needed?
or it will face the autopkgtest error [1] again

[0] https://github.com/fwupd/fwupd/commit/d6a455e8567feaea923b546624025b86e5b8dee1
[1] https://bugs.launchpad.net/oem-priority/+bug/1979963/comments/14

I create the package on top of lp:1994143. The commit [1] is included.

[1] https://github.com/fwupd/fwupd/commit/d6a455e8567feaea923b546624025b86e5b8dee1

@kchsieh

Can I use this version [0] to verify Jammy?
is it a candidate for Jammy SRU?

[0] https://launchpad.net/~kchsieh/+archive/ubuntu/fwupd?field.series_filter=jammy

reply #26

No, we haven't determined if jammy would like to bump version. Please don't use it to verify jammy.
If you've done focal verification, can you update result?

Thanks,

@kchsieh

I'm still preparing the environment, will provide the feedback asap once I finish the verification.

@kchsieh

I verified the version in [0],
which can fix this issue,
and also I tried to upgrade/downgrade FWs without any problem.

[0] https://launchpad.net/~kchsieh/+archive/ubuntu/fwupd?field.series_filter=focal

@kchsieh

This issue is kind of urgent now,
if possible, please help to run the SRU for focal asap, thank you.

Upload debdiff for focal.

@superm1

Hello,

May I have your input of #31 SRU?
Do you see any risk to include fwupdplugin API 1.8.0 for a specific function to fwupd in focal? or should I bump version in focal instead of including required patch for the bug?

Thanks,

I think it's OK, as it's new symbol should be low risk to be done like this.

Upload debdiff for jammy.

Thank you! With Mario's comment in #33 I feel more confident in sponsoring this into Jammy and Focal.

The patches match the upstream commits (except some whitespace: tab vs spaces):
* https://github.com/fwupd/fwupd/commit/6b5d933e99dce7f2bf2b771176001191a3bab644
* https://github.com/fwupd/fwupd/commit/4bf53196fc1198a0688b49bcd16cd0126823f434

Please consider adding DEP-3 headers next time, so it's easier to understand the upstream status of a patch: https://dep-team.pages.debian.net/deps/dep3/

I've modified the SRU's version sting to match the schema that was used for previous SRUs, which we have in jammy-proposed and focal-proposed currently and adopt the .symbols file accordingly, to provide the new symbol:

```diff
diff --git a/debian/changelog b/debian/changelog
index 8912feb52..eccdd5c88 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,4 @@
-fwupd (1.7.9-1ubuntu1~22.04.2) jammy; urgency=medium
+fwupd (1.7.9-1~22.04.3) jammy; urgency=medium

   * Hide inhibited usb4 device in dell-dock plugin (LP: #1983451)
     d/p/0001-Do-not-show-unconnected-or-unreachable-devices-in-th.patch
diff --git a/debian/libfwupdplugin5.symbols b/debian/libfwupdplugin5.symbols
index 961cdef81..9235b9dcd 100644
--- a/debian/libfwupdplugin5.symbols
+++ b/debian/libfwupdplugin5.symbols
@@ -57,6 +57,7 @@ libfwupdplugin.so.5 libfwupdplugin5 #MINVER#
  LIBFWUPDPLUGIN_1.7.3@LIBFWUPDPLUGIN_1.7.3 1.7.3
  LIBFWUPDPLUGIN_1.7.4@LIBFWUPDPLUGIN_1.7.4 1.7.4
  LIBFWUPDPLUGIN_1.7.6@LIBFWUPDPLUGIN_1.7.6 1.7.9
+ LIBFWUPDPLUGIN_1.8.0@LIBFWUPDPLUGIN_1.8.0 1.7.9-1~22.04.3~
  fu_archive_firmware_get_type@LIBFWUPDPLUGIN_1.7.3 1.7.3
  fu_archive_firmware_new@LIBFWUPDPLUGIN_1.7.3 1.7.3
  fu_archive_get_type@LIBFWUPDPLUGIN_1.2.2 1.2.2
@@ -355,6 +356,7 @@ libfwupdplugin.so.5 libfwupdplugin5 #MINVER#
  fu_device_get_specialized_gtype@LIBFWUPDPLUGIN_1.3.3 1.3.3
  fu_device_get_type@LIBFWUPDPLUGIN_0.1.0 0.1.0
  fu_device_has_guid@LIBFWUPDPLUGIN_1.2.2 1.2.2
+ fu_device_has_inhibit@LIBFWUPDPLUGIN_1.8.0 1.7.9-1~22.04.3~
  fu_device_has_internal_flag@LIBFWUPDPLUGIN_1.5.5 1.5.5
  fu_device_has_parent_guid@LIBFWUPDPLUGIN_1.0.8 1.0.8
  fu_device_has_parent_physical_id@LIBFWUPDPLUGIN_1.6.2 1.6.2
```

An upload of fwupd to jammy-proposed has been rejected from the upload queue for the following reason: "changes file is missing entry for 1.7.9-1~22.04.2 to close #1994143".

The focal upload is fine to accept as soon as the jammy upload is fixed regarding the changes file

attach source change with -v1.7.9-1~22.04.1 while building the source.

Re-uploaded the jammy changeset, using proper `-v1.7.9-1~22.04.1` parameters.

Hi,

May I ask is there any update on this SRU?

Hello hugh, or anyone else affected,

Accepted fwupd into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.9-1~22.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello hugh, or anyone else affected,

Accepted fwupd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.9-1~20.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I tried the version - 1.7.9-1~20.04.3 in focal-Proposed channel,
it works well on "get-device","upgrade","downgrade",
everything works as expected.

I tried the version - 1.7.9-1~22.04.3 in jammy-Proposed channel,
it works well on "get-devices","upgrade","downgrade",
everything works as expected.

@ahasenack,

Hello,
May I ask that is this package will land to update channel in this week?

Hi @hugh712,

This Thursday (when it's my SRU shift day) it's a holiday where I live, so I won't be doing SRU processing this week.

That being said, any SRU team member can handle this bug until I'm on shift again, it doesn't have to be me.

Hi @sil2100,

I believe this SRU already satisfy all condition to release to update pocket without any blocker,
sorry to push, would you please help to release this package to update since it's kind of urgent,
and seems SRU Team won't publish any package on Friday, thank you.

This bug was fixed in the package fwupd - 1.7.9-1~22.04.3

---------------
fwupd (1.7.9-1~22.04.3) jammy; urgency=medium

  * Hide inhibited usb4 device in dell-dock plugin (LP: #1983451)
    d/p/0001-Do-not-show-unconnected-or-unreachable-devices-in-th.patch
    d/p/0001-trivial-don-t-show-devices-with-inhibit-id-hidden.patch

fwupd (1.7.9-1~22.04.2) jammy; urgency=medium

  * d/p/0001_make_sure_mtdram_is_set_up.patch: Upstreamed patch that
    fix the false alarm in the autopkgtest (LP: #1994143)

 -- Kai-Chuan Hsieh <email address hidden> Wed, 17 May 2023 13:35:19 +0800

The verification of the Stable Release Update for fwupd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package fwupd - 1.7.9-1~20.04.3

---------------
fwupd (1.7.9-1~20.04.3) focal; urgency=medium

  * Hide inhibited usb4 device in dell-dock plugin (LP: #1983451)
    d/p/0001-Do-not-show-unconnected-or-unreachable-devices-in-th.patch
    d/p/0001-trivial-don-t-show-devices-with-inhibit-id-hidden.patch

fwupd (1.7.9-1~20.04.2) focal; urgency=medium

  * d/p/0001_make_sure_mtdram_is_set_up.patch: Upstreamed patch that
    fix the false alarm in the autopkgtest (LP: #1994143)

 -- Kai-Chuan Hsieh <email address hidden> Thu, 11 May 2023 10:21:37 +0800