Spurious Pacemaker errors: couldn't create file for mmap

Hello René, thank you for submitting this report. Based on the info you provided it seems like the upstream fix you provided would fix the issue. We've added the fix to our upcoming release but it is not currently in 22.04. As such, I created a PPA with the fix for Jammy, located at:

https://launchpad.net/~lvoytek/+archive/ubuntu/libqb-retry-posix-fallocate-jammy

The code for the fix is here:

https://git.launchpad.net/~lvoytek/ubuntu/+source/libqb/commit/?id=cc8029c9ad0865bed61df1741ad8ad156fc7afac

If you would like to try it on your system to make sure it works you can run the following commands:

sudo add-apt-repository ppa:lvoytek/libqb-retry-posix-fallocate-jammy
sudo apt update
sudo apt upgrade

Thank you,

We've been using a local build of libqb with the above patch since last week, and it does indeed resolve the problem.

That's great to hear! I will work to get this fix into 22.04 then so that the ppa will no longer be needed. Thanks!

It seems odd to me to retry only up to five times. The usual way to handle EINTR is to retry indefinitely, and if the process were to keep receiving signals such that it couldn't make any progress at all, then would be expected behaviour here, and a bug in whatever is keeping up such a signal rate. This is what the (GNU-specific) TEMP_FAILURE_RETRY does, for example: https://www.gnu.org/software/libc/manual/html_node/Interrupted-Primitives.html

So I think the upstream fix could do with improving here.

But in the meantime I think it's fine to grab the upstream fix as-is, as it's unlikely to make a difference in this case.

I also noticed that the commit that actually landed upstream (https://github.com/ClusterLabs/libqb/commit/176eae8f13278a5a3dab3699b84e1dc9a8d4ae11) slightly mismatches the patch uploaded here (https://github.com/ClusterLabs/libqb/commit/2e259c9d6e13968665678745f1e774bc4ccf8806). But they look functionally equivalent in this case, so I think it's probably not worth fixing now.

There's a minor change in the EINTR failure case here. Before, the code would error unwind. Now, it continues regardless even when the retry count is exceeded. But I think that's also fine in this case because the nature of posix_fallocate is advisory. There's a minor difference in that a disk full error might then happen later, but that seems unlikely to result in a regression to me.

Hello René, or anyone else affected,

Accepted libqb into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libqb/2.0.4-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

For the record, the package in jammy-proposed resolves the issue for us.

Thanks for the update René, I'll mark the verification as complete so this can get into the release pocket

This bug was fixed in the package libqb - 2.0.4-1ubuntu0.1

---------------
libqb (2.0.4-1ubuntu0.1) jammy; urgency=medium

  * d/p/retry-if-posix-fallocate-interrupted-eintr.patch: Retry posix_fallocate
    when the error - couldn't create file for mmap - occurs (LP: #1978955)

 -- Lena Voytek <email address hidden> Wed, 22 Jun 2022 11:52:46 -0700

The verification of the Stable Release Update for libqb has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.