lock screen message appeared during an SSH upgrade

Bug #1973785 reported by Brian Murray
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

Server users will see an unnecessary error message about failing to disable the lock screen, which may cause confusion.

[Test Plan]

* Obtain a console on Impish server, e.g. ssh to a remote host.
* Verify that XDG_SESSION_TYPE is set to 'tty':

  $ echo $XDG_SESSION_TYPE

* Start a release upgrade:

  $ do-release-upgrade

* After accepting the prompt to start the upgrade, observe the "Unable to disable lock screen" message.

[Where problems could occur]

The patch changes the early-return condition in the except block in _inhibitIdle. If problems occurred, it would be related to the "Unable to disable lock screen" message.

[Original Description]

I was upgrading and Ubuntu 20.04 system to Ubuntu 22.04 over an ssh connection and noticed the following message:

`Unable to disable lock screen

It is highly recommended that the lock screen be disabled during the
upgrade to prevent later issues. Please ensure your screen lock is
disabled before continuing.

To continue please press [ENTER]`

Given that I'm connected via ssh the message seems unnecessary. Some details from main.log:

bdmurray@clean-focal-amd64:~$ head /var/log/dist-upgrade/main.log
2022-05-17 07:59:05,380 INFO Using config files '['./DistUpgrade.cfg.focal', '/etc/update-manager/release-upgrades.d/ubuntu-advantage-upgrades.cfg']'
2022-05-17 07:59:05,381 INFO uname information: 'Linux clean-focal-amd64 5.13.0-41-generic #46~20.04.1-Ubuntu SMP Wed Apr 20 13:16:21 UTC 2022 x86_64'
2022-05-17 07:59:05,677 INFO apt version: '2.0.6'
2022-05-17 07:59:05,677 INFO python version: '3.8.10 (default, Mar 15 2022, 12:22:08)
[GCC 9.4.0]'
2022-05-17 07:59:05,679 INFO release-upgrader version '22.04.10' started

Related branches

tags: added: jammy kinetic
description: updated
Nick Rosbrook (enr0n)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:22.10.3

---------------
ubuntu-release-upgrader (1:22.10.3) kinetic; urgency=medium

  * DistUpgrade: Do not show lock screen error if XDG_SESSION_TYPE is
    tty (LP: #1973785).

 -- Nick Rosbrook <email address hidden> Wed, 18 May 2022 09:38:56 -0700

Changed in ubuntu-release-upgrader (Ubuntu):
status: New → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Brian, or anyone else affected,

Accepted ubuntu-release-upgrader into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:22.04.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-release-upgrader (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Nick Rosbrook (enr0n) wrote :

I have tested upgrade from Impish to Jammy with package version 1:22.04.11 using the test plan above (and appending --proposed to do-release-upgrade), and I have verified this issue is fixed.

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:22.04.11

---------------
ubuntu-release-upgrader (1:22.04.11) jammy; urgency=medium

  [ William 'jawn-smith' Wilson ]
  * DistUpgrade/DistUpgradeQuirks.py: Remove section of netplan
    config that is installed by default on Raspberry Pi and
    causes netplan failures after upgrade to jammy (LP: #1970761)

  [ Nick Rosbrook ]
  * DistUpgrade: Gracefully handle missing dbus module (LP: #1965568).
  * DistUpgrade: Do not show lock screen error if XDG_SESSION_TYPE is
    tty (LP: #1973785).
  * DistUpgrade: Add deb2snap entry for snapd-desktop-integration (LP: #1975747).
  * Run pre-build.sh: updating mirrors, demotions, and translations.

 -- Nick Rosbrook <email address hidden> Thu, 26 May 2022 10:49:26 -0400

Changed in ubuntu-release-upgrader (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.