Ubuntu
gnudatalanguage package

gnudatalanguage: small test_tic_toc tolerance

Bug #1973377 reported by Nick Rosbrook
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnudatalanguage (Debian)
Fix Released
Unknown
gnudatalanguage (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Imported from Debian bug http://bugs.debian.org/1002584:

Source: gnudatalanguage
Version: 1.0.1-3
Severity: normal
Tags: patch

Self-testing of this package, particularly TEST_TIC_TOC seems to run a
bit slower on arm64. Making graphicsmagick unable to migrate to testing.
The reason is simple, testsuite/test_tic_toc.pro defines tolerance on
line 49 to be 0.01 (1%) while the result is ~0.015 . I think it would be
better to increase it to 0.02 (2%) to let the test complete successfully.

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-9-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash

Nick Rosbrook (enr0n)
tags: added: update-excuse
Revision history for this message
Nick Rosbrook (enr0n) wrote :

This test is flaky on amd64 autopkgtest infrastructure too [1]. The staged change at [2] might help some, but there have been instances where the error percentage is higher than 2% [3].

[1] https://autopkgtest.ubuntu.com/packages/gnudatalanguage/kinetic/amd64
[2] https://salsa.debian.org/debian-astro-team/gnudatalanguage/-/commit/f09d02e45344f8b471b00549eeeb787ebfc6df90
[3] https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic/kinetic/amd64/g/gnudatalanguage/20220509_160221_5ffee@/log.gz

Bug Watch Updater (bug-watch-updater)
Changed in gnudatalanguage (Debian):
importance: Undecided → Unknown
status: New → Fix Committed
Revision history for this message
Nick Rosbrook (enr0n) wrote :
Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you, LGTM and passes a local test build.

I've fixed up a trailing whitespace in the "Origin:" DEP-3 patch header and adopted your special "1.0.1-3willsync1" version string slightly: We need a version that does not contain the word "ubuntu", so it can be auto-synced once the committed patch is uploaded into Debian.

But at the same time we need it to be bigger than the current version (1.0.1-3build2) and want it to be smaller than a potential future "1.0.1-3ubuntu1" version (e.g. if we need to add some additional patches that cannot be auto-synced). I came up with the following:

1.0.1-3build2 < 1.0.1-3maysync1 < 1.0.1-3ubuntu1

=> 1.0.1-3maysync1

PS: "1.0.1-3~willsync1" might have been another option, but that's in conflict (i.e. smaller than) the current "-3build2" version string.

Changed in gnudatalanguage (Ubuntu):
status: New → In Progress
Lukas Märdian (slyon)
Changed in gnudatalanguage (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnudatalanguage - 1.0.1-3maysync1

---------------
gnudatalanguage (1.0.1-3maysync1) kinetic; urgency=medium

  * debian/patches/Increase-test_tic_toc-tolerance.patch: Import Debian patch
    to increase tolerance used in test_tic_toc (LP: #1973377).

 -- Nick Rosbrook <email address hidden> Mon, 16 May 2022 16:18:21 -0400

Changed in gnudatalanguage (Ubuntu):
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gnudatalanguage (Debian):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.