Ubuntu
python-fluids package

Unpatched tests from .pc directory are executed as normal tests

Bug #1972805 reported by Olivier Gayot on 2022-05-10

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-fluids (Debian)	Fix Released	Unknown	debbugs #1010803
	python-fluids (Ubuntu)	In Progress	Undecided	Unassigned

Bug Description

Three autopkgtest tests are failing for python-fluids:

FAILED .pc/fix-online-tests.patch/tests/test_design_climate.py::test_month_average_temperature
FAILED .pc/fix-online-tests.patch/tests/test_design_climate.py::test_correct_WBAN
FAILED .pc/fix-online-tests.patch/tests/test_design_climate.py::test_get_station_year_text

These tests require network and are meant to be addressed by the patch in d/patches/fix-online-tests.patch

... and indeed they are addressed:

tests/test_design_climate.py::test_month_average_temperature PASSED [ 54%]
tests/test_design_climate.py::test_correct_WBAN PASSED [ 54%]
tests/test_design_climate.py::test_get_station_year_text SKIPPED (re...) [ 55%]

Unfortunately, pytest _also_ runs over the unpatched tests from the .pc directory. We should instruct pytest to not run over this directory.

Revision history for this message

Olivier Gayot (ogayot) wrote on 2022-05-10:

1-1.0.9-1__1.0.9-1ubuntu1.debdiff Edit (2.6 KiB, text/plain)

Adding debdiff to fix the autopkgtest failure.

The autopkgtest are not failing on Debian side (I'm guessing because they are executed with access to the Internet).

But tests in .pc directory are still executed so I think it's worth forwarding the patch.

Changed in python-fluids (Ubuntu):
assignee:	nobody → Olivier Gayot (ogayot)

Olivier Gayot (ogayot) on 2022-05-10

Changed in python-fluids (Ubuntu):
assignee:	Olivier Gayot (ogayot) → nobody
status:	New → Confirmed

Revision history for this message

Olivier Gayot (ogayot) wrote on 2022-05-10:

2-1.0.9-1__1.0.9-1ubuntu1.debdiff Edit (3.2 KiB, text/plain)

Uploading revised patch that includes dep3 headers.

The patch was forwarded to Debian at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010803

Revision history for this message

Lukas Märdian (slyon) wrote on 2022-05-10:

Thank you for updating the patch headers and forwarding it to Debian. LGTM.

$ dput ubuntu ../python-fluids_1.0.9-1ubuntu1_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: ../python-fluids_1.0.9-1ubuntu1_source.changes: Valid signature from BF7DB622B303AC8B
Checking signature on .dsc
gpg: ../python-fluids_1.0.9-1ubuntu1.dsc: Valid signature from BF7DB622B303AC8B
Uploading to ubuntu (via sftp to upload.ubuntu.com):
  Uploading python-fluids_1.0.9-1ubuntu1.dsc: done.
  Uploading python-fluids_1.0.9-1ubuntu1.debian.tar.xz: done.
  Uploading python-fluids_1.0.9-1ubuntu1_source.buildinfo: done.
  Uploading python-fluids_1.0.9-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Changed in python-fluids (Ubuntu):
status:	Confirmed → In Progress

Bug Watch Updater (bug-watch-updater) on 2022-05-12

Changed in python-fluids (Debian):
status:	Unknown → New

Bug Watch Updater (bug-watch-updater) on 2022-09-13

Changed in python-fluids (Debian):
status:	New → Fix Released

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2022-09-27:

Autopkgtests fail due to numerical precision when checking examples in the tutorial with pytest doctests. We should add the upstream patches fixing the issue.

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2022-09-27:

Building in ppa fails due to deprecation of llvmlite.llvmpy module:
https://launchpadlibrarian.net/625917827/buildlog_ubuntu-kinetic-amd64.python-fluids_1.0.9-1ubuntu2~ppa1_BUILDING.txt.gz