[SRU] WARNING: crmadmin -S <HOST> unexpected output

Bug #1972730 reported by Felipe Reyes
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack HA Cluster Charm
Invalid
Undecided
Unassigned
crmsh (Ubuntu)
Fix Released
Undecided
Athos Ribeiro
Jammy
Fix Released
Undecided
Athos Ribeiro
Kinetic
Fix Released
Undecided
Athos Ribeiro
Lunar
Fix Released
Undecided
Athos Ribeiro

Bug Description

[Impact]

when running a pacemaker cluster it is necessary to put nodes into maintenance mode to allow stopping services or other operational tasks, with the current version of crmsh shipped in the ubuntu archive this is not possible.

[Test Plan]

1) Deploy a cluster
Get the bundle available at https://paste.ubuntu.com/p/ftxtpPJwb2/ (also attached to this bug at https://bugs.launchpad.net/ubuntu/+source/crmsh/+bug/1972730/comments/24)
juju deploy ./jammy-yoga.yaml

2) Once the setup is complete put a node into maintenance with the following command:

juju ssh keystone/leader
sudo crm -w -F node maintenance $(hostname)

Expected result:

the node is put into maintenance mode

Actual result:

$ sudo crm -w -F node maintenance $(hostname)
ERROR: running cibadmin -Ql: Could not connect to the CIB: Transport endpoint is not connected
Init failed, could not perform requested operations
WARNING: crmadmin -S juju-49cb70-jammy-4 unexpected output: Controller on juju-49cb70-jammy-4 in state S_IDLE: ok (exit code: 0)

[Where problems could occur]

The proposed patch relaxes the check of the output of the command "crmadmin -S" which is used in the implementation of the method wait4dc() which is used to block until the pacemaker goes into idle state after a modification, so problems with this patch would have the symptom of crmsh trying to perform operations on a non idle pacemaker engine.

[Other info]

The patch proposed is already merged in the crmsh-4.3 branch

https://github.com/ClusterLabs/crmsh/commit/945654d00c8376d1ad8fbd4f6e82ee140b00409e

[Original Description]

Pacemaker changed the output string of "crmadmin -S <HOST>" in 2.1.0 with the commit https://github.com/ClusterLabs/pacemaker/commit/c26c9951d863e83126f811ee5b91a174fe0cc991 , this is different from the ouput that wait4dc() expects https://github.com/ClusterLabs/crmsh/blob/master/crmsh/utils.py#L898 .

Example output of `crm -w -F node maintenance <HOST>` of a cluster running on Ubuntu 22.04

```
root@juju-0c8f53-zaza-723eab24403d-4:~# crm -w -F node maintenance juju-0c8f53-zaza-723eab24403d-4
WARNING: crmadmin -S juju-0c8f53-zaza-723eab24403d-5 unexpected output: Controller on juju-0c8f53-zaza-723eab24403d-5 in state S_IDLE: ok (exit code: 0)
root@juju-0c8f53-zaza-723eab24403d-4:~# echo $?
1
root@juju-0c8f53-zaza-723eab24403d-4:~# crmadmin -S juju-0c8f53-zaza-723eab24403d-5
Controller on juju-0c8f53-zaza-723eab24403d-5 in state S_IDLE: ok
root@juju-0c8f53-zaza-723eab24403d-4:~# dpkg -l pacemaker crmsh | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-==============-============-===========================================
ii crmsh 4.3.1-1ubuntu2 all CRM shell for the pacemaker cluster manager
ii pacemaker 2.1.2-1ubuntu3 amd64 cluster resource manager
```

Upstream bug filed: https://github.com/ClusterLabs/crmsh/issues/970

Related branches

Revision history for this message
Felipe Reyes (freyes) wrote :

The way this error is exposed in the hacluster is when running the `stop` hook:

unit-hacluster-1: 16:53:41 DEBUG juju.worker.uniter.runner starting jujuc server {unix @/var/lib/juju/agents/unit-hacluster-1/agent.socket <nil>}
unit-hacluster-1: 16:53:41 INFO unit.hacluster/1.juju-log Setting node juju-0c8f53-zaza-723eab24403d-4 to maintenance
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop Traceback (most recent call last):
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop File "/var/lib/juju/agents/unit-hacluster-1/charm/hooks/stop", line 767, in <module>
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop hooks.execute(sys.argv)
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop File "/var/lib/juju/agents/unit-hacluster-1/charm/charmhelpers/core/hookenv.py", line 962, in execute
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop self._hooks[hook_name]()
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop File "/var/lib/juju/agents/unit-hacluster-1/charm/hooks/stop", line 617, in stop
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop pcmk.set_node_status_to_maintenance(node)
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop File "/var/lib/juju/agents/unit-hacluster-1/charm/hooks/pcmk.py", line 201, in set_node_status_to_maintenance
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop commit('crm -w -F node maintenance {}'.format(node_name),
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop File "/var/lib/juju/agents/unit-hacluster-1/charm/hooks/pcmk.py", line 90, in commit
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop return subprocess.check_output(cmd.split(), stderr=subprocess.STDOUT)
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop File "/usr/lib/python3.10/subprocess.py", line 420, in check_output
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop File "/usr/lib/python3.10/subprocess.py", line 524, in run
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop raise CalledProcessError(retcode, process.args,
unit-hacluster-1: 16:53:43 WARNING unit.hacluster/1.stop subprocess.CalledProcessError: Command '['crm', '-w', '-F', 'node', 'maintenance', 'juju-0c8f53-zaza-723eab24403d-4']' returned non-zero exit status 1.
unit-hacluster-1: 16:53:43 ERROR juju.worker.uniter.operation hook "stop" (via explicit, bespoke hook script) failed: exit status 1

Revision history for this message
Felipe Reyes (freyes) wrote :
Changed in charm-hacluster:
status: New → Invalid
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for working with upstream to fix this. Would you be willing to backport this fix to Jammy? Or do you prefer me to do it?

For Kinetic we will be moving to the newer version (4.4.0 as upstream suggested) so this will not be an issue. I am going to talk to the Debian maintainer to see if we can get version 4.4.0 in unstable so we can merge it.

tags: added: server-todo
Revision history for this message
Felipe Reyes (freyes) wrote : Re: [Bug 1972730] Re: WARNING: crmadmin -S <HOST> unexpected output

On Wed, 2022-05-11 at 19:13 +0000, Lucas Kanashiro wrote:
> Thanks for working with upstream to fix this. Would you be willing to
> backport this fix to Jammy? Or do you prefer me to do it?

I can propose the SRU (via debdiff) if you can sponsor it :-)

>
> For Kinetic we will be moving to the newer version (4.4.0 as upstream
> suggested) so this will not be an issue. I am going to talk to the
> Debian maintainer to see if we can get version 4.4.0 in unstable so we
> can merge it.

That's great, thanks.

Revision history for this message
Paride Legovini (paride) wrote : Re: WARNING: crmadmin -S <HOST> unexpected output

@Felipe sponsoring is certainly something we can do, however before proceeding with the SRU we need to fix the bug in the current Ubuntu devel release (kinetic). Ideally this should happen with Debian packaging 4.4.0 and Ubuntu syncing it, as Lucas mentioned. Filing a bug in Debian may help. If the Debian maintainers are not ready to package 4.4.0 soon then we can apply the patch to the 4.3.1 kinetic package and then proceed with the SRU.

Changed in crmsh (Ubuntu):
status: New → Triaged
Changed in crmsh (Ubuntu Jammy):
status: New → Triaged
Changed in crmsh (Ubuntu):
assignee: nobody → Athos Ribeiro (athos-ribeiro)
Changed in crmsh (Ubuntu Jammy):
assignee: nobody → Athos Ribeiro (athos-ribeiro)
Changed in crmsh (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package crmsh - 4.4.0-1ubuntu1

---------------
crmsh (4.4.0-1ubuntu1) kinetic; urgency=medium

  * Merge with Debian unstable (LP: #1971271, #1972730). Remaining changes:
    - d/t/pacemaker-node-status.sh: Get the node name with "crm_node -n"
      instead of using "corosync-cmapctl". Ubuntu's corosync default
      configuration file does not set the node name.
    - d/t/control: add resource-agents-extra as a dependency of some tests.
  * Dropped changes:
    - d/p/0020-Use-crmsh-hb_report.patch: use the crmsh shipped hb_report script
      when available (LP #1958247).
      [ The hb_report script is no longer present since 4.4.0. ]
    - d/p/0021-Support-python-310.patch: support Python 3.10 (LP #1958393).
      [ Included in 4.4.0. ]

 -- Athos Ribeiro <email address hidden> Tue, 31 May 2022 18:04:36 -0300

Changed in crmsh (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi Felipe,

Now this has migrated to kinetic, are you still willing to propose the SRU for this one? I'd be more than happy to sponsor it :)

You'd need to provide the debdiff (or a merge proposal for the git ubuntu repository) and fill in the SRU template in this bug (see https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template).

In case you are still willing to do it, let me know if you have any questions and I'd be more than happy to assist.

Revision history for this message
Felipe Reyes (freyes) wrote : Re: [Bug 1972730] Re: WARNING: crmadmin -S <HOST> unexpected output

On Thu, 2022-06-02 at 13:28 +0000, Athos Ribeiro wrote:
> Hi Felipe,
>
> Now this has migrated to kinetic, are you still willing to propose the
> SRU for this one? I'd be more than happy to sponsor it :)

I can do this, I will attach the debdiff and add the template today or tomorrow
and ping you for sponsoring :-) appreciated.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote : Re: WARNING: crmadmin -S <HOST> unexpected output

Thank you, Felipe!

Revision history for this message
Felipe Reyes (freyes) wrote :

Hi Athos, took me longer that expected to circle back to this SRU, but here it is, I'm attaching the debdiff for jammy and the SRU template is already updated.

description: updated
summary: - WARNING: crmadmin -S <HOST> unexpected output
+ [SRU] WARNING: crmadmin -S <HOST> unexpected output
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Felipe!

I applied the patch, split the changelog line, and added some DEP3 headers to the patch file. I hope this is OK :)

I filed an MP at https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/crmsh/+git/crmsh/+merge/426205 so we can keep the rich history when uploading this.

Let me know if you are OK with my (minor) changes so we can proceed with the SRU process.

Revision history for this message
Felipe Reyes (freyes) wrote : Re: [Bug 1972730] Re: [SRU] WARNING: crmadmin -S <HOST> unexpected output

On Mon, 2022-07-04 at 14:43 +0000, Athos Ribeiro wrote:
> Thanks, Felipe!
>
> I applied the patch, split the changelog line, and added some DEP3
> headers to the patch file. I hope this is OK :)
>
> I filed an MP at https://code.launchpad.net/~athos-
> ribeiro/ubuntu/+source/crmsh/+git/crmsh/+merge/426205 so we can keep the
> rich history when uploading this.
>
> Let me know if you are OK with my (minor) changes so we can proceed with
> the SRU process.
>

Thanks for those changes ;-) everything looks OK to me.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Felipe.

I uploaded the package, set the bug status and subscribed the SRU team here.

Changed in crmsh (Ubuntu Jammy):
status: Triaged → In Progress
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Felipe, or anyone else affected,

Accepted crmsh into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/crmsh/4.3.1-1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in crmsh (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Felipe Reyes (freyes) wrote :
Download full text (9.3 KiB)

Hello all,

I went through the verification of the SRU successfully, I found evidence of regressions with my cluster, here it the log of my terminal going through it.

$ juju status
Model Controller Cloud/Region Version SLA Timestamp
hacluster serverstack serverstack/serverstack 2.9.29 unsupported 09:36:25-04:00

App Version Status Scale Charm Channel Rev Exposed Message
hacluster active 3 hacluster edge 104 no Unit is ready and clustered
keystone 21.0.0 active 3 keystone edge 575 no Application Ready
keystone-mysql-router 8.0.29 active 3 mysql-router 8.0/stable 30 no Unit is ready
mysql-innodb-cluster 8.0.29 active 3 mysql-innodb-cluster 8.0/stable 26 no Unit is ready: Mode: R/W, Cluster is ONLINE and can tolerate up to ONE failure.

Unit Workload Agent Machine Public address Ports Message
keystone/0 active idle 3 10.5.0.147 5000/tcp Unit is ready
  hacluster/1 active idle 10.5.0.147 Unit is ready and clustered
  keystone-mysql-router/1 active idle 10.5.0.147 Unit is ready
keystone/1 active idle 4 10.5.2.108 5000/tcp Unit is ready
  hacluster/2 active idle 10.5.2.108 Unit is ready and clustered
  keystone-mysql-router/2 active idle 10.5.2.108 Unit is ready
keystone/2* active idle 5 10.5.0.30 5000/tcp Unit is ready
  hacluster/0* active idle 10.5.0.30 Unit is ready and clustered
  keystone-mysql-router/0* active idle 10.5.0.30 Unit is ready
mysql-innodb-cluster/0* active idle 0 10.5.1.86 Unit is ready: Mode: R/W, Cluster is ONLINE and can tolerate up to ONE failure.
mysql-innodb-cluster/1 active idle 1 10.5.2.126 Unit is ready: Mode: R/O, Cluster is ONLINE and can tolerate up to ONE failure.
mysql-innodb-cluster/2 active idle 2 10.5.2.100 Unit is ready: Mode: R/O, Cluster is ONLINE and can tolerate up to ONE failure.

Machine State Address Inst id Series AZ Message
0 started 10.5.1.86 12b64376-138c-44ca-8873-bcaa7e6e28de jammy nova ACTIVE
1 started 10.5.2.126 88874312-5829-40ec-b9c3-9d7c15a6d2bf jammy nova ACTIVE
2 started 10.5.2.100 e619a2d4-e7cc-4970-8dfd-10a67a84ee39 jammy nova ACTIVE
3 started 10.5.0.147 17c62da7-b9e5-4a1f-aab5-988a8dd55d28 jammy nova ACTIVE
4 started 10.5.2.108 9c17bd02-6bef-42e6-a5ae-e97bfac50014 jammy nova ACTIVE
5 started 10.5.0.30 b9f599a5-3687-45e5-a0fc-ca68f7e16daf jammy nova ACTIVE

$ juju ssh keystone/leader
...
ubuntu@juju-d7d86e-hacluster-5:~$ sudo crm status
Cluster Summary:
  * Stack: corosync
  * Current DC: juju-d7d8...

Read more...

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Felipe!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package crmsh - 4.3.1-1ubuntu3

---------------
crmsh (4.3.1-1ubuntu3) jammy; urgency=medium

  * d/p/lp1972730.patch: Handle the output of 'crmadmin -S' correctly
    (LP: #1972730).

 -- Felipe Reyes <email address hidden> Fri, 01 Jul 2022 10:59:50 -0400

Changed in crmsh (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for crmsh has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Felipe Reyes (freyes) wrote :

This issue is still present on kinetic. Kinetic was released with crmsh-4.4.0, although the upstream fix hasn't made it in any release to date[0], the last upstream release was 4.4.0 according to the tags in the repo[1]

So I'm adding tasks for Lunar and Kinetic since we'll need to carry a patch in distro, unless the server team prefers a different approach.

[0] https://github.com/ClusterLabs/crmsh/commit/50fe231d9ed188c8727d80bd7fb09d362c03ec32
[1] https://github.com/ClusterLabs/crmsh/releases

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

This was fixed in crmsh 4.4.0-3, and not in 4.4.0-1.

Lunar is fixed indeed, and jammy already carries the patch. We now need to patch kinetic by backporting d/0019-Fix-crmadmin-parsing.patch

Felipe, as in the previous iteration, would you be willing to provide a debdiff or a merge proposal?

Revision history for this message
Felipe Reyes (freyes) wrote : Re: [Bug 1972730] Re: [SRU] WARNING: crmadmin -S <HOST> unexpected output

On Mon, 2023-02-27 at 18:37 +0000, Athos Ribeiro wrote:
> This was fixed in crmsh 4.4.0-3, and not in 4.4.0-1.
>
> Lunar is fixed indeed, and jammy already carries the patch. We now need
> to patch kinetic by backporting d/0019-Fix-crmadmin-parsing.patch

Thanks great, appreciated.

>
> Felipe, as in the previous iteration, would you be willing to provide a
> debdiff or a merge proposal?
>

I will propose a debdiff ;-)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-hacluster (master)

Reviewed: https://review.opendev.org/c/openstack/charm-hacluster/+/874686
Committed: https://opendev.org/openstack/charm-hacluster/commit/0628e02983605313dd82b4501d54e9c027b669c7
Submitter: "Zuul (22348)"
Branch: master

commit 0628e02983605313dd82b4501d54e9c027b669c7
Author: Felipe Reyes <email address hidden>
Date: Tue Feb 21 14:59:31 2023 -0300

    Add kinetic support

    Summary of changes:
    - add kinetic to metadata.yaml
    - add 21.10 to run-on in charmcraft.yaml
    - add kinetic-zed testing bundle

    Func-Test-Pr: https://github.com/openstack-charmers/zaza-openstack-tests/pull/1014
    Related-Bug: #1972730
    Change-Id: I28c1f16bdbe2032e678f7c92caee5ddd3fcd4a7f

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-hacluster (stable/jammy)

Related fix proposed to branch: stable/jammy
Review: https://review.opendev.org/c/openstack/charm-hacluster/+/875769

Changed in crmsh (Ubuntu Kinetic):
assignee: nobody → Athos Ribeiro (athos-ribeiro)
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :
description: updated
description: updated
description: updated
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi Felipe,

I ended up uploading this one.

While asking for reviews on the patch being applied, Bryce added a few suggestions in https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/crmsh/+git/crmsh/+merge/440285/comments/1170258 which could help with this bug verification. One is related the test plan and the other to the "where problems could occur section".

Since this SRU was already accepted in jammy before, I am not sure if these changes are strictly needed for the SRU team, but they are valid and should help both verifiers (in case you are not available to verify this one) and SRU reviewers (for the where problems could occur section).

Would you be able to have a look on those comments?

Thanks!

Changed in crmsh (Ubuntu Kinetic):
status: New → In Progress
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Please test proposed package

Hello Felipe, or anyone else affected,

Accepted crmsh into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/crmsh/4.4.0-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in crmsh (Ubuntu Kinetic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-kinetic
removed: verification-done
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (crmsh/4.4.0-1ubuntu1.1)

All autopkgtests for the newly accepted crmsh (4.4.0-1ubuntu1.1) for kinetic have finished running.
The following regressions have been reported in tests triggered by the package:

booth/1.0-237-gdd88847-4ubuntu3 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/kinetic/update_excuses.html#crmsh

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

The booth/1.0-237-gdd88847-4ubuntu3 (s390x) autopkgtest failure reported above was due to test flakiness.

I re-triggered the tast, which resulted in a successful run.

Felipe, would you mind verifying that the fix in kinetic-proposed works for you?

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Removing server-todo tag and un-assigning. This is fixed in jammy and from lunar and on. Please, verify the proposed package fixes the issue in kinitic if you need the fix to land before it reaches EOSS.

tags: removed: server-todo
Changed in crmsh (Ubuntu Kinetic):
assignee: Athos Ribeiro (athos-ribeiro) → nobody
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

I verified this with the following steps, as per the test plan:

$ lxc launch ubuntu-daily:kinetic crmsh-kk-vm --vm --config limits.memory=16GB --device root,size=30GB
Withing the lxc VM:

# apt update
# systemctl stop apparmor
# snap install juju --classic
# wget https://launchpadlibrarian.net/659802005/test_plan.yaml # replace jammy for kinetic in there
# juju bootstrap
# juju deploy ./test_plan.yaml
# juju ssh keystone/leader

within that container:

$ sudo crm -w -F node maintenance $(hostname)

Throws the expected error.

When installing the package from proposed and re-running the command above (without leaving this container) we get the expected output.

Changed in crmsh (Ubuntu Kinetic):
assignee: nobody → Athos Ribeiro (athos-ribeiro)
tags: added: verification-done verification-done-kinetic
removed: verification-needed verification-needed-kinetic
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I verified the test results and am satisfied that they show the executed planned test case, and that the results are correct.

The package built correctly in all architectures and Ubuntu releases it was meant for.

There are no DEP8 regressions.

There is no SRU freeze ongoing at the moment.

There is no halted phasing a the previous update.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package crmsh - 4.4.0-1ubuntu1.1

---------------
crmsh (4.4.0-1ubuntu1.1) kinetic; urgency=medium

  * d/p/lp1972730.patch: Handle the output of 'crmadmin -S' correctly.
    (LP: #1972730)

 -- Athos Ribeiro <email address hidden> Mon, 03 Apr 2023 21:06:53 -0300

Changed in crmsh (Ubuntu Kinetic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.