exiqgrep -r and -f options match all messages if no

The original author of this comment is <email address hidden>.

If exiqgrep is invoked with -r or -f but without specifying a regular
expression - e.g. like
  exiqgrep -i -r | xargs exim -Mrm
all enqueued are deleted.

Help output states
  Selection criteria:
        -f <regexp> Match sender address sender (field is "< >" wrapped)
  ...
which indicates that <regexp> is a required criteria.

I presume the absence of <regexp> is treated as an empty regex, matching
everything - but I would consider this a bug, or at least unexpected behaviour.

Needless to say the fallout of discovering this was somewhat significant. User
error, yes, but not immediately obvious.

--- Bug imported by <email address hidden> 2021-10-20 14:53 UTC ---

This bug was previously known as _bug_ 2821 at https://bugs.exim.org/show_bug.cgi?id=2821

Unknown bug field "comment_sort_order" encountered while moving bug
   <comment_sort_order>oldest_to_newest</comment_sort_order>
Unknown platform unknown. Setting to default platform "".
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: <email address hidden>.
   Previous reporter was <email address hidden>.

Git commit: https://git.exim.org/exim.git/commitdiff/df618101a5ea15dc90c4a2968798ef2be9dba16f

commit df618101a5ea15dc90c4a2968798ef2be9dba16f
Author: Jeremy Harris <email address hidden>
AuthorDate: Mon Oct 18 11:01:47 2021 +0100
Commit: Jeremy Harris <email address hidden>
CommitDate: Mon Oct 18 11:01:47 2021 +0100

    Exiqgrep: check arg parsing. Bug 2821
---
 src/src/exiqgrep.src | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/src/exiqgrep.src b/src/src/exiqgrep.src
index c8762df..04602da 100644
--- a/src/src/exiqgrep.src
+++ b/src/src/exiqgrep.src
@@ -53,7 +53,7 @@ if ($ARGV[0] eq '--version') {
         exit 0;
 }

-getopts('hf:r:y:o:s:C:zxlibRcaG:',\%opt);
+if (!getopts('hf:r:y:o:s:C:zxlibRcaG:',\%opt) { &help; exit;}
 if ($ARGV[0]) { &help; exit;}
 if ($opt{h}) { &help; exit;}
 if ($opt{a}) { $eargs = '-bp'; }

Nobody commented

(In reply to Jeremy Harris from comment #4)
> Nobody commented

The applied patch introduces unbalanced parentheses.
syntax error at /usr/sbin/exiqgrep line 56, near ") {"
syntax error at /usr/sbin/exiqgrep line 56, near ";}"
syntax error at /usr/sbin/exiqgrep line 57, near ";}"
syntax error at /usr/sbin/exiqgrep line 58, near ";}"
Execution of /usr/sbin/exiqgrep aborted due to compilation errors.

cu Andreas

Oops. We had no regression-test case.

Git commit: https://git.exim.org/exim.git/commitdiff/42ed39da5af85552a35626348bb77e5576e18aa4

commit 42ed39da5af85552a35626348bb77e5576e18aa4
Author: Jeremy Harris <email address hidden>
AuthorDate: Sun Mar 6 14:25:13 2022 +0000
Commit: Jeremy Harris <email address hidden>
CommitDate: Sun Mar 6 16:45:03 2022 +0000

    utilities: fix exiqgrep perl syntax, add testcases. bug 2821

    broken-by: df618101a5
----
 doc/doc-docbook/spec.xfpt | 18 ++++++++++---
 src/src/exiqgrep.src | 9 ++++---
 test/README | 6 +++++
 test/runtest | 15 +++++++++--
 test/scripts/0000-Basic/0611 | 6 +++++
 test/stdout/0611 | 62 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 108 insertions(+), 8 deletions(-)

No further comments seen.