Consider dropping d/p/kpartx-Improve-finding-loopback-device-by-file.patch

Bug #1961633 reported by Athos Ribeiro
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
multipath-tools (Ubuntu)
Fix Released
Medium
Bryce Harrington

Bug Description

LP #1747044 added a patch (d/p/kpartx-Improve-finding-loopback-device-by-file.patch) to remove loop devices.

There was significant changes and discussions upstream regarding that issue at https://listman.redhat.com/archives/dm-devel/2018-February/msg00019.html, which resulted in https://github.com/opensvc/multipath-tools/commit/95c4189b683c543ac291628df8143a93373de17b being added to multipath-tools, as discussed in https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1747044/comments/6.

The changes introduced upstream are significantly different from the ones introduced by our delta due to reasons discussed in the mailing list thread linked above.

We should re-assess this delta and verify if it is still needed.

Tags: packaging

CVE References

Changed in multipath-tools (Ubuntu):
importance: Undecided → Medium
Changed in multipath-tools (Ubuntu):
status: New → Triaged
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

We should try to take a look at this delta during the KK cycle.

Bryce Harrington (bryce)
tags: added: packaging
Revision history for this message
Glenn Washburn (crass) wrote :

I suggest this patch be removed. With the first change in the patch the following is observed:

# kpartx -av file.img
add map loop36p1 (253:6): 0 204800 linear 7:2304 2048
add map loop36p2 (253:7): 0 66897920 linear 7:2304 206848
# kpartx -dv file.img
#

This is the undesirable behavior that this commit[1] was trying to fix, namely that kpartx doesn't do delete for relative paths. Yet its confusing for the user that its will add relative paths.

https://github.com/opensvc/multipath-tools/commit/9bdfa3eb8e24b668e6c2bb882cddb0ccfe23ed5b

Bryce Harrington (bryce)
Changed in multipath-tools (Ubuntu):
assignee: nobody → Bryce Harrington (bryce)
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (6.8 KiB)

This bug was fixed in the package multipath-tools - 0.9.4-5ubuntu1

---------------
multipath-tools (0.9.4-5ubuntu1) mantic; urgency=medium

  * Merge with Debian unstable (LP: #2018051). Remaining changes:
    - d/p/enable-find-multipaths.patch: re-enable find_multipaths by
      default -- see the removed 'add_find-multipaths.patch' (LP 1463046)
    - d/multipath.conf: Install friendly names multipath.conf by default,
      instead of generating it in every installer.
    - d/multipath-tools.dm-mpath-lvm.udev: Adjust initramfs integration
      for new udev rules
    - Remove d/initramfs/local-top (redundant with other initramfs scripts):
      + init-top: take over loading modules (dm-multipath and SCSI device
        handlers); move the missing dm-emc there (now scsi-dh-emc; see
        BTS 567014).
      + remove d/initramfs/local-top
    - d/initramfs/hooks: Add dm-queue-length: users may want to
      change from the default selector and should be able to do so.
      (LP 1673350)
    - multipath initramfs fixes for booting from multipathed devices:
      + d/initramfs/hooks: also copy wwids file on the installed
        system to ensure all paths come up on boot. (LP 1479929)
      + d/initramfs/hooks: install multipathd and required
        directories.
      + d/initramfs/hooks: copy multipath udev rules to initramfs
      + d/initramfs/hooks: do not copy kpartx rules to initramfs
      + d/initramfs/local-bottom: remember to stop multipathd.
      + d/initramfs/local-premount: wait for udev to settle before
        the call to resolve_device() in local_mount_root(), so the
        by-uuid/ symlinks have a chance to be updated by the
        multipath udev rules (LP 1503286).
      + d/initramfs/local-premount: Run multipath with -B so not to
        assign names nor change /etc/multipath/bindings during
        initramfs (LP 1561103)
    - debian/initramfs/local-bottom: wait for the multipathd unix
      socket to close, so to avoid multipathd.socket unit failure.
      (LP 1682178)
    - Split kpartx initramfs bits into kpartx-boot for dmraid (LP 941874)
      + d/kpartx-initramfs/hooks/kpartx
      + d/kpartx-boot.install
      + d/kpartx-boot.postinst
      + d/kpartx-boot.postrm
      + d/control: Add kpartx-boot package for dmraid
    - d/rules: Move udev rules to priority 95, because rules that load
      modules should be >90.
    - d/rules: remove -Bsymbolic-functions from LDFLAGS
      (https://github.com/opensvc/multipath-tools/issues/26)
    - Don't build the multipath-tools binary package on i386; only kpartx.
  * Dropped changes:
    - d/p/kpartx-Improve-finding-loopback-device-by-file.patch: Improve
      finding loopback devices (LP 1747044)
      [ Dropping due to LP: #1961633 ]
    - d/rules: copy udev rule after build.
      [ Included in debian version 0.9.4-5 ]
    - d/multipath-tools.install: install tmpfiles.d/multipath.conf
      [ Included in debian version 0.9.4-2 ]
    - SECURITY UPDATE: symlink attack CVE-2022-41973
      [ Applied upstream in 0.9.4 ]
    - SECURITY UPDATE: authorization bypass CVE-2022-41974
      [ Applied upstream in 0.9.4 ]
  * Added changes:
    - d/rules: do not install init scripts...

Read more...

Changed in multipath-tools (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.