[FFe] cl-plus-ssl does not support OpenSSL 3.0

Bug #1960615 reported by Simon Chopin
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cl-plus-ssl (Ubuntu)
Fix Released
Undecided
Athos Ribeiro
pgloader (Ubuntu)
Fix Released
Undecided
Athos Ribeiro

Bug Description

[Feature Freeze exception request]

This is an FFe request to sync cl-plus-ssl 20220328.git8b91648-3 from Debian.

The current cl-plus-ssl does not support OpenSSL 3.

The autopkgtest suite currently fails.

autopkgtest [16:51:08]: @@@@@@@@@@@@@@@@@@@@ summary
command1 FAIL non-zero exit status 1
command2 FAIL non-zero exit status 1
command3 FAIL non-zero exit status 1

The new upstream change set introduced in this new version includes several changes that add support for OpenSSL 3 to this package.
Upstream does not formally version this package, therefore, I am attaching a list of commits included in this new version of the package.

cl-plus-ssl has the following dependencies, which will likely not work properly when using SSL related features:

Reverse build dependencies
* pgloader
* cl-simple-date (recursive)
Reverse dependencies
* cl-drakma
* cl-hunchentoot
* cl-zs3 (recursive)

I built the proposed package in a PPA, available at: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/lp1960615-cl-plus-ssl-jammy-ffe/+packages

I also ran the autopkgtest suite locally. Here is the result summary:

autopkgtest [16:12:30]: @@@@@@@@@@@@@@@@@@@@ summary
command1 PASS
command2 PASS
command3 PASS

[Original message]

Title: pgloader autopkgtests fail for lack of OpenSSL 3.0 support

Currently the autopkgtests for pgloader fail because cl-plus-ssl doesn't support OpenSSL 3.0

Since pgloader was removed from the archive during the OpenSSL 3.0 transition, I suspect the only reason it re-migrated after the new version was synced was because there were some binaries that were still pulling in libssl1.1

Revision history for this message
Christoph Berg (myon) wrote :

This now also affects pgloader/jammy on apt.postgresql.org.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for making us aware Christoph that this was falling through the cracks.
Athos is trying to have a look today and summarize the current state here.

I'll then try to have a look at continuing that tomorrow and hopefully Simon (Mr. OpenSSL3) can help as well then.

TL;DR:
yes you could say they are in
 cl-plus-ssl | 20200609.gitff4634a-1build1 | jammy/universe | source, all
 pgloader | 3.6.3-1 | jammy/universe | source, amd64, arm64, armhf
But they are dysfunctional.

Hope:
- by now upstream might have new commits we want to add to cl-plus-ssl
- in the meantime many packages got fixed for openssl3, maybe there is something done in other PKGs that we can re-use here

Changed in cl-plus-ssl (Ubuntu):
assignee: nobody → Athos Ribeiro (athos-ribeiro)
tags: added: server-todo
Revision history for this message
Christoph Berg (myon) wrote :

It turned out that cl-plus-ssl upstream git has already OpenSSL 3 support, so all it took was to update it to 20220328.git8b91648. I've just uploaded that to Debian unstable.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

the autopkgtest tests for the new cl-plus-ssl version in unstable is failing in jammy.

src/reload.lisp fails to load the proper *.so files. When adding entries for the openssl 3 libraries, one test still fails: test/fingerprint.lisp calls EVP_MD_size, which has been renamed to EVP_MD_get_size.

I am preparing a patch to fix these issues and then this should be fine to land in jammy. We will need a FFe since we are pulling in a significant amount of changes from cl-plus-ssl upstream. We can use this bug for the FFe.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

I filed https://salsa.debian.org/common-lisp-team/cl-plus-ssl/-/merge_requests/2 to fix the failing tests. If there are no issues with the patch, I will also forward that upstream.

Revision history for this message
Christoph Berg (myon) wrote :

I uploaded your patch as -3 now. Thanks!

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Christoph :)

I also forwarded the patch upstream in https://github.com/cl-plus-ssl/cl-plus-ssl/pull/154

description: updated
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

The cl-plus-ssl issue seems to be fixed.

for pgloader, we are now hitting https://github.com/dimitri/pgloader/issues/153: i.e., when trying to load the first option for the openssl libraries in cl-plus-ssl, the debugger gets invoked (and the tests fail).

We can proceed with the cl-plus-ssl FFe though since the next fix should be in pgloader itself.

summary: - pgloader autopkgtests fail for lack of OpenSSL 3.0 support
+ [FFe] cl-plus-ssl does not support OpenSSL 3.0
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Filed upstream issue for pgloader at https://github.com/dimitri/pgloader/issues/1370

Revision history for this message
Stefano Rivera (stefanor) wrote :

FFe approved.

Changed in cl-plus-ssl (Ubuntu):
status: New → Confirmed
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

This bug was fixed in the package cl-plus-ssl - 20220328.git8b91648-3

---------------
cl-plus-ssl (20220328.git8b91648-3) unstable; urgency=medium

  * Team upload.
  * d/p/openssl3.patch: Improve support for OpenSSL 3.

 -- Athos Ribeiro <email address hidden> Fri, 01 Apr 2022 15:14:25 -0300

cl-plus-ssl (20220328.git8b91648-2) unstable; urgency=medium

  * Team upload.
  * Disable clisp autopkgtest on ppc64el, not reliable there.
    (Same change as in cl-asdf.)

 -- Christoph Berg <email address hidden> Fri, 01 Apr 2022 11:19:02 +0200

cl-plus-ssl (20220328.git8b91648-1) unstable; urgency=medium

  * Team upload.
  * New upstream version 20220328.git8b91648 with OpenSSL 3 support.

 -- Christoph Berg <email address hidden> Thu, 31 Mar 2022 17:06:56 +0200

Changed in cl-plus-ssl (Ubuntu):
status: Confirmed → Fix Released
status: Fix Released → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

Unclear to me why this was set to fix committed if it was already landed. Also the described rationale is a bugfix, not a feature.

Changed in cl-plus-ssl (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks for setting the status there. The package wasn't landed at that point AFAICT, so I set it to fix committed to wait for the migration to happen.

There are unrelated patches with actual features that were pulled in, as described in https://launchpadlibrarian.net/595168316/cl-plus-ssl.changelog (e.g, 34f56a6 adds not-after and not-before functionality), that's why I filed the FFe.

Changed in pgloader (Ubuntu):
assignee: nobody → Athos Ribeiro (athos-ribeiro)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pgloader - 3.6.3-1build1

---------------
pgloader (3.6.3-1build1) jammy; urgency=medium

  * No changes rebuild for cl-plus-ssl fixes (LP: #1960615).

 -- Athos Ribeiro <email address hidden> Mon, 11 Apr 2022 09:16:20 -0300

Changed in pgloader (Ubuntu):
status: New → Fix Released
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Filed LP: #1968594 to follow-up on the pgloader issue where it invokes the debugger when ldopen fails for the first shared object in cl+ssl list.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.