update-manager should not remove deb-packaged Firefox on flavors

Bug #1947501 reported by Norbert
30
This bug affects 5 people
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Confirmed
Undecided
Unassigned
Impish
Won't Fix
Undecided
Unassigned
update-manager (Ubuntu)
Fix Released
Undecided
Brian Murray
Impish
Fix Released
Undecided
Brian Murray

Bug Description

[Impact]
update-manager lists Firefox as a duplicate package to be removed for Ubuntu flavors which installed it by default.

[Test Case]
1. Install Ubuntu MATE 21.10 online or off-line (does not really matter)
2. Login to freshly installed system
3. Run `update-manager` manually

Expected results:
* update-manager founds some useful updates and install them

Actual results:
* update-manager founds some useful updates and will remove Firefox web-browser to replace it with Snap version
See screenshot and its OCR main part:

  Details of updates
    Install or remove
        Duplicate packages to be removed
            Firefox Web Browser

With the version of update-manager from -proposed Firefox will no longer be suggested for removal on a system without the ubuntu-desktop package installed.

[Where Problems Could Occur]
It's possible the Firefox deb will no longer be suggested for removal on systems with ubuntu-desktop installed. To test this scenario we can also install the ubuntu-desktop package on the Ubuntu MATE system from the original test and confirm that firefox is suggested for removal.

[Original Description]
Additional info:
* in /usr/share/ubuntu-release-upgrader/deb2snap.json you clearly state the dependency on ubuntu-desktop package (https://git.launchpad.net/ubuntu-release-upgrader/tree/DistUpgrade/deb2snap.json#n10 ), but flavours does not have such package installed, so it is a bug.

Workaround:
* mark Firefox as manually installed by `sudo apt-mark manual firefox` and then launch `update-manager` again.

Documented on:
* https://askubuntu.com/q/1369778
* https://ubuntu-mate.community/t/way-to-avoid-snap-version-of-firefox-and-continue-to-use-deb-package-on-freshly-installed-ubuntu-mate-21-10/24691

ProblemType: BugDistroRelease: Ubuntu 21.10
Package: update-manager 1:21.10.4
ProcVersionSignature: Ubuntu 5.13.0-19.19-generic 5.13.14
Uname: Linux 5.13.0-19-generic x86_64
ApportVersion: 2.20.11-0ubuntu70
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: MATE
Date: Sun Oct 17 16:34:57 2021
GsettingsChanges:
 b'com.ubuntu.update-manager' b'launch-count' b'1'
 b'com.ubuntu.update-manager' b'first-run' b'false'
 b'com.ubuntu.update-manager' b'launch-time' b'int64 1634477674'
InstallationDate: Installed on 2021-10-17 (0 days ago)
InstallationMedia: Ubuntu-MATE 21.10 "Impish Indri" - Release amd64 (20211012)
PackageArchitecture: allSourcePackage: update-manager
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Revision history for this message
Norbert (nrbrtx) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-release-upgrader (Ubuntu):
status: New → Confirmed
Changed in update-manager (Ubuntu):
status: New → Confirmed
Norbert (nrbrtx)
description: updated
Changed in update-manager (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Brian Murray (brian-murray)
Changed in update-manager (Ubuntu Impish):
status: New → In Progress
assignee: nobody → Brian Murray (brian-murray)
description: updated
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Norbert, or anyone else affected,

Accepted update-manager into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:21.10.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Impish):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Chris Guiver (guiverc) wrote (last edit ):

Tested on a Lubuntu impish (final) QA-test install.

`update-manager` installed (1:21.10.5 from proposed)
(along with all other files available via -proposed)

No snaps were installed

ran `sudo update-manager`

it reported I needed to reboot (fair enough) then exited

No snaps were installed.
Firefox is still installed as deb package :)

--
Lubuntu isn't impacted by this; but I'd added `update-manager` days ago [mentioned in the askubu link Norbert gave] and by running `update-manager`; the `firefox` *deb* was removed & a snap version installed.

This was on that same box which has a couple of ~identical installs; ie. QA-test of full disk install; followed by install alongside etc.. so this was a clean install before this test.

Results exactly as wanted; and different to same test ~2 days ago.

tags: added: verification-done-impish
removed: verification-needed-impish
Revision history for this message
Chris Guiver (guiverc) wrote :

I originally changed tag to verification-done, but have reversed this as it's likely best done (as listed on instructions) on an actual Ubuntu-MATE install.

tags: added: verification-needed-impish
removed: verification-done-impish
Revision history for this message
Chris Guiver (guiverc) wrote :

Installed Ubuntu-MATE impish (2021-10-12) on
- hp dc7700 (c2d-e6320, 5gb, nvidia quadro nvs 290)

(i added `vim`; sorry wasn't in any mood to use pluma, nano etc)

added -proposed then upgraded `update-manager` to 1:21.10.5

no snap for firefox installed; it's deb package

ran `update-manager` from terminal & let it perform any updates it wanted.

At conclusion; firefox is still a deb package; no snap of firefox is installed. Same result as with Lubuntu earlier.

tags: added: verification-done-impish
removed: verification-needed-impish
Revision history for this message
Norbert (nrbrtx) wrote :

Package from proposed fixes the issue. Thanks.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-release-upgrader (Ubuntu Impish):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:21.10.5

---------------
update-manager (1:21.10.5) impish; urgency=medium

  * UpdateManager/backend/__init__.py: When checking for snap seeds also
    take into consideration whether or not the metapackage associated with the
    snap is installed. (LP: #1947501)

 -- Brian Murray <email address hidden> Mon, 18 Oct 2021 12:26:38 -0700

Changed in update-manager (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for update-manager has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:22.04.2

---------------
update-manager (1:22.04.2) jammy; urgency=medium

  * UpdateManager/backend/__init__.py: define the cache before trying to use
    it.

 -- Brian Murray <email address hidden> Tue, 19 Oct 2021 07:25:02 -0700

Changed in update-manager (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

Ubuntu 21.10 (Impish Indri) has reached end of life, so this bug will not be fixed for that specific release.

Changed in ubuntu-release-upgrader (Ubuntu Impish):
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.