FTBFS with GCC-11

Bug #1946750 reported by Lukas Märdian
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glm (Ubuntu)
Fix Released
High
Unassigned
Impish
Won't Fix
High
Unassigned
Jammy
Fix Released
High
Unassigned

Bug Description

[Impact]

 * glm FTBFS using GCC 11, which makes it hard to apply any (security) updates in a timely manner.

[Test Plan]

 * Check the Launchpad build logs to make sure that glm
0.9.9.8+ds-1ubuntu1 built successfully
 * Attach build logs to this bug

[Where problems could occur]

 * The build could still fail for some reason and we would be back to status quo.

[Other Info]

 * This can be an impish 0-day SRU
 * PPA pre-testing has been done here: https://launchpad.net/~slyon/+archive/ubuntu/testing/+sourcepub/12783332/+listing-archive-extra

=== Original Bug Description ===

Unit-tests are failing if built using GCC-11.

```
99% tests passed, 2 tests failed out of 188

Total Test time (real) = 3.86 sec

The following tests FAILED:
  39 - test-core_func_integer (Child aborted)
  97 - test-ext_vector_integer (Child aborted)
```

test-ext_vector_integer seems to be flaky, while test-core_func_integer fails consistently.

If built with -Wall this warning shows up, which seems to be relevant:
cd /home/user/glm-gu/obj-x86_64-linux-gnu/test/core && /usr/bin/cmake -E cmake_link_script CMakeFiles/test-core_func_matrix.dir/link.txt --verbose=1
/usr/bin/c++ -g -O2 -ffile-prefix-map=/home/user/glm-gu=. -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wno-error -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-Bsymbolic-functions -flto=auto -Wl,-z,relro -rdynamic CMakeFiles/test-core_func_matrix.dir/core_func_matrix.cpp.o -o test-core_func_matrix
In function ‘bitCount::bitCount_bitfield<int>(int)int’,
    inlined from ‘bitCount::test()’ at /home/user/glm-gu/test/core/core_func_integer.cpp:1515:35,
    inlined from ‘main’ at /home/user/glm-gu/test/core/core_func_integer.cpp:1533:27:
/home/user/glm-gu/test/core/core_func_integer.cpp:1442:41: warning: ‘<anonymous>’ may be used uninitialized [-Wmaybe-uninitialized]
 1442 | return bitCount_bitfield(glm::vec<1, genType, glm::defaultp>(x)).x;
      | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/user/glm-gu/test/core/core_func_integer.cpp: In function ‘main’:
/home/user/glm-gu/test/core/core_func_integer.cpp:1427:36: note: by argument 1 of type ‘const struct vec &’ to ‘bitCount::bitCount_bitfield<1, int, (glm::qualifier)0>(glm::vec<1, int, (glm::qualifier)0> const&)glm::vec<1, int, (glm::qualifier)0>’ declared here
 1427 | static glm::vec<L, int, Q> bitCount_bitfield(glm::vec<L, T, Q> const& v)
      | ^~~~~~~~~~~~~~~~~
/home/user/glm-gu/test/core/core_func_integer.cpp:1442:47: note: ‘<anonymous>’ declared here
 1442 | return bitCount_bitfield(glm::vec<1, genType, glm::defaultp>(x)).x;
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/user/glm-gu/test/core/core_func_common.cpp: In function ‘int test_constexpr()’:
/home/user/glm-gu/test/core/core_func_common.cpp:1306:35: warning: variable ‘A’ set but not used [-Wunused-but-set-variable]
 1306 | constexpr glm::vec1 const A = glm::abs(glm::vec1(1.0f));
      | ^
/home/user/glm-gu/test/core/core_func_common.cpp:1307:35: warning: variable ‘B’ set but not used [-Wunused-but-set-variable]
 1307 | constexpr glm::vec2 const B = glm::abs(glm::vec2(1.0f));
      | ^
/home/user/glm-gu/test/core/core_func_common.cpp:1308:35: warning: variable ‘C’ set but not used [-Wunused-but-set-variable]
 1308 | constexpr glm::vec3 const C = glm::abs(glm::vec3(1.0f));
      | ^
/home/user/glm-gu/test/core/core_func_common.cpp:1309:35: warning: variable ‘D’ set but not used [-Wunused-but-set-variable]
 1309 | constexpr glm::vec4 const D = glm::abs(glm::vec4(1.0f));
      | ^

Lukas Märdian (slyon)
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Lukas, or anyone else affected,

Accepted glm into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/glm/0.9.9.8+ds-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: block-proposed-impish
Changed in glm (Ubuntu Impish):
status: New → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (glm/0.9.9.8+ds-1ubuntu1)

All autopkgtests for the newly accepted glm (0.9.9.8+ds-1ubuntu1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

asymptote/2.70+ds-2 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#glm

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote :

All autopkgtests for the newly accepted glm (0.9.9.8+ds-1ubuntu1) for impish have finished running.
The following regressions have been reported in tests triggered by the package:

asymptote/2.70+ds-2 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/impish/update_excuses.html#glm

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package glm - 0.9.9.8+ds-1ubuntu1

---------------
glm (0.9.9.8+ds-1ubuntu1) impish; urgency=medium

  * Add d/p/tests-no-optimization.patch, to fix FTBFS with GCC-11, LP: #1946750

 -- Lukas Märdian <email address hidden> Tue, 12 Oct 2021 14:52:57 +0200

Changed in glm (Ubuntu):
status: New → Fix Released
Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you Steve, for accepting glm into impish-proposed.

The reported autopkgtest regression on asymptote/2.70+ds-2 (armhf) was resolved by retry.

Also, the build in impish-proposed passed for version "0.9.9.8+ds-1ubuntu1": https://launchpad.net/ubuntu/+source/glm/0.9.9.8+ds-1ubuntu1/+build/22279829

So I'll be attaching the build log and marking it verification-done.

tags: added: verification-done-impish
removed: verification-needed-impish
Mathew Hodson (mhodson)
tags: removed: verification-needed
Changed in glm (Ubuntu Impish):
importance: Undecided → High
Changed in glm (Ubuntu Jammy):
importance: Undecided → High
Revision history for this message
Steve Langasek (vorlon) wrote :

impish has gone EOL without any further security updates to glm, therefore I am removing this package from -proposed and closing this bug wontfix as part of the EOL process.

Changed in glm (Ubuntu Impish):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.