Auto-Correct in LibreOffice does not work with 3.24.25-1ubuntu4

Bug #1925379 reported by David Burleigh
72
This bug affects 13 people
Affects Status Importance Assigned to Milestone
gtk+3.0 (Ubuntu)
Fix Released
High
Unassigned
Hirsute
Fix Released
High
Unassigned

Bug Description

* Impact

The auto-correction in libreoffice is not action as it should

* Test case

see comment 9

* Regression potential

The changes are in the input handling so check that standard input, keyboard layouts, compose and keybinding as worked as expected on different layout and language type, include ibus and chinese.

------------
I just did a fresh install of Ubuntu 21.04 (smooth as silk), but then discovered that Auto-Correct in LibreOffice does not work. Yesterday, when I was still running 20.04, Auto-Correct worked fine -- same LibreOffice version, same LibreOffice profile, same LibreOffice document, and no changes on my part to my LibreOffice settings since I installed Ubuntu 21.04.

Revision history for this message
sgage@tds.net (sgage) wrote :

Same thing here. This issue does not occur in Kubuntu 21.04, so perhaps it's something in the GTK stack? It doesn't seem to be a problem with LO per se. I even installed older versions, and they exhibited the same problem.

This exact same issue occurred in Fedora Workstation (Gnome) a month or so ago, and after a couple of weeks was fixed - not sure what package since it was an updated of nearly 100 packages.

Revision history for this message
ajgreeny (ajg-charlbury) wrote :

Same here with Xubuntu 21.04 which I am running as a VM in KVM/QEMU and have the same problem - almost.

If I type 1/2 it does not autocorrect to ½ unless I highlight it in the text then go to Tools -> Autocorrect -> Apply when the change occurs.
However, if I try to repeat that with a second typing of 1/2, highlight it, and again go through the Tools -> Autocorrect -> Apply, nothing happens.
Once and only once it happens, not automatically as it does in Xubuntu 20.04 with the same LO version 7.1.2.2.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in libreoffice (Ubuntu):
status: New → Confirmed
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

I can confirm this issue and it is caused by the current gtk+-3.0 package.

Running with gtk+-3.0 3.24.28+git fixes the issue locally for me.

summary: - Auto-Correct does not work since upgrade to Hirsute
+ Auto-Correct in LibreOffice does not work with 3.24.25-1ubuntu4
Changed in gtk+3.0 (Ubuntu):
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

One recent merge mentioning libreoffice is https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3239

Revision history for this message
Sebastien Bacher (seb128) wrote :

It's not happening on my hirsute installation, picking a random combinaison from the replacing list, __D is correctly replaced by Δ , how do you test exactly? One commention 1/2 but the default syntax seems to be 1//2 which is working

Changed in gtk+3.0 (Ubuntu):
importance: Undecided → Low
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@seb128 The auto-correct feature is suppose to be triggered on <space>. It still seems to work with <tab> which is not useful in most cases.

I am running the hirsute release iso with kvm, chose the French locale and started libreoffice writer. Entering __D<space> does not lead to the expected auto correct.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Merging gtk+3.0 3.24.28-1 from debian/experimental fixes the problem here.

Revision history for this message
Norbert (nrbrtx) wrote :

Ubuntu MATE 21.04 is affected by this bug 1926083 as follows:

```
Autocorrect is broken even on default English locale

Steps to reproduce:
1. Have Ubuntu 21.04 boot or installed
2. Launch LibreOffice Writer
3. Type `HEllo` or `:alien:`, press <Space>

Expected results:
* `HEllo` is transformed to `Hello` after pressing <Space>; `:alien:` is transformed to `👽` after pressing <Space>

Actual results:
* AutoCorrect does not work, reacts only on <Enter> (which is not real use-case), so AutoCorrect is broken. It is serious bug.
```

Please fix it.

tags: added: hirsute
Revision history for this message
Daniel Letzeisen (dtl131) wrote :

For those that are feeling adventurous, I've applied the changes that Sebastien mentioned in comment #5 to the existing version of gtk3 in the 21.04 repo. The result can be found in my PPA: https://launchpad.net/~dtl131/+archive/ubuntu/mediahacks2
I'm running Xubuntu 21.04 in a Virtualbox VM, which only works with LO's x11 plugin, so I was not able to test this myself.
Please let me know how it works. If not satisfied with results, you can always run:
sudo ppa-purge ppa:dtl131/mediahacks2

affects: gtk+3.0 (Ubuntu) → ubuntu
affects: ubuntu → gtk+3.0 (Ubuntu)
Revision history for this message
Norbert (nrbrtx) wrote :

@dtl131

I confirm, that packages from your PPA fix the issue.

Waiting for the fix to be distributed via official repositories.

Revision history for this message
sgage@tds.net (sgage) wrote :

The packages from the PPA fix the issue for me, as well.

Revision history for this message
Sebastien Bacher (seb128) wrote :

@Daniel, the one change didn't apply correctly when I tried, did you just fix the conflicts or did you cherry pick other changes?

Revision history for this message
Daniel Letzeisen (dtl131) wrote :

I also had trouble getting that merge request to apply cleanly, so I just copied the affected file (gtk/gtkimcontextsimple.c) at the point of the commit you linked to, and overwrote the copy in Ubuntu's package. It seems there were a few other changes between Ubuntu's version and that commit.

I'm not familiar with the code, so I have no idea if all of those changes are needed, what the regression potential is, etc.

Revision history for this message
Sebastien Bacher (seb128) wrote :

> I also had trouble getting that merge request to apply cleanly, so I just copied the affected file (gtk/gtkimcontextsimple.c) at the point of the commit you linked to

Ah, thanks, that's an useful detail because then you didn't confirm that the commit mentioned fixes the issue but rather than one of the changes between the version in Ubuntu and this git revision is fixing it (could be one of the previously applied changes)

Changed in gtk+3.0 (Ubuntu):
status: Confirmed → In Progress
importance: Low → High
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@seb128 I have cherry picked and backported all "imcontext" changes from 3.24.29.

This fixed the problem and a PPA build is available at https://launchpad.net/~ricotz/+archive/ubuntu/testing/+sourcepub/12401703/+listing-archive-extra

tags: added: patch
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, the fix is uploaded and waiting for SRU review now

Changed in gtk+3.0 (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Frederik Feichtmeier (frederik-feichtmeier) wrote :

The gtk3 packages from this ppa also fix this bug on 21.04 https://github.com/flutter/flutter/issues/76383, thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.24.25-1ubuntu6

---------------
gtk+3.0 (3.24.25-1ubuntu6) impish; urgency=medium

  * debian/patches/git_imcontext.patch:
    - cherry pick imcontext fixes until 3.24.29 (LP: #1925379)

 -- Rico Tzschichholz <email address hidden> Sat, 01 May 2021 10:01:31 +0200

Changed in gtk+3.0 (Ubuntu):
status: Fix Committed → Fix Released
no longer affects: libreoffice (Ubuntu)
Changed in gtk+3.0 (Ubuntu Hirsute):
status: New → In Progress
importance: Undecided → High
Revision history for this message
Brian Murray (brian-murray) wrote :

This bug report is missing SRU information as described here:

https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Additionally, the version number 3.24.25-1ubuntu5 isn't great as if there is another SRU of gtk+3.0 it'd be version 3.24.25-1ubuntu5.1 (because 3.24.25-1ubuntu6 is in Impish). Subsequently, I'm going to reject this and reupload it as 3.24-25-1ubuntu4.1.

Revision history for this message
sgage@tds.net (sgage) wrote :

Any idea when we might see it in the repository?

Revision history for this message
Sebastien Bacher (seb128) wrote :

@Brian, description updated, thanks for reuploading though as you mentioned the version used was fine and < to impish so it wouldn't have created issues going forward.

@sgage, it's being reviewed as indicated by the previous comment

description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello David, or anyone else affected,

Accepted gtk+3.0 into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtk+3.0/3.24.25-1ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gtk+3.0 (Ubuntu Hirsute):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-hirsute
Revision history for this message
David Burleigh (david-burleigh-y) wrote :

Sorry, but I reverted to 20.04, and am about to go back to Debian testing...

Revision history for this message
sgage@tds.net (sgage) wrote :

The updated gtk+3.0 packages are working for me. I am now running 2.24.25-1ubuntu4.1. I have encountered no issues, and the bug is resolved. Thank you!

Revision history for this message
sgage@tds.net (sgage) wrote :

That would be version 3.24.25-1ubuntu4.1, obviously.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (gtk+3.0/3.24.25-1ubuntu4.1)

All autopkgtests for the newly accepted gtk+3.0 (3.24.25-1ubuntu4.1) for hirsute have finished running.
The following regressions have been reported in tests triggered by the package:

software-properties/0.99.10 (ppc64el, arm64, armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/hirsute/update_excuses.html#gtk+3.0

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Sebastien Bacher (seb128) wrote :

The software-properties tests were successful after a retry

Revision history for this message
Sebastien Bacher (seb128) wrote :

settings as verification-done, thanks @sgage for testing!

tags: added: verification-done verification-done-hirsute
removed: verification-needed verification-needed-hirsute
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk+3.0 - 3.24.25-1ubuntu4.1

---------------
gtk+3.0 (3.24.25-1ubuntu4.1) hirsute; urgency=medium

  * debian/patches/git_imcontext.patch:
    - cherry pick imcontext fixes until 3.24.29 (LP: #1925379)

 -- Rico Tzschichholz <email address hidden> Sat, 01 May 2021 10:01:31 +0200

Changed in gtk+3.0 (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gtk+3.0 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.