samba-common-bin should call systemd-tmpfiles before testparm

Thanks for the bug report.

Based on your logs, this is the error that's happening:

Load smb config files from /etc/samba/smb.conf
Loaded services file OK.
ERROR: lock directory /run/samba does not exist

ERROR: pid directory /run/samba does not exist

Server role: ROLE_STANDALONE

dpkg: erro ao processar o pacote samba-common-bin (--configure):
 o subprocesso instalado, do pacote samba-common-bin, o script post-installation retornou erro do status de saída 1

This issue is known and has been reported to the Debian samba package as well:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975422

Although I wasn't able to reproduce it, the rationale described in the link above makes sense to me, and I can confirm that, on Focal, samba-common-bin.postinst is calling systemd-tmpfiles *after* calling testparm, which is what causes this issue.

Debian's fix is here:

https://salsa.debian.org/samba-team/samba/-/commit/0c3b2056764cd1a566766c3e1764d7c312eab5d7

I'm adding this bug to our TODO list, and marking it as Triaged.

Looking at the SRU for Groovy it doesn't seem that everything included in the changes is actually a part of the version of samba that we have in Impish. Is there a reason the test reinstall-samba-common-bin and the changes to debian/rules aren't included in Impish?

Hello Eduardo, or anyone else affected,

Accepted samba into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/samba/2:4.12.5+dfsg-3ubuntu4.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

hmm, I accepted the groovy upload but didn't notice comment #3 until too late.. I didn't process focal

Hi Brian,

The changes in debian/rules are not required in impish (nor hirsute) because they are using debhelper compat 13, where the #DEBHELPER# tag in the relevant postinst script will be properly expanded to make the necessary "systemd-tmpfiles" call (see [1] for further reference). Note that the change moving the #DEBHELPER# tag to the beginning of the postinst script is already present in impish and hirsute and this is why these series are not affected.

Finally, regarding the new reinstall-samba-common-bin test case, this is the actual reproducer for the bug here reported. Since it was submitted and accepted in Debian, and given that hirsute and impish are not affected by this bug, I thought that adding the test case to the impish/hirsute deltas would not be needed/wanted. Would this be considered as an SRU policy break since it is a test case only? If so, I'd be happy to propose changes to include these tests in impish and hirsute as well.

[1] https://launchpad.net/debian/+source/debhelper/12.10

Hello Eduardo, or anyone else affected,

Accepted samba into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/samba/2:4.11.6+dfsg-0ubuntu1.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Thanks for the clarification, I've gone ahead and accepted the package. It might be nice to add the test case to the version of the samba in Debian to ensure we don't encounter a regression but its not a blocker.

All autopkgtests for the newly accepted samba (2:4.11.6+dfsg-0ubuntu1.9) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

libsoup2.4/2.70.0-1 (amd64)
gvfs/1.44.1-1ubuntu1 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#samba

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Test results for groovy with samba 2:4.12.5+dfsg-3ubuntu4.4 available in -proposed:

# apt update && apt install -y samba-common && apt remove -y samba-common-bin
# reboot
# if test ! -d /run/samba; then echo 'OK: Proceed with testing'; else echo 'FAIL: do not proceed with testing'; fi
> OK: Proceed with testing
# apt install -y samba-common-bin
# if [ $? -eq 0 ]; then echo SUCCESS; else echo FAIL; fi
> SUCCESS

Test results for focal with samba 2:4.11.6+dfsg-0ubuntu1.9 available in -proposed:

# apt update && apt install -y samba-common && apt remove -y samba-common-bin
# reboot
# if test ! -d /run/samba; then echo 'OK: Proceed with testing'; else echo 'FAIL: do not proceed with testing'; fi
> OK: Proceed with testing
# apt install -y samba-common-bin
# if [ $? -eq 0 ]; then echo SUCCESS; else echo FAIL; fi
> SUCCESS

Which confirms the fix for both focal and groovy.

The verification of the Stable Release Update for samba has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package samba - 2:4.12.5+dfsg-3ubuntu4.4

---------------
samba (2:4.12.5+dfsg-3ubuntu4.4) groovy; urgency=medium

  * Fix samba-common-bin postinst errors (LP: #1905387)
    - d/rules: ensure systemd-tmpfiles runs for samba-common-bin postinst
      through dh_installsystemd
    - d/samba-common-bin.postinst: ensure systemd-tmpfiles is called before
      testparm
    - d/t/reinstall-samba-common-bin: make sure /run/samba is created by the
      samba-common-bin installation process (postinst script)
    - d/t/control: run new reinstall-samba-common-bin test case

 -- Athos Ribeiro <email address hidden> Thu, 27 May 2021 09:22:22 -0300

This bug was fixed in the package samba - 2:4.11.6+dfsg-0ubuntu1.9

---------------
samba (2:4.11.6+dfsg-0ubuntu1.9) focal; urgency=medium

  * Fix samba-common-bin postinst errors (LP: #1905387)
    - d/rules: ensure systemd-tmpfiles runs for samba-common-bin postinst
      through dh_installsystemd
    - d/samba-common-bin.postinst: ensure systemd-tmpfiles is called before
      testparm
    - d/t/reinstall-samba-common-bin: make sure /run/samba is created by the
      samba-common-bin installation process (postinst script)
    - d/t/control: run new reinstall-samba-common-bin test case

 -- Athos Ribeiro <email address hidden> Mon, 24 May 2021 16:45:27 -0300