Ubuntu
nginx package

libnginx-mod-nchan distributes old/incompatible module

Bug #1874831 reported by Damjan Georgievski on 2020-04-24

This bug affects 2 people

	Status	Importance	Assigned to
nginx (Ubuntu)	Fix Released	Medium	Unassigned
Focal	Incomplete	Medium	Unassigned
Groovy	Won't Fix	Medium	Unassigned

Bug Description

The libnginx-mod-nchan package which is built from the nginx source package distributes an old nchan module. The nginx source package has bundled nchan 1.0.8 which has known issues when running with nginx >= 1.13.10

The upstream issue documents that nginx has had some changes that break nchan < v1.2.0
https://github.com/slact/nchan/issues/460

Suggestion, update nchan to >= v1.2.0 (best v1.2.7).

this is the error I get when using the `nchan_publisher_upstream_request` directive:

2020/04/24 01:00:35 [error] 9#9: *6 nchan: unexpected publisher message request body buffer location. please report this to the nchan developers. while sending to client, client: 127.0.0.1, server: _, request: "POST /publish?topic=one HTTP/1.1", subrequest: "/authorize_pub", upstream: "http://127.0.0.1:5000/authorize_pub", host: "127.0.0.1"

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: libnginx-mod-nchan 1.17.10-0ubuntu1
Uname: Linux 5.6.6-arch1-1 x86_64
ApportVersion: 2.20.11-0ubuntu27
Architecture: amd64
CasperMD5CheckResult: skip
Date: Fri Apr 24 16:53:56 2020
ProcEnviron:
TERM=xterm
PATH=(custom, no user)
SourcePackage: nginx
UpgradeStatus: No upgrade log present (probably fresh install)

Tags:

Related branches

~paelzer/ubuntu/+source/nginx:lp-1874831-nchan-bump-lp-1893753-lua-FOCAL

On hold for merging into ubuntu/+source/nginx:ubuntu/focal-devel

Thomas Ward: Pending requested 2021-10-12

Canonical Server: Pending requested 2021-10-07

Canonical Server packageset reviewers: Pending requested 2021-10-07

git-ubuntu developers: Pending requested 2021-10-07

Diff: 70937 lines (+38657/-9478)

312 files modified

debian/changelog (+9/-0)
debian/modules/control (+2/-1)
debian/modules/http-lua/README.markdown (+271/-95)
debian/modules/http-lua/config (+45/-0)
debian/modules/http-lua/doc/HttpLuaModule.wiki (+256/-87)
debian/modules/http-lua/src/api/ngx_http_lua_api.h (+8/-1)
debian/modules/http-lua/src/ngx_http_lua_accessby.c (+3/-1)
debian/modules/http-lua/src/ngx_http_lua_api.c (+1/-1)
debian/modules/http-lua/src/ngx_http_lua_args.c (+8/-3)
debian/modules/http-lua/src/ngx_http_lua_balancer.c (+6/-1)
debian/modules/http-lua/src/ngx_http_lua_bodyfilterby.c (+23/-27)
debian/modules/http-lua/src/ngx_http_lua_bodyfilterby.h (+1/-1)
debian/modules/http-lua/src/ngx_http_lua_cache.c (+19/-4)
debian/modules/http-lua/src/ngx_http_lua_clfactory.c (+63/-22)
debian/modules/http-lua/src/ngx_http_lua_common.h (+52/-9)
debian/modules/http-lua/src/ngx_http_lua_consts.c (+3/-0)
debian/modules/http-lua/src/ngx_http_lua_contentby.c (+2/-0)
debian/modules/http-lua/src/ngx_http_lua_control.c (+4/-1)
debian/modules/http-lua/src/ngx_http_lua_coroutine.c (+17/-1)
debian/modules/http-lua/src/ngx_http_lua_directive.c (+45/-17)
debian/modules/http-lua/src/ngx_http_lua_exception.h (+3/-3)
debian/modules/http-lua/src/ngx_http_lua_headerfilterby.c (+2/-1)
debian/modules/http-lua/src/ngx_http_lua_headers.c (+72/-90)
debian/modules/http-lua/src/ngx_http_lua_headers_in.c (+9/-1)
debian/modules/http-lua/src/ngx_http_lua_headers_out.c (+15/-5)
debian/modules/http-lua/src/ngx_http_lua_headers_out.h (+3/-3)
debian/modules/http-lua/src/ngx_http_lua_initworkerby.c (+45/-3)
debian/modules/http-lua/src/ngx_http_lua_input_filters.c (+137/-0)
debian/modules/http-lua/src/ngx_http_lua_input_filters.h (+29/-0)
debian/modules/http-lua/src/ngx_http_lua_log.c (+23/-0)
debian/modules/http-lua/src/ngx_http_lua_logby.c (+2/-1)
debian/modules/http-lua/src/ngx_http_lua_misc.c (+27/-0)
debian/modules/http-lua/src/ngx_http_lua_module.c (+59/-0)
debian/modules/http-lua/src/ngx_http_lua_ndk.c (+41/-0)
debian/modules/http-lua/src/ngx_http_lua_phase.c (+18/-0)
debian/modules/http-lua/src/ngx_http_lua_pipe.c (+2475/-0)
debian/modules/http-lua/src/ngx_http_lua_pipe.h (+95/-0)
debian/modules/http-lua/src/ngx_http_lua_probe.h (+2/-1)
debian/modules/http-lua/src/ngx_http_lua_regex.c (+8/-4)
debian/modules/http-lua/src/ngx_http_lua_req_method.c (+4/-3)
debian/modules/http-lua/src/ngx_http_lua_rewriteby.c (+13/-3)
debian/modules/http-lua/src/ngx_http_lua_script.c (+2/-2)
debian/modules/http-lua/src/ngx_http_lua_setby.c (+15/-19)
debian/modules/http-lua/src/ngx_http_lua_setby.h (+1/-1)
debian/modules/http-lua/src/ngx_http_lua_shdict.c (+37/-26)
debian/modules/http-lua/src/ngx_http_lua_socket_tcp.c (+1311/-578)
debian/modules/http-lua/src/ngx_http_lua_socket_tcp.h (+26/-3)
debian/modules/http-lua/src/ngx_http_lua_socket_udp.c (+50/-6)
debian/modules/http-lua/src/ngx_http_lua_ssl_certby.c (+78/-13)
debian/modules/http-lua/src/ngx_http_lua_ssl_ocsp.c (+4/-0)
debian/modules/http-lua/src/ngx_http_lua_ssl_session_fetchby.c (+19/-4)
debian/modules/http-lua/src/ngx_http_lua_ssl_session_fetchby.h (+5/-1)
debian/modules/http-lua/src/ngx_http_lua_ssl_session_storeby.c (+19/-3)
debian/modules/http-lua/src/ngx_http_lua_string.c (+14/-0)
debian/modules/http-lua/src/ngx_http_lua_subrequest.c (+14/-0)
debian/modules/http-lua/src/ngx_http_lua_time.c (+71/-0)
debian/modules/http-lua/src/ngx_http_lua_timer.c (+39/-5)
debian/modules/http-lua/src/ngx_http_lua_uthread.c (+2/-1)
debian/modules/http-lua/src/ngx_http_lua_util.c (+163/-19)
debian/modules/http-lua/src/ngx_http_lua_util.h (+62/-12)
debian/modules/http-lua/src/ngx_http_lua_variable.c (+22/-13)
debian/modules/http-lua/src/ngx_http_lua_worker.c (+26/-0)
debian/modules/http-lua/t/.gitignore (+2/-0)
debian/modules/http-lua/t/000--init.t (+0/-5)
debian/modules/http-lua/t/001-set.t (+15/-8)
debian/modules/http-lua/t/002-content.t (+19/-19)
debian/modules/http-lua/t/004-require.t (+6/-6)
debian/modules/http-lua/t/005-exit.t (+1/-1)
debian/modules/http-lua/t/009-log.t (+9/-3)
debian/modules/http-lua/t/011-md5_bin.t (+1/-1)
debian/modules/http-lua/t/013-base64.t (+1/-1)
debian/modules/http-lua/t/014-bugs.t (+25/-24)
debian/modules/http-lua/t/016-resp-header.t (+541/-87)
debian/modules/http-lua/t/017-exec.t (+2/-2)
debian/modules/http-lua/t/020-subrequest.t (+72/-68)
debian/modules/http-lua/t/022-redirect.t (+52/-1)
debian/modules/http-lua/t/023-rewrite/client-abort.t (+3/-3)
debian/modules/http-lua/t/023-rewrite/exec.t (+2/-2)
debian/modules/http-lua/t/023-rewrite/mixed.t (+2/-2)
debian/modules/http-lua/t/023-rewrite/multi-capture.t (+1/-1)
debian/modules/http-lua/t/023-rewrite/redirect.t (+40/-0)
debian/modules/http-lua/t/023-rewrite/req-socket.t (+3/-3)
debian/modules/http-lua/t/023-rewrite/sanity.t (+14/-14)
debian/modules/http-lua/t/023-rewrite/socket-keepalive.t (+6/-6)
debian/modules/http-lua/t/023-rewrite/subrequest.t (+21/-21)
debian/modules/http-lua/t/023-rewrite/tcp-socket-timeout.t (+6/-6)
debian/modules/http-lua/t/023-rewrite/tcp-socket.t (+16/-16)
debian/modules/http-lua/t/023-rewrite/uthread-exec.t (+6/-6)
debian/modules/http-lua/t/023-rewrite/uthread-exit.t (+20/-20)
debian/modules/http-lua/t/023-rewrite/uthread-redirect.t (+2/-2)
debian/modules/http-lua/t/023-rewrite/uthread-spawn.t (+33/-29)
debian/modules/http-lua/t/024-access/client-abort.t (+3/-3)
debian/modules/http-lua/t/024-access/exec.t (+1/-1)
debian/modules/http-lua/t/024-access/mixed.t (+5/-5)
debian/modules/http-lua/t/024-access/multi-capture.t (+1/-1)
debian/modules/http-lua/t/024-access/sanity.t (+15/-15)
debian/modules/http-lua/t/024-access/subrequest.t (+21/-21)
debian/modules/http-lua/t/024-access/uthread-exec.t (+6/-6)
debian/modules/http-lua/t/024-access/uthread-exit.t (+19/-19)
debian/modules/http-lua/t/024-access/uthread-redirect.t (+2/-2)
debian/modules/http-lua/t/024-access/uthread-spawn.t (+33/-29)
debian/modules/http-lua/t/025-codecache.t (+153/-23)
debian/modules/http-lua/t/027-multi-capture.t (+2/-2)
debian/modules/http-lua/t/028-req-header.t (+460/-74)
debian/modules/http-lua/t/030-uri-args.t (+185/-37)
debian/modules/http-lua/t/031-post-args.t (+66/-16)
debian/modules/http-lua/t/034-match.t (+33/-32)
debian/modules/http-lua/t/035-gmatch.t (+11/-11)
debian/modules/http-lua/t/036-sub.t (+2/-2)
debian/modules/http-lua/t/037-gsub.t (+1/-1)
debian/modules/http-lua/t/038-match-o.t (+22/-22)
debian/modules/http-lua/t/041-header-filter.t (+15/-6)
debian/modules/http-lua/t/043-shdict.t (+2/-2)
debian/modules/http-lua/t/044-req-body.t (+7/-1)
debian/modules/http-lua/t/047-match-jit.t (+6/-6)
debian/modules/http-lua/t/048-match-dfa.t (+6/-6)
debian/modules/http-lua/t/055-subreq-vars.t (+9/-9)
debian/modules/http-lua/t/056-flush.t (+1/-1)
debian/modules/http-lua/t/057-flush-timeout.t (+1/-1)
debian/modules/http-lua/t/058-tcp-socket.t (+419/-26)
debian/modules/http-lua/t/062-count.t (+102/-7)
debian/modules/http-lua/t/063-abort.t (+31/-31)
debian/modules/http-lua/t/064-pcall.t (+7/-7)
debian/modules/http-lua/t/065-tcp-socket-timeout.t (+12/-12)
debian/modules/http-lua/t/066-socket-receiveuntil.t (+15/-15)
debian/modules/http-lua/t/067-req-socket.t (+3/-3)
debian/modules/http-lua/t/068-socket-keepalive.t (+1436/-31)
debian/modules/http-lua/t/073-backtrace.t (+7/-7)
debian/modules/http-lua/t/075-logby.t (+7/-4)
debian/modules/http-lua/t/081-bytecode.t (+24/-21)
debian/modules/http-lua/t/082-body-filter.t (+2/-1)
debian/modules/http-lua/t/084-inclusive-receiveuntil.t (+10/-10)
debian/modules/http-lua/t/087-udp-socket.t (+77/-7)
debian/modules/http-lua/t/090-log-socket-errors.t (+5/-5)
debian/modules/http-lua/t/091-coroutine.t (+42/-39)
debian/modules/http-lua/t/093-uthread-spawn.t (+35/-31)
debian/modules/http-lua/t/094-uthread-exit.t (+23/-23)
debian/modules/http-lua/t/095-uthread-exec.t (+7/-7)
debian/modules/http-lua/t/096-uthread-redirect.t (+3/-3)
debian/modules/http-lua/t/097-uthread-rewrite.t (+6/-6)
debian/modules/http-lua/t/098-uthread-wait.t (+37/-37)
debian/modules/http-lua/t/099-c-api.t (+5/-5)
debian/modules/http-lua/t/100-client-abort.t (+3/-3)
debian/modules/http-lua/t/104-req-raw-header.t (+112/-0)
debian/modules/http-lua/t/106-timer.t (+9/-9)
debian/modules/http-lua/t/108-timer-safe.t (+8/-8)
debian/modules/http-lua/t/109-timer-hup.t (+9/-9)
debian/modules/http-lua/t/120-re-find.t (+2/-2)
debian/modules/http-lua/t/123-lua-path.t (+5/-5)
debian/modules/http-lua/t/124-init-worker.t (+205/-6)
debian/modules/http-lua/t/126-shdict-frag.t (+2/-2)
debian/modules/http-lua/t/127-uthread-kill.t (+13/-13)
debian/modules/http-lua/t/128-duplex-tcp-socket.t (+3/-3)
debian/modules/http-lua/t/129-ssl-socket.t (+179/-262)
debian/modules/http-lua/t/130-internal-api.t (+4/-13)
debian/modules/http-lua/t/132-lua-blocks.t (+124/-1)
debian/modules/http-lua/t/134-worker-count-5.t (+2/-2)
debian/modules/http-lua/t/135-worker-id.t (+1/-61)
debian/modules/http-lua/t/138-balancer.t (+3/-5)
debian/modules/http-lua/t/139-ssl-cert-by.t (+205/-2)
debian/modules/http-lua/t/140-ssl-c-api.t (+12/-11)
debian/modules/http-lua/t/142-ssl-session-store.t (+11/-13)
debian/modules/http-lua/t/143-ssl-session-fetch.t (+118/-13)
debian/modules/http-lua/t/147-tcp-socket-timeouts.t (+4/-4)
debian/modules/http-lua/t/152-timer-every.t (+2/-2)
debian/modules/http-lua/t/153-semaphore-hup.t (+1/-1)
debian/modules/http-lua/t/155-tls13.t (+106/-0)
debian/modules/http-lua/t/156-slow-network.t (+138/-0)
debian/modules/http-lua/t/157-socket-keepalive-hup.t (+91/-0)
debian/modules/http-lua/t/158-global-var.t (+508/-0)
debian/modules/http-lua/t/159-sa-restart.t (+180/-0)
debian/modules/http-lua/t/160-disable-init-by-lua.t (+194/-0)
debian/modules/http-lua/t/161-load-resty-core.t (+68/-0)
debian/modules/http-lua/t/cert/dst-ca.crt (+63/-0)
debian/modules/http-lua/t/data/fake-shm-module/ngx_http_lua_fake_shm_module.c (+13/-9)
debian/modules/http-lua/util/build.sh (+3/-1)
debian/modules/http-lua/valgrind.suppress (+33/-16)
debian/modules/nchan/README.md (+897/-134)
debian/modules/nchan/changelog.txt (+205/-0)
debian/modules/nchan/cloc-exclude.txt (+10/-11)
debian/modules/nchan/config (+69/-18)
debian/modules/nchan/src/nchan_commands.rb (+351/-32)
debian/modules/nchan/src/nchan_config_commands.c (+275/-9)
debian/modules/nchan/src/nchan_defs.c (+8/-1)
debian/modules/nchan/src/nchan_defs.h (+9/-2)
debian/modules/nchan/src/nchan_module.c (+277/-143)
debian/modules/nchan/src/nchan_module.h (+13/-21)
debian/modules/nchan/src/nchan_setup.c (+672/-33)
debian/modules/nchan/src/nchan_types.h (+157/-40)
debian/modules/nchan/src/nchan_variables.c (+6/-0)
debian/modules/nchan/src/nchan_version.h (+1/-0)
debian/modules/nchan/src/store/memory/groups.c (+570/-0)
debian/modules/nchan/src/store/memory/groups.h (+55/-0)
debian/modules/nchan/src/store/memory/ipc-handlers.c (+526/-171)
debian/modules/nchan/src/store/memory/ipc-handlers.h (+13/-3)
debian/modules/nchan/src/store/memory/ipc.c (+27/-3)
debian/modules/nchan/src/store/memory/ipc.h (+10/-1)
debian/modules/nchan/src/store/memory/memstore.c (+1013/-460)
debian/modules/nchan/src/store/memory/store-private.h (+34/-7)
debian/modules/nchan/src/store/memory/store.h (+3/-3)
debian/modules/nchan/src/store/redis/cmp.c (+927/-410)
debian/modules/nchan/src/store/redis/cmp.h (+59/-7)
debian/modules/nchan/src/store/redis/hiredis/.gitignore (+7/-0)
debian/modules/nchan/src/store/redis/hiredis/.travis.yml (+24/-0)
debian/modules/nchan/src/store/redis/hiredis/CHANGELOG.md (+110/-0)
debian/modules/nchan/src/store/redis/hiredis/COPYING (+29/-0)
debian/modules/nchan/src/store/redis/hiredis/Makefile (+217/-0)
debian/modules/nchan/src/store/redis/hiredis/README.md (+392/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/ae.h (+127/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/libev.h (+147/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/libevent.h (+108/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/libuv.h (+121/-0)
debian/modules/nchan/src/store/redis/hiredis/async.c (+687/-0)
debian/modules/nchan/src/store/redis/hiredis/async.h (+129/-0)
debian/modules/nchan/src/store/redis/hiredis/dict.c (+338/-0)
debian/modules/nchan/src/store/redis/hiredis/dict.h (+126/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-ae.c (+62/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-libev.c (+52/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-libevent.c (+53/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-libuv.c (+53/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example.c (+78/-0)
debian/modules/nchan/src/store/redis/hiredis/fmacros.h (+21/-0)
debian/modules/nchan/src/store/redis/hiredis/hiredis.c (+1021/-0)
debian/modules/nchan/src/store/redis/hiredis/hiredis.h (+226/-0)
debian/modules/nchan/src/store/redis/hiredis/net.c (+461/-0)
debian/modules/nchan/src/store/redis/hiredis/net.h (+53/-0)
debian/modules/nchan/src/store/redis/hiredis/read.c (+525/-0)
debian/modules/nchan/src/store/redis/hiredis/read.h (+116/-0)
debian/modules/nchan/src/store/redis/hiredis/sds.c (+1095/-0)
debian/modules/nchan/src/store/redis/hiredis/sds.h (+105/-0)
debian/modules/nchan/src/store/redis/hiredis/test.c (+807/-0)
debian/modules/nchan/src/store/redis/hiredis/win32.h (+42/-0)
debian/modules/nchan/src/store/redis/rdsstore.c (+923/-1208)
debian/modules/nchan/src/store/redis/redis-lua-scripts/.gitignore (+1/-0)
debian/modules/nchan/src/store/redis/redis-lua-scripts/add_fakesub.lua (+9/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/channel_keepalive.lua (+5/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/delete.lua (+33/-23)
debian/modules/nchan/src/store/redis/redis-lua-scripts/find_channel.lua (+33/-19)
debian/modules/nchan/src/store/redis/redis-lua-scripts/get_message.lua (+16/-17)
debian/modules/nchan/src/store/redis/redis-lua-scripts/get_message_from_key.lua (+3/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/publish.lua (+64/-55)
debian/modules/nchan/src/store/redis/redis-lua-scripts/publish_status.lua (+4/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/rsck.lua (+27/-10)
debian/modules/nchan/src/store/redis/redis-lua-scripts/subscriber_register.lua (+18/-6)
debian/modules/nchan/src/store/redis/redis-lua-scripts/subscriber_unregister.lua (+3/-3)
debian/modules/nchan/src/store/redis/redis-lua-scripts/testscripts.rb (+4/-3)
debian/modules/nchan/src/store/redis/redis_lua_commands.c (+1036/-0)
debian/modules/nchan/src/store/redis/redis_lua_commands.h (+17/-984)
debian/modules/nchan/src/store/redis/redis_nginx_adapter.c (+28/-36)
debian/modules/nchan/src/store/redis/redis_nginx_adapter.h (+6/-1)
debian/modules/nchan/src/store/redis/redis_nodeset.c (+2179/-0)
debian/modules/nchan/src/store/redis/redis_nodeset.h (+276/-0)
debian/modules/nchan/src/store/redis/redis_nodeset_parser.c (+241/-0)
debian/modules/nchan/src/store/redis/redis_nodeset_parser.h (+40/-0)
debian/modules/nchan/src/store/redis/store-private.h (+53/-139)
debian/modules/nchan/src/store/redis/store.h (+8/-3)
debian/modules/nchan/src/store/spool.c (+168/-122)
debian/modules/nchan/src/store/spool.h (+6/-8)
debian/modules/nchan/src/subscribers/benchmark.c (+72/-0)
debian/modules/nchan/src/subscribers/benchmark.h (+3/-0)
debian/modules/nchan/src/subscribers/common.c (+162/-411)
debian/modules/nchan/src/subscribers/common.h (+7/-10)
debian/modules/nchan/src/subscribers/eventsource.c (+87/-7)
debian/modules/nchan/src/subscribers/getmsg_proxy.c (+106/-0)
debian/modules/nchan/src/subscribers/getmsg_proxy.h (+1/-0)
debian/modules/nchan/src/subscribers/http-chunked.c (+6/-4)
debian/modules/nchan/src/subscribers/http-multipart-mixed.c (+15/-12)
debian/modules/nchan/src/subscribers/http-raw-stream.c (+9/-7)
debian/modules/nchan/src/subscribers/internal.c (+13/-6)
debian/modules/nchan/src/subscribers/longpoll-private.h (+3/-1)
debian/modules/nchan/src/subscribers/longpoll.c (+97/-143)
debian/modules/nchan/src/subscribers/memstore_ipc.c (+43/-20)
debian/modules/nchan/src/subscribers/memstore_ipc.h (+3/-0)
debian/modules/nchan/src/subscribers/memstore_multi.c (+23/-30)
debian/modules/nchan/src/subscribers/memstore_redis.c (+67/-63)
debian/modules/nchan/src/subscribers/memstore_redis.h (+0/-1)
debian/modules/nchan/src/subscribers/websocket.c (+912/-486)
debian/modules/nchan/src/subscribers/websocket.h (+2/-1)
debian/modules/nchan/src/uthash.h (+747/-489)
debian/modules/nchan/src/util/hdr_histogram.c (+1015/-0)
debian/modules/nchan/src/util/hdr_histogram.h (+427/-0)
debian/modules/nchan/src/util/nchan_benchmark.c (+804/-0)
debian/modules/nchan/src/util/nchan_benchmark.h (+91/-0)
debian/modules/nchan/src/util/nchan_bufchainpool.c (+96/-0)
debian/modules/nchan/src/util/nchan_bufchainpool.h (+17/-0)
debian/modules/nchan/src/util/nchan_channel_id.c (+74/-8)
debian/modules/nchan/src/util/nchan_channel_id.h (+4/-1)
debian/modules/nchan/src/util/nchan_debug.c (+81/-0)
debian/modules/nchan/src/util/nchan_debug.h (+13/-0)
debian/modules/nchan/src/util/nchan_fake_request.c (+267/-24)
debian/modules/nchan/src/util/nchan_fake_request.h (+55/-3)
debian/modules/nchan/src/util/nchan_list.c (+26/-0)
debian/modules/nchan/src/util/nchan_list.h (+5/-0)
debian/modules/nchan/src/util/nchan_msg.c (+291/-33)
debian/modules/nchan/src/util/nchan_msg.h (+19/-0)
debian/modules/nchan/src/util/nchan_output.c (+73/-22)
debian/modules/nchan/src/util/nchan_output.h (+4/-2)
debian/modules/nchan/src/util/nchan_output_info.c (+271/-0)
debian/modules/nchan/src/util/nchan_output_info.h (+3/-4)
debian/modules/nchan/src/util/nchan_rbtree.h (+3/-3)
debian/modules/nchan/src/util/nchan_slist.c (+164/-0)
debian/modules/nchan/src/util/nchan_slist.h (+41/-0)
debian/modules/nchan/src/util/nchan_subrequest.c (+66/-9)
debian/modules/nchan/src/util/nchan_subrequest.h (+4/-1)
debian/modules/nchan/src/util/nchan_util.c (+866/-47)
debian/modules/nchan/src/util/nchan_util.h (+47/-3)
debian/modules/nchan/src/util/ngx_nchan_hacked_slab.c (+4/-0)
debian/modules/nchan/src/util/shmem.c (+44/-5)
debian/modules/nchan/src/util/shmem.h (+5/-0)
debian/modules/patches/http-lua/disable-load_resty_core.patch (+20/-0)
debian/modules/patches/http-lua/series (+1/-1)
dev/null (+0/-838)

~paelzer/ubuntu/+source/nginx:lp-1874831-nchan-bump-FOCAL

Rejected for merging into ubuntu/+source/nginx:ubuntu/focal-devel

Canonical Server: Pending requested 2021-10-07

Canonical Server packageset reviewers: Pending requested 2021-10-07

git-ubuntu developers: Pending requested 2021-10-07

Diff: 42023 lines (+25985/-6146)

134 files modified

debian/changelog (+7/-0)
debian/modules/nchan/README.md (+897/-134)
debian/modules/nchan/changelog.txt (+205/-0)
debian/modules/nchan/cloc-exclude.txt (+10/-11)
debian/modules/nchan/config (+69/-18)
debian/modules/nchan/src/nchan_commands.rb (+351/-32)
debian/modules/nchan/src/nchan_config_commands.c (+275/-9)
debian/modules/nchan/src/nchan_defs.c (+8/-1)
debian/modules/nchan/src/nchan_defs.h (+9/-2)
debian/modules/nchan/src/nchan_module.c (+277/-143)
debian/modules/nchan/src/nchan_module.h (+13/-21)
debian/modules/nchan/src/nchan_setup.c (+672/-33)
debian/modules/nchan/src/nchan_types.h (+157/-40)
debian/modules/nchan/src/nchan_variables.c (+6/-0)
debian/modules/nchan/src/nchan_version.h (+1/-0)
debian/modules/nchan/src/store/memory/groups.c (+570/-0)
debian/modules/nchan/src/store/memory/groups.h (+55/-0)
debian/modules/nchan/src/store/memory/ipc-handlers.c (+526/-171)
debian/modules/nchan/src/store/memory/ipc-handlers.h (+13/-3)
debian/modules/nchan/src/store/memory/ipc.c (+27/-3)
debian/modules/nchan/src/store/memory/ipc.h (+10/-1)
debian/modules/nchan/src/store/memory/memstore.c (+1013/-460)
debian/modules/nchan/src/store/memory/store-private.h (+34/-7)
debian/modules/nchan/src/store/memory/store.h (+3/-3)
debian/modules/nchan/src/store/redis/cmp.c (+927/-410)
debian/modules/nchan/src/store/redis/cmp.h (+59/-7)
debian/modules/nchan/src/store/redis/hiredis/.gitignore (+7/-0)
debian/modules/nchan/src/store/redis/hiredis/.travis.yml (+24/-0)
debian/modules/nchan/src/store/redis/hiredis/CHANGELOG.md (+110/-0)
debian/modules/nchan/src/store/redis/hiredis/COPYING (+29/-0)
debian/modules/nchan/src/store/redis/hiredis/Makefile (+217/-0)
debian/modules/nchan/src/store/redis/hiredis/README.md (+392/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/ae.h (+127/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/libev.h (+147/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/libevent.h (+108/-0)
debian/modules/nchan/src/store/redis/hiredis/adapters/libuv.h (+121/-0)
debian/modules/nchan/src/store/redis/hiredis/async.c (+687/-0)
debian/modules/nchan/src/store/redis/hiredis/async.h (+129/-0)
debian/modules/nchan/src/store/redis/hiredis/dict.c (+338/-0)
debian/modules/nchan/src/store/redis/hiredis/dict.h (+126/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-ae.c (+62/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-libev.c (+52/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-libevent.c (+53/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example-libuv.c (+53/-0)
debian/modules/nchan/src/store/redis/hiredis/examples/example.c (+78/-0)
debian/modules/nchan/src/store/redis/hiredis/fmacros.h (+21/-0)
debian/modules/nchan/src/store/redis/hiredis/hiredis.c (+1021/-0)
debian/modules/nchan/src/store/redis/hiredis/hiredis.h (+226/-0)
debian/modules/nchan/src/store/redis/hiredis/net.c (+461/-0)
debian/modules/nchan/src/store/redis/hiredis/net.h (+53/-0)
debian/modules/nchan/src/store/redis/hiredis/read.c (+525/-0)
debian/modules/nchan/src/store/redis/hiredis/read.h (+116/-0)
debian/modules/nchan/src/store/redis/hiredis/sds.c (+1095/-0)
debian/modules/nchan/src/store/redis/hiredis/sds.h (+105/-0)
debian/modules/nchan/src/store/redis/hiredis/test.c (+807/-0)
debian/modules/nchan/src/store/redis/hiredis/win32.h (+42/-0)
debian/modules/nchan/src/store/redis/rdsstore.c (+923/-1208)
debian/modules/nchan/src/store/redis/redis-lua-scripts/.gitignore (+1/-0)
debian/modules/nchan/src/store/redis/redis-lua-scripts/add_fakesub.lua (+9/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/channel_keepalive.lua (+5/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/delete.lua (+33/-23)
debian/modules/nchan/src/store/redis/redis-lua-scripts/find_channel.lua (+33/-19)
debian/modules/nchan/src/store/redis/redis-lua-scripts/get_message.lua (+16/-17)
debian/modules/nchan/src/store/redis/redis-lua-scripts/get_message_from_key.lua (+3/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/publish.lua (+64/-55)
debian/modules/nchan/src/store/redis/redis-lua-scripts/publish_status.lua (+4/-4)
debian/modules/nchan/src/store/redis/redis-lua-scripts/rsck.lua (+27/-10)
debian/modules/nchan/src/store/redis/redis-lua-scripts/subscriber_register.lua (+18/-6)
debian/modules/nchan/src/store/redis/redis-lua-scripts/subscriber_unregister.lua (+3/-3)
debian/modules/nchan/src/store/redis/redis-lua-scripts/testscripts.rb (+4/-3)
debian/modules/nchan/src/store/redis/redis_lua_commands.c (+1036/-0)
debian/modules/nchan/src/store/redis/redis_lua_commands.h (+17/-984)
debian/modules/nchan/src/store/redis/redis_nginx_adapter.c (+28/-36)
debian/modules/nchan/src/store/redis/redis_nginx_adapter.h (+6/-1)
debian/modules/nchan/src/store/redis/redis_nodeset.c (+2179/-0)
debian/modules/nchan/src/store/redis/redis_nodeset.h (+276/-0)
debian/modules/nchan/src/store/redis/redis_nodeset_parser.c (+241/-0)
debian/modules/nchan/src/store/redis/redis_nodeset_parser.h (+40/-0)
debian/modules/nchan/src/store/redis/store-private.h (+53/-139)
debian/modules/nchan/src/store/redis/store.h (+8/-3)
debian/modules/nchan/src/store/spool.c (+168/-122)
debian/modules/nchan/src/store/spool.h (+6/-8)
debian/modules/nchan/src/subscribers/benchmark.c (+72/-0)
debian/modules/nchan/src/subscribers/benchmark.h (+3/-0)
debian/modules/nchan/src/subscribers/common.c (+162/-411)
debian/modules/nchan/src/subscribers/common.h (+7/-10)
debian/modules/nchan/src/subscribers/eventsource.c (+87/-7)
debian/modules/nchan/src/subscribers/getmsg_proxy.c (+106/-0)
debian/modules/nchan/src/subscribers/getmsg_proxy.h (+1/-0)
debian/modules/nchan/src/subscribers/http-chunked.c (+6/-4)
debian/modules/nchan/src/subscribers/http-multipart-mixed.c (+15/-12)
debian/modules/nchan/src/subscribers/http-raw-stream.c (+9/-7)
debian/modules/nchan/src/subscribers/internal.c (+13/-6)
debian/modules/nchan/src/subscribers/longpoll-private.h (+3/-1)
debian/modules/nchan/src/subscribers/longpoll.c (+97/-143)
debian/modules/nchan/src/subscribers/memstore_ipc.c (+43/-20)
debian/modules/nchan/src/subscribers/memstore_ipc.h (+3/-0)
debian/modules/nchan/src/subscribers/memstore_multi.c (+23/-30)
debian/modules/nchan/src/subscribers/memstore_redis.c (+67/-63)
debian/modules/nchan/src/subscribers/memstore_redis.h (+0/-1)
debian/modules/nchan/src/subscribers/websocket.c (+912/-486)
debian/modules/nchan/src/subscribers/websocket.h (+2/-1)
debian/modules/nchan/src/uthash.h (+747/-489)
debian/modules/nchan/src/util/hdr_histogram.c (+1015/-0)
debian/modules/nchan/src/util/hdr_histogram.h (+427/-0)
debian/modules/nchan/src/util/nchan_benchmark.c (+804/-0)
debian/modules/nchan/src/util/nchan_benchmark.h (+91/-0)
debian/modules/nchan/src/util/nchan_bufchainpool.c (+96/-0)
debian/modules/nchan/src/util/nchan_bufchainpool.h (+17/-0)
debian/modules/nchan/src/util/nchan_channel_id.c (+74/-8)
debian/modules/nchan/src/util/nchan_channel_id.h (+4/-1)
debian/modules/nchan/src/util/nchan_debug.c (+81/-0)
debian/modules/nchan/src/util/nchan_debug.h (+13/-0)
debian/modules/nchan/src/util/nchan_fake_request.c (+267/-24)
debian/modules/nchan/src/util/nchan_fake_request.h (+55/-3)
debian/modules/nchan/src/util/nchan_list.c (+26/-0)
debian/modules/nchan/src/util/nchan_list.h (+5/-0)
debian/modules/nchan/src/util/nchan_msg.c (+291/-33)
debian/modules/nchan/src/util/nchan_msg.h (+19/-0)
debian/modules/nchan/src/util/nchan_output.c (+73/-22)
debian/modules/nchan/src/util/nchan_output.h (+4/-2)
debian/modules/nchan/src/util/nchan_output_info.c (+271/-0)
debian/modules/nchan/src/util/nchan_output_info.h (+3/-4)
debian/modules/nchan/src/util/nchan_rbtree.h (+3/-3)
debian/modules/nchan/src/util/nchan_slist.c (+164/-0)
debian/modules/nchan/src/util/nchan_slist.h (+41/-0)
debian/modules/nchan/src/util/nchan_subrequest.c (+66/-9)
debian/modules/nchan/src/util/nchan_subrequest.h (+4/-1)
debian/modules/nchan/src/util/nchan_util.c (+866/-47)
debian/modules/nchan/src/util/nchan_util.h (+47/-3)
debian/modules/nchan/src/util/ngx_nchan_hacked_slab.c (+4/-0)
debian/modules/nchan/src/util/shmem.c (+44/-5)
debian/modules/nchan/src/util/shmem.h (+5/-0)
dev/null (+0/-128)

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2020-04-24:

Dependencies.txt Edit (455 bytes, text/plain; charset="utf-8")
ProcCpuinfoMinimal.txt Edit (1.4 KiB, text/plain; charset="utf-8")

Rafael David Tinoco (rafaeldtinoco) on 2020-04-28

Changed in nginx (Ubuntu):
status:	New → Triaged

Revision history for this message

Rafael David Tinoco (rafaeldtinoco) wrote on 2020-04-28:

Thanks for reporting this...

I have opened an issue upstream (Debian):

https://salsa.debian.org/nginx-team/nginx/-/issues/2

Let's see what maintainers say and then we check how to move further.

Changed in nginx (Ubuntu):
importance:	Undecided → Medium

Rafael David Tinoco (rafaeldtinoco) on 2020-04-28

Changed in nginx (Ubuntu Focal):
status:	New → Triaged
importance:	Undecided → Medium

Revision history for this message

Thomas Ward (teward) wrote on 2020-04-28:

We are sufficiently diverged... I would have to evaluate any module changes in terms of features for an SRU but I can queue an updated module in the packaging for Ubuntu as well.

Revision history for this message

Rafael David Tinoco (rafaeldtinoco) wrote on 2020-04-30:

Thanks a lot for checking this @teward! Your call, I'd say only if you think its worth the time (versus benefit). Up to you! This will be in server's team queue until its incomplete/closed. Cheers!

Revision history for this message

Thomas Ward (teward) wrote on 2020-04-30:

rafaeldtinoco: I've added this to my queue for Groovy, which means I just have more package changes to implement heh.

Groovy set to In Progress for now as i'm already working on that packaging.

Changed in nginx (Ubuntu Groovy):
assignee:	nobody → Thomas Ward (teward)
status:	Triaged → In Progress

Revision history for this message

Thomas Ward (teward) wrote on 2020-05-11:

Hello.

There is a SUBSTANTIAL delta between the way things're packaged wrt nchan. As such, I've had to make minor alterations to the nchan source (removal of some binary files). AN updated nginx for Groovy has been uploaded to a PPA - https://launchpad.net/~teward/+archive/ubuntu/nginx-test - and soon a Focal upload will land there.

**Please test to make sure nchan works with these changes as intended.** If it does not, then this will need additional effort to make fully functional.

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2020-05-13:

I guess the Focal packages didn't appear yet? I'll try to test with the groovy package on top of Focal docker.

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2020-05-13:

I've tested my scenario and it works fine.

Just for completeness, tested on ubuntu focal 20.04 (amd64) docker image +
libnginx-mod-nchan 1.18.0-0ubuntu2 amd64
nginx-light 1.18.0-0ubuntu2 amd64

nchan is version 1.2.7

rhe configuration snippet used is:

location /publish {
  nchan_publisher;
  nchan_channel_id $arg_topic;
  nchan_publisher_upstream_request /authorize_pub;
}

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2020-07-03:

I see that ubuntu focal (focal-updates) got an libnginx-mod-nchan (1.18.0-0ubuntu1) package, but that one is still based on nchan 1.0.8 which crashes on publish.

Revision history for this message

Thomas Ward (teward) wrote on 2020-07-03:

#10

I had to wait for this merge to be complete before I could consider moving forward.

Given that the issues filed on the Salsa page may not be present, I will contact the Debian maintainer directly and see if they're aware of this issue. If they can fix it in Debian and make it available, we can just merge from Debian and get the fix.

Changed in nginx (Ubuntu Groovy):
status:	In Progress → Triaged

Revision history for this message

Thomas Ward (teward) wrote on 2020-07-03:

#11

Filed as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964203 in Debian

Revision history for this message

Thomas Ward (teward) wrote on 2020-07-06:

#12

This was *supposedly* fixed in 1.18.0-1 in Debian - how this didn't make it into the merge I have no idea.

Changed in nginx (Ubuntu Groovy):
status:	Triaged → In Progress

Revision history for this message

Bryce Harrington (bryce) wrote on 2020-07-07:

#13

Hi Thomas, could you elaborate? Is there some delta we should apply for the ubuntu package?

Revision history for this message

Thomas Ward (teward) wrote on 2020-07-07:

#14

I was digging and in Groovy the version works fine.

The issue will be Focal, we'll have to SRU the fix for that module only.

Thomas Ward (teward) on 2021-03-10

Changed in nginx (Ubuntu):
assignee:	Thomas Ward (teward) → nobody
Changed in nginx (Ubuntu Groovy):
assignee:	Thomas Ward (teward) → nobody
status:	In Progress → Triaged
Changed in nginx (Ubuntu):
status:	In Progress → Triaged

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-07-28:

#15

The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release

Changed in nginx (Ubuntu Groovy):
status:	Triaged → Won't Fix

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-10-07:

#16

Hi - while trying to clear old forgotten bugs it seems the SRU of this was missed in the past.

TL;DR: the new nginx is incompatible with the integrated nchan <=1.2.0
This fixes it and is in new releases
https://salsa.debian.org/nginx-team/nginx/-/commit/b575cfe355931e42fb61febe58d06076a8b10725

But the same should be tried to go to Focal.

This also did not yet add that.

I must admit - I might not know what I'm doing here, but the patch applies fine and would bump the nchan module to a compatible version.
And the patching/building seems easy enough so let me try.

PPA:
https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4678/+packages

MP:
https://code.launchpad.net/~paelzer/ubuntu/+source/nginx/+git/nginx/+merge/409828

@Damjan - I know it has been a while, but could you give this Focal-PPA a check if it would resolve the issue please? Also for an SRU we will need "steps to reproduce" if you could outline them for an nginx-newbie like me that would be helpful. I assume it is "install nginx + enable nchan module" or is there more to it?

Now if that would have any negative implications or SRU considerations I'm not sure.
Could it have happened that nchan in some config worked and now changes behavior (breaking SRU) or is it juts "module didn't work in Focal ever, so no one can be affected?
Teward can you answer that?

tags:	added: server-todo
Changed in nginx (Ubuntu Focal):
assignee:	nobody → Christian Ehrhardt  (paelzer)
Changed in nginx (Ubuntu):
status:	Triaged → Fix Released

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-10-07:

#17

I found a rather similar case (bug 1893753) which changes things slightly.
The PPA stays the same, but the MP now is at:
https://code.launchpad.net/~paelzer/ubuntu/+source/nginx/+git/nginx/+merge/409830

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-10-08:

#18

FYI - things were not as easy and build fails block the PPA for now.
I'll let you know once I found some time to resolve that.

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-10-13:

#19

Build fixed (as all about lua, nchan was fine). Could affected people with real use-cases please give the build in the PPA [1] a try and report if it works for them?

[1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4678

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-11-11:

#20

Hi,
there was no feedback yet, did anyone have a chance to try this build and outline steps to test this as needed for the SRU process [1]?

I tried the following (probably too trivial) and it worked just fine even without the fix.

$ apt install libnginx-mod-http-lua nginx-core
For nchan add in /etc/nginx/sites-enabled/default
    location = /sub {
      nchan_subscriber;
      nchan_channel_id $arg_id;
    }

    location = /pub {
      nchan_publisher;
      nchan_channel_id $arg_id;
    }
# Restart server
$ sudo systemctl restart nginx
# Access nchan content
$ curl --request POST --data "test message" http://127.0.0.1:80/pub
queued messages: 1
last requested: 0 sec. ago
active subscribers: 0
last message id: 1636616299

Maybe you can help me to extend that example to show the issue?

P.S. there is activity at the sibling bug 1893753. If we only get confirmation and proper tests steps there, but not here - then I'll have to drop this part of the upload before queuing for an SRU to Focal. So your help would really be appreciated.

[1]: https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Changed in nginx (Ubuntu Focal):
status:	Triaged → Incomplete

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2021-11-11:

#21

Tested with the packages from https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4678
and it works for me

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-11-11:

#22

Thanks Damjan that is great news, any chance to enlight me how to test it myself so that I could summarize that for the SRU Template as test steps?

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2021-11-11:

#23

In my original test, the POST to the /pub would crash the request in nginx - not crash the whole process but it would error out, and the curl would get disconnected with no data received.

Just now, before testing your PPA packages, using latest focal packages, the POST to /pub succeeded, but then a GET request to /sub crashed nginx:

nginx: worker process: /build/nginx-KTLRnK/nginx-1.18.0/debian/modules/nchan/src/store/memory/ipc-handlers.c:417: memstore_ipc_send_get_message: Assertion `data.shm_chid->len>1' failed.
2021/11/11 12:12:15 [alert] 915#915: worker process 916 exited on signal 6 (core dumped)

In general, a POST to /pub and a GET on /sub should succeed and return the same message.

I have a full demo with Docker and simple html app here (based on bullseye, since that worked at the time):
https://github.com/gdamjan/pub-sub-demo

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-11-12:

#24

That simple post+sub also works fine unfortunately:

root@f:~# curl --request POST --data "test message" http://127.0.0.1:80/pub
queued messages: 2
last requested: 6 sec. ago
active subscribers: 0
last message id: 16367017

root@f:~# curl --request GET http://127.0.0.1:80/sub
test message

Using your linked examples (thanks) I got

curl -i --header "Content-Type: application/json" --data '{"message":"test 1"}' http://localhost:80/pub?topic=one
HTTP/1.1 202 Accepted
Server: nginx/1.18.0 (Ubuntu)
Date: Fri, 12 Nov 2021 07:25:06 GMT
Content-Type: text/plain
Content-Length: 101
Connection: keep-alive

queued messages: 3
last requested: 97 sec. ago
active subscribers: 0
last message id: 1636701906:0

root@f:~# curl -i --header 'Accept: text/event-stream' --header "Content-Type: application/json" --get --data-urlencode 'payload={"topics":["one","two"]}' http://localhost:80/sub
HTTP/1.1 200 OK
Server: nginx/1.18.0 (Ubuntu)
Date: Fri, 12 Nov 2021 07:26:09 GMT
Content-Type: text/event-stream; charset=utf-8
Connection: keep-alive

: hi

id: 1636701724:0
data: test message

id: 1636701787:0
data: test message2

id: 1636701906:0
data: {"message":"test 1"}

id: 1636701939:0
data: {"message":"test 2"}

This latter one even works to stay active and further messages posted later arrive here.

Still no sign of the reported breakage.
So it must be part of the setup/config that is done I guess ...

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-11-12:

#25

I tried to use more of your docker config, but but either worked without a crash or didn't work (but because of the proxy/flask upstream_app being incompletely set up).
Is there a way to trigger this without the app, or do we really need to deploy it (or something similar) to recreate this.

BTW - since you are active (thanks) and have a reproducible way on your side at least and we can "explain" it with your container setup we can try to drive the SRU even with that if we fail to isolate better steps.

But I'd with we get something similar for lua in bug 1893753 ...

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2021-11-12:

#26

sorry, just went to my first message, the issue is when also using the nchan_publisher_upstream_request directive (to authorize the publish request).

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-11-15:

#27

I was able to recreate the error now.
I managed to trigger that by subscribing after a server restart with no message posted:

$ sudo systemctl restart nginx
$ sudo tail -f /var/log/nginx/error.log
# wait here then in another console
$ curl -i --header 'Accept: text/event-stream' --header "Content-Type: application/json" --get --data-urlencode 'payload={"topics":["one","two"]}' http://localhost:8000/subscribe
# The error log will spit out:
ker process: /build/nginx-KTLRnK/nginx-1.18.0/debian/modules/nchan/src/store/memory/ipc-handlers.c:417: memstore_ipc_send_get_message: Assertion `data.shm_chid->len>1' failed.
2021/11/15 11:09:07 [alert] 5340#5340: worker process 5344 exited on signal 6 (core dumped)

And that is indeed fixed by the PPA.

But BTW if you point nchan_publisher_upstream_request to an invalid target, then even with the fix it does fail the same way. And actually with the new version I had a hard time to get it right. I have found cases which formerly worked (basic nchan config post-pub + get+sub) which now after the fix is installed trigger a crash like this. This is kind of the very definition of what the SRU policy tries to prevent :-/

The argument for "allowing" the full version bump of this embedded module was that without this it isn't usable at all (therefore we can't regress anyone). But as we've seen it seems there are (basic?) configurations which were fine before, therefore I'm not entirely sure we can really push this as an SRU :-/

@teward @racb - would you mind to have a look and comment what you think about it?

Revision history for this message

Robie Basak (racb) wrote on 2021-11-15:

#28

I think Christian's feeling is right.

SRU policy is to cherry-pick specific fixes. Normally we'd expect a bug report to have identified a root cause in the code, and we'd be patching that root cause to fix the problem.

Identifying that one version works and one version does not, and therefore we should swap the version in a stable release, doesn't comply with this requirement and isn't normally acceptable because there usually exist users not affected by the bug who might find that behaviour for them changes, contrary to their expectations of a stable release. It's also incomplete to just identify version differences like this: there is always going to be a root cause in the code, so it should always be possible to turn this case into the first case above and therefore to find a way to update the package with which we can be more confident doesn't disrupt existing unaffected users.

Exceptionally, if we can be certain that there aren't any existing unaffected users, then we can bump the version safely. Or if it's not practical to do the above step, we might decide that the "least worst" solution is to take that risk. But then I'd expect the case to be made that there are no existing unaffected users and therefore there can be no disruption by the version bump. Or an explanation of why it is not practical to turn this into the first case and risking regression to existing users is "least worst".

Christian said:

> But as we've seen it seems there are (basic?) configurations which were fine before, therefore I'm not entirely sure we can really push this as an SRU :-/

That does sound to me like a cherry-pick is required here, unless a case is made for the exceptions I outlined above.

Revision history for this message

Christian Ehrhardt  (paelzer) wrote on 2021-11-15:

#29

Thanks for confirming my bad feeling here Robie :-/

I might not know enough of real nchan/nginx usage, if we can make it clear that the old version in focal really is useless for any real case then we can SRU the new version.

Otherwise we'd really need to find the individual fix to pick it onto what we have in Focal.

@Damjan - can you help to differ between the above two cases?

Revision history for this message

Damjan Georgievski (gdamjan) wrote on 2021-11-15:

#30

What is SRU?

Revision history for this message

Robie Basak (racb) wrote on 2021-11-15:

#31

Sorry Damjan, I should have explained that. SRU is a Stable Release Update - the policy and process we use in Ubuntu to update packages in stable releases. https://wiki.ubuntu.com/StableReleaseUpdates has full details.

Christian Ehrhardt  (paelzer) on 2021-11-17

tags:	removed: server-todo
Changed in nginx (Ubuntu Focal):
assignee:	Christian Ehrhardt  (paelzer) → nobody

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

debbugs #964203
[done serious] Edit
auto-salsa.debian.org-nginx-team-nginx-- #2
[closed] Edit

Bug watches keep track of this bug in other bug trackers.

Ubuntunginx package

libnginx-mod-nchan distributes old/incompatible module

Bug Description

Related branches

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
nginx package