Ubuntu
php-imagick package

tests ignore RC and have 15 fails left

Bug #1864961 reported by Christian Ehrhardt 
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
php-imagick (Ubuntu)
Fix Released
Low
Bryce Harrington

Bug Description

Was ok to get things in Focal, but should get a deep dive until we know the root cause.

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped : 0
Exts tested : 15
---------------------------------------------------------------------

Number of tests : 276 270
Tests skipped : 6 ( 2.2%) --------
Tests warned : 2 ( 0.7%) ( 0.7%)
Tests failed : 17 ( 6.2%) ( 6.3%)
Tests passed : 251 ( 90.9%) ( 93.0%)
---------------------------------------------------------------------
Time taken : 75 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Test Imagick, annotateImage [tests/034_Imagick_annotateImage_basic.phpt]
Test ImagickDraw, composite [tests/177_ImagickDraw_composite_basic.phpt]
Test ImagickDraw, setFontSize [tests/206_ImagickDraw_setFontSize_basic.phpt]
Test ImagickDraw, setFontFamily [tests/207_ImagickDraw_setFontFamily_basic.phpt]
Test ImagickDraw, setFontStretch [tests/208_ImagickDraw_setFontStretch_basic.phpt]
Test ImagickDraw, setFontWeight [tests/209_ImagickDraw_setFontWeight_basic.phpt]
Test ImagickDraw, setFontStyle [tests/210_ImagickDraw_setFontStyle_basic.phpt]
Test ImagickDraw, setGravity [tests/212_ImagickDraw_setGravity_basic.phpt]
Test ImagickDraw, setTextAlignment [tests/222_ImagickDraw_setTextAlignment_basic.phpt]
Test ImagickDraw, setTextAntialias [tests/223_ImagickDraw_setTextAntialias_basic.phpt]
Test ImagickDraw, setTextUnderColor [tests/224_ImagickDraw_setTextUnderColor_basic.phpt]
Test ImagickDraw, setTextDecoration [tests/225_ImagickDraw_setTextDecoration_basic.phpt]
Test Tutorial, psychedelicFont [tests/241_Tutorial_psychedelicFont_basic.phpt]
Test Tutorial, psychedelicFontGif [tests/244_Tutorial_psychedelicFontGif_basic.phpt]
Test ImagickDraw, getTextDirection [tests/264_ImagickDraw_getTextDirection_basic.phpt]
Test ImagickDraw, getFontResolution [tests/266_ImagickDraw_getFontResolution_basic.phpt]
Test ImagickDraw:: setTextInterlineSpacing [tests/279_ImagickDraw_setTextInterlineSpacing.phpt]
=====================================================================

=====================================================================
WARNED TEST SUMMARY
---------------------------------------------------------------------
Test ImagickDraw, getDensity [tests/268_ImagickDraw_getDensity_basic.phpt] (warn: XFAIL section but test passes)
ImagickPixel iterator [tests/bug_73840.phpt] (warn: XFAIL section but test passes)
=====================================================================

P.S. Assigned to bryce who pushed that for php 7.4

See original description
Tags: server-next
Christian Ehrhardt  (paelzer)
description: updated
Changed in php-imagick (Ubuntu):
status: New → Confirmed
importance: Undecided → High
tags: added: server-next
Bryce Harrington (bryce)
Changed in php-imagick (Ubuntu):
assignee: nobody → Bryce Harrington (bryce)
Bryce Harrington (bryce)
summary: - tests ignore RC and hav 15 fails left
+ tests ignore RC and have 15 fails left
Revision history for this message
Bryce Harrington (bryce) wrote :

Looking at the upstream git history for just test case 034, I see they added some changes to address CI issues. Namely, to include functions.inc and set a font properly during test setup. These are fixes for test breakage, rather than fixes for actual software defects.

I didn't look at the other test cases, but I'd hazard to bet they're all failing for similar reasons - testcase refactoring and fixups. If that holds true generally, then I'm doubtful this is going to be viable SRU material, but may be worth patching up for hirsute. Perhaps a 3.4.5 release will manifest itself - that'd probably be the simplest way to gain the test fixes.

Bryce Harrington (bryce)
Changed in php-imagick (Ubuntu):
importance: High → Low
Revision history for this message
Bryce Harrington (bryce) wrote :

Debian is now shipping two sets of code in php-imagick, one for PHP 7.x and earlier and one for PHP 8.0 and newer.

Current results on impish (with the former codebase, i.e. PHP 7.4):

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped : 0
Exts tested : 15
---------------------------------------------------------------------

Number of tests : 276 252
Tests skipped : 24 ( 8.7%) --------
Tests warned : 2 ( 0.7%) ( 0.8%)
Tests failed : 0 ( 0.0%) ( 0.0%)
Tests passed : 250 ( 90.6%) ( 99.2%)
---------------------------------------------------------------------
Time taken : 37 seconds
=====================================================================

With the newer (PHP 8.0-enabled) codebase the original test skips appear to be resolved, however there are now some test failures. These are due to minor text changes of assertion messages, e.g.:
8) /tmp/autopkgtest.Y9KiYn/build.1Fn/src/imagick-3.4.4/tests/180_ImagickDraw_matte_basic.phpt
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
-Deprecated: Function ImagickDraw::matte() is deprecated in %s
+Deprecated: Method ImagickDraw::matte() is deprecated in Standard input code on line 17

These will need to get fixed up to make php-imagick transition, however the original problem this bug report was filed about seems to now be long in the past, so I think we can close this as resolved.

Changed in php-imagick (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.