Ubuntu
gnome-shell-extension-appindicator package

Size is not right with hidpi (both 2x and 1x with font scaling)

Bug #1832793 reported by Carlos Pita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell-extension-appindicator (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

I've tried this in two different hidpi monitors with different scaling configurations:

1) A 1920x1080 screen with scale factor 1x and font scale factor 1.25.

2) A 3000x2000 screen with scale factor 2x.

In the first one, icons are too small, I have to change:

   this._iconBox = new AppIndicator.IconActor(indicator, Panel.PANEL_ICON_SIZE + 6);

to

   this._iconBox = new AppIndicator.IconActor(indicator, Panel.PANEL_ICON_SIZE + 12);

OTOH, icons are a little too big in the second setting and I have to do:

   this._iconBox = new AppIndicator.IconActor(indicator, Panel.PANEL_ICON_SIZE + 2);

Icons directly managed by gnome shell are not sized according to PANEL_ICON_SIZE, see:

   https://gitlab.gnome.org/GNOME/gnome-shell/blob/master/js/ui/panelMenu.js

Short of a smarter way of computing icons size, you could provide a setting to adjust it so that the user could fine tune it if necessary without hacking the code.

See original description
Carlos Pita (carlosjosepita)
summary: - Size is not right with hidpi (both 2x and fractional scaling)
+ Size is not right with hidpi (both 2x and 1x with font scaling)
description: updated
Revision history for this message
Carlos Pita (carlosjosepita) wrote :

I've reported this in github also: https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/181. I'm not sure which is the better place since upstream = distro here.

Daniel van Vugt (vanvugt)
tags: added: fixed-upstream focal
Changed in gnome-shell-extension-appindicator (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-appindicator - 33-1

---------------
gnome-shell-extension-appindicator (33-1) experimental; urgency=medium

  * Team upload.

  [ Marco Trevisan (Treviño) ]
  * New upstream version:
    - Completely refactored the icons handling, to use the same look and
      behavior of the default gnome-shell indicators and properly handle
      HiDPI cases.
    - appIndicator: Always use Gio.Icon as model and St.Icon ui (LP: #1723827,
      LP: #1817073, LP: #1832793, LP: #1825623)
    - appIndicator: Don't try to reload multiple times a pending icon
    - appIndicator: Lookup theme icons using scale factor
    - testTool: Add test to show a changing label
    - indicatorStatusIcon: Use Clutter actor alignment on 3.35+ versions
      (LP: #1866042)
    - appIndicator: Add a cancellable to stop the proxy on destruction
    - Util: Cancel previous properties refresh requests on new one
    - util: Don't emit signal changed if a property contents is equal
    - Util: add message structured logging as well
    - Util: Cleanup syntax of refreshPropertyOnProxy
    - appIndicator: Use simpler implementation for argbToRgba
    - appIndicator: Use warning level for not found icons

  [ Fini Jastrow ]
  * appIndicator: Fix runtime error when icon can not be loaded

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 12 Mar 2020 22:36:05 +0100

Changed in gnome-shell-extension-appindicator (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.