ubuntu-release-upgrader-core shows upgrading from 18.10 to 18.10

The attachments may be reporting wrong versions. It appeared to be impossible to report the bug from the machine where I was performing the update, so I had to turn to another one.

To be clear, this was when upgrading from cosmic to disco.

I tried recreating this by upgrading an Ubuntu 18.10 system to Ubuntu 19.04 and the dialog I received, in English, indicated that it was in fact upgrading to Ubuntu 19.04. Subsequently I suspect this is a translations issue.

You are probably right. In that case:
- the EN version does not state FROM which version
- the NL version first line "Upgrading Ubuntu 18.10 to version 18.10" is not translated and should be "Opwaarderen Ubuntu 18.10 naar versie 19.04"

I suppose that Kubuntu uses qt, and it looks like the DistUpgrade/window_main.ui file was not updated in this upload:

https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:19.04.1

So I don't think it's a translation issue.

However, I wonder from where the first occurrence of "18.10" in Ferry's screenshot comes from...

$ grep Upgrading window_main.ui
      <string>&lt;b&gt;&lt;big&gt;Upgrading Ubuntu to version 18.10&lt;/big&gt;&lt;/b&gt;</string>

@Brian: Updating window_main.ui ought to fix this, right?

FYI: There's a screenshot (in English, so not a translation issue) at https://bugs.launchpad.net/bugs/1825733

Sorry - that should have said that the screenshot is in: https://bugs.launchpad.net/bugs/1827669

On 2019-05-05 14:16, Gordon Lack wrote:
> FYI: There's a screenshot (in English, so not a translation issue)

Right, and that's also Kubuntu, i.e. qt. => window_main.ui

@Gunnar "However, I wonder from where the first occurrence of "18.10" in Ferry's screenshot comes from..." definitely not from window_main.ui then. Maybe is overwritten by translation text?

It's not the first occurrence of "18.10" that's the issue; it's the second, which should have been 19.04.

On 2019-05-05 22:27, Ferry Toth wrote:
> @Gunnar "However, I wonder from where the first occurrence of "18.10"
> in Ferry's screenshot comes from..." definitely not from
> window_main.ui then.

Well, that's a fair point. I still submitted patches about changing that very file in order to move the issue forward.

> Maybe is overwritten by translation text?

I don't see how that would happen. To be honest I don't see how that string - when correct in the original source - would ever show up translated. When you upgrade from e.g. 18.10 to 19.04, you are still on 18.10 when that string shows up, and at that point I suppose that the language packs for 18.10 are still in effect.

So the original string ought to read:

"Upgrading Ubuntu to version 19.04"

while the string in mutter.mo is:

"Upgrading Ubuntu to version 18.10"

Maybe I'm missing something.

s/mutter.mo/ubuntu-release-upgrader.mo/

*don't overestimate your multitasking ability*

This bug was fixed in the package ubuntu-release-upgrader - 1:19.10.4

---------------
ubuntu-release-upgrader (1:19.10.4) eoan; urgency=medium

  [ Gunnar Hjalmarsson ]
  * DistUpgrade/window_main.ui: Really update for 19.10 (LP: #1825733).

 -- Brian Murray <email address hidden> Thu, 09 May 2019 11:06:05 -0700

After the fix of window_main.ui in eoan I installed Kubuntu 19.04, started an upgrade using the command:

kubuntu-devel-release-upgrade

and got the expected string "Upgrading Ubuntu 19.04 to version 19.10". (Apparently a string substitution takes place to insert the "19.04" part.)

There are also translation aspects to this string which deserve attention, but that will be tracked in bug #1727472. We can consider it confirmed that simply editing window_main.ui fixes this bug.

Brian let me know that disco will be uploaded only when a pending disco SRU has been completed, so it will take a while.

I've uploaded this to the Disco queue and is waiting for review and the current SRU to be verified / age.

Hello Ferry, or anyone else affected,

Accepted ubuntu-release-upgrader into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-release-upgrader/1:19.04.16.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Verified the test case; resulting string:

"Upgrading Ubuntu 18.10 to version 19.04"

This bug was fixed in the package ubuntu-release-upgrader - 1:19.04.16.5

---------------
ubuntu-release-upgrader (1:19.04.16.5) disco; urgency=medium

  [ Gunnar Hjalmarsson ]
  * DistUpgrade/window_main.ui: Really update for 19.04 (LP: #1825733).

  [ Brian Murray ]
  * DistUpgrade/DistUpgradeViewNonInteractive.py: when responding to a
    conffile prompt with "n" use bytes not a string. (LP: #1796193)

 -- Brian Murray <email address hidden> Fri, 10 May 2019 15:19:00 -0700

The verification of the Stable Release Update for ubuntu-release-upgrader has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.