GNOME Shell crash when an asset is not found (due to too many logs spawn by appindicator extension)

Bug #1817073 reported by Didier Roche-Tolomelli
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
gnome-shell-extension-appindicator (Ubuntu)
Fix Released
High
Didier Roche-Tolomelli

Bug Description

GNOME Shell freeze and crash if appindicator can't lookup an icon. A lot of messages are spawned in the logs:

Feb 20 15:40:46 neutrino gnome-shell[2735]: message repeated 2 times: [ [AppIndicatorSupport-FATAL] unable to lookup icon for Cozy Drive1_4575]
Feb 20 15:40:46 neutrino gnome-shell[2735]: [AppIndicatorSupport-FATAL] unable to lookup icon for Cozy Drive1_4578
Feb 20 15:41:32 neutrino gnome-shell[2735]: message repeated 3611 times: [ [AppIndicatorSupport-FATAL] unable to lookup icon for Cozy Drive1_4578]
Feb 20 15:41:32 neutrino gnome-shell[2735]: ../../../../glib/gmem.c:135: failed to allocate 32 bytes
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: GNOME Shell crashed with signal 5
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: == Stack trace for context 0x55b19a6e3210 ==
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #0 7fff92c183f0 I /<email address hidden>/appIndicator.js:309 (7f6f5b632550 @ 680)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #1 7fff92c184d0 b resource:///org/gnome/gjs/modules/_legacy.js:82 (7f6f63cb0b80 @ 71)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #2 7fff92c18540 I /<email address hidden>/appIndicator.js:260 (7f6f5b6324c0 @ 115)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #3 7fff92c18620 b resource:///org/gnome/gjs/modules/_legacy.js:82 (7f6f63cb0b80 @ 71)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #4 7fff92c186c0 I /<email address hidden>/appIndicator.js:425 (7f6f5b632820 @ 960)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #5 7fff92c18790 b resource:///org/gnome/gjs/modules/_legacy.js:82 (7f6f63cb0b80 @ 71)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #6 7fff92c18800 I self-hosted:977 (7f6f63cf0280 @ 413)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #7 7fff92c18870 I self-hosted:977 (7f6f63cf0280 @ 413)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #8 7fff92c188f0 I resource:///org/gnome/gjs/modules/signals.js:128 (7f6f63cc18b0 @ 386)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #9 7fff92c18940 I /<email address hidden>/appIndicator.js:162 (7f6f5b6320d0 @ 96)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #10 7fff92c189d0 I self-hosted:261 (7f6f63cc1dc0 @ 223)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #11 7fff92c189d0 I /<email address hidden>/appIndicator.js:156 (7f6f5b632040 @ 65)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #12 7fff92c18ab0 b resource:///org/gnome/gjs/modules/_legacy.js:82 (7f6f63cb0b80 @ 71)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #13 7fff92c18b30 I self-hosted:981 (7f6f63cf0280 @ 474)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #14 7fff92c18bb0 I self-hosted:981 (7f6f63cf0280 @ 474)
Feb 20 15:41:32 neutrino org.gnome.Shell.desktop[2735]: #15 7fff92c19ca0 b /<email address hidden>/util.js:42 (7f6f5b63b670 @ 145)

https://gitlab.gnome.org/GNOME/gnome-shell/issues/984

tags: added: rls-dd-incoming
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell-extension-appindicator (Ubuntu):
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

That doesn't seem to hit lot of users, setting rls-dd-notfixing but we should still have a look if possible

tags: added: notfixing
Changed in gnome-shell-extension-appindicator (Ubuntu):
importance: Undecided → High
assignee: nobody → Didier Roche (didrocks)
Iain Lane (laney)
tags: added: rls-dd-notfixing
removed: notfixing rls-dd-incoming
Revision history for this message
Linus (linusfolke) wrote :

Similar bug affects me and puts a hit on performance. When speaking in discord there is supposed to be an icon change and logs spam me with [AppIndicatorSupport-FATAL] unable to lookup icon for discord1_40.

Whenever this happens and I'm playing Overwatch, the game suffers from a lot of stuttering, currently making it unusable to use regular ubuntu gnome session with gaming and discord. Works fine in vanilla gnome session without the indicator extension.

Revision history for this message
Linus (linusfolke) wrote :

Didn't have a problem with this in 19.04, but after upgrading to 19.10 it's back...

Revision history for this message
Linus (linusfolke) wrote :

Answer #15 from bug #1825623 fixed it though

Revision history for this message
Linus (linusfolke) wrote :

Too quick on that one, was not fixed just by reinstalling gnome-shell-extension-appindicator. Now i also noticed that this isn't just in the game, the whole desktop freezes for a moment when talking in discord if the appindicator package is installed.
Easily reproduced by joining a voice channel in discord and just doing stuff in the gnome ui, watching a video or whatever while talking. Didn't notice before since gnome performance wasn't that good by itself up until now.

This is pretty bad since it leaves no choice but to uninstall gnome-shell-extension-appindicator and loosing that functionality if people wants to use discord on ubuntu.

This is also reported on the extensions github page:
https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/171
https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/157

Changed in gnome-shell-extension-appindicator (Ubuntu):
status: Confirmed → Fix Committed
tags: added: fixed-upstream
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-appindicator - 33-1

---------------
gnome-shell-extension-appindicator (33-1) experimental; urgency=medium

  * Team upload.

  [ Marco Trevisan (Treviño) ]
  * New upstream version:
    - Completely refactored the icons handling, to use the same look and
      behavior of the default gnome-shell indicators and properly handle
      HiDPI cases.
    - appIndicator: Always use Gio.Icon as model and St.Icon ui (LP: #1723827,
      LP: #1817073, LP: #1832793, LP: #1825623)
    - appIndicator: Don't try to reload multiple times a pending icon
    - appIndicator: Lookup theme icons using scale factor
    - testTool: Add test to show a changing label
    - indicatorStatusIcon: Use Clutter actor alignment on 3.35+ versions
      (LP: #1866042)
    - appIndicator: Add a cancellable to stop the proxy on destruction
    - Util: Cancel previous properties refresh requests on new one
    - util: Don't emit signal changed if a property contents is equal
    - Util: add message structured logging as well
    - Util: Cleanup syntax of refreshPropertyOnProxy
    - appIndicator: Use simpler implementation for argbToRgba
    - appIndicator: Use warning level for not found icons

  [ Fini Jastrow ]
  * appIndicator: Fix runtime error when icon can not be loaded

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 12 Mar 2020 22:36:05 +0100

Changed in gnome-shell-extension-appindicator (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.