Buttons aren't properly themed in Radiance theme under HiDPI

Bug #1781736 reported by Harm van Bakel
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu theme
In Progress
Medium
Marco Trevisan (Treviño)
ubuntu-themes (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[ Impact ]

Buttons in radiance aren't properly themed in highdpi mode

[ Test case ]
1. Run a gtk app with CSD (i.e.) gnome-disks with GDK_SCALE=2 and GTK_THEME=Radiance
   GDK_SCALE=2 GTK_THEME=Radiance gnome-disks
2. Buttons should be properly themed and with high-quality borders in both normal and
   focused state.

[ Regression potential ]

No proper borders are painted on buttons under Radiance

--

There is a typo in the file /usr/share/themes/Radiance/gtk-3.20/gtk-widgets.css that causes focused buttons to be drawn incorrectly in the radiance theme. The following change should be made to the file to fix the incorrect assets link:

118c118
< url("assets/button-focused.png@2"));
---
> url("assets/button-focused@2.png"));

ProblemType: BugDistroRelease: Ubuntu 18.04
Package: light-themes 16.10+18.04.20180421.1-0ubuntu1 [modified: usr/share/themes/Radiance/gtk-3.20/gtk-widgets.css]
ProcVersionSignature: Ubuntu 4.15.0-28.30-generic 4.15.18
Uname: Linux 4.15.0-28-generic x86_64
ApportVersion: 2.20.9-0ubuntu7.2
Architecture: amd64
CurrentDesktop: Unity:Unity7:ubuntu
Date: Sat Jul 14 15:41:53 2018
EcryptfsInUse: Yes
InstallationDate: Installed on 2018-06-23 (21 days ago)
InstallationMedia: Ubuntu 18.04 LTS "Bionic Beaver" - Release amd64 (20180426)
PackageArchitecture: allSourcePackage: ubuntu-themes
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Revision history for this message
Harm van Bakel (hvbakel) wrote :
Changed in ubuntu-themes:
importance: Undecided → Medium
Changed in ubuntu-themes (Ubuntu):
importance: Undecided → Medium
Changed in ubuntu-themes:
status: New → Triaged
Changed in ubuntu-themes (Ubuntu):
status: New → Triaged
Changed in ubuntu-themes:
status: Triaged → In Progress
Changed in ubuntu-themes (Ubuntu):
status: Triaged → In Progress
Changed in ubuntu-themes:
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in ubuntu-themes (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
summary: - Typo in assets link for focused buttons in Radiance theme
+ Buttons aren't properly themed in Radiance theme under HiDPI
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 16.10+18.10.20181005-0ubuntu1

---------------
ubuntu-themes (16.10+18.10.20181005-0ubuntu1) cosmic; urgency=medium

  [ Khurshid Alam ]
  * Remove nonexistent gnome-builder.css (LP: #1773045)

  [ Marco Trevisan (Treviño) ]
  * Radiance: fix typo in assets link for focused buttons (LP: #1781736)
  * Radiance: Use scaled image for buttons border (LP: #1781736)
  * Ambiance, Radiance: don't use padding on window buttons for chromium
    (LP: #1782038)
  * Ambiance: use default foreground color for toolbar menus (LP:
    #1758841)
  * Ambiance, Radiance: show proper arrow in combobox (LP: #1743373)
  * Ambiance, Radiance: use default disabled color for actions headerbar
    buttons (LP: #1785699)
  * Ambiace, Radiance: use headerbar destructive-action definition for
    buttons
  * Ambiance, Radiance: fix list selected color for gnome-boxes (LP:
    #1761684)
  * Ambiance, Radiance: properly theme disabled and hovered accelerators
    (LP: #1795895)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 05 Oct 2018 00:13:07 +0000

Changed in ubuntu-themes (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Harm, or anyone else affected,

Accepted ubuntu-themes into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-themes/16.10+18.04.20181005-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-themes (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Borders are properly themed and with right quality textures in this version:

$ apt-cache policy light-themes
light-themes:
  Installato: 16.10+18.04.20181004-0ubuntu1
  Candidato: 16.10+18.04.20181004-0ubuntu1

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Same here:

marco@tricky:/tmp:✗ $ LC_ALL=C apt-cache policy light-themes
light-themes:
  Installed: 16.10+18.04.20181005-0ubuntu1
  Candidate: 16.10+18.04.20181005-0ubuntu1
  Version table:
 *** 16.10+18.04.20181005-0ubuntu1 100

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 16.10+18.04.20181005-0ubuntu1

---------------
ubuntu-themes (16.10+18.04.20181005-0ubuntu1) bionic; urgency=medium

  [ Khurshid Alam ]
  * Remove nonexistent gnome-builder.css (LP: #1773045)

  [ Marco Trevisan (Treviño) ]
  * Radiance: fix typo in assets link for focused buttons (LP: #1781736)
  * Radiance: Use scaled image for buttons border (LP: #1781736)
  * Ambiance, Radiance: don't use padding on window buttons for chromium
    (LP: #1782038)
  * Ambiance: use default foreground color for toolbar menus (LP:
    #1758841)
  * Ambiance, Radiance: show proper arrow in combobox (LP: #1743373)
  * Ambiance, Radiance: use default disabled color for actions headerbar
    buttons (LP: #1785699)
  * Ambiance, Radiance: fix list selected color for gnome-boxes (LP:
    #1761684)
  * Ambiance, Radiance: properly theme disabled and hovered accelerators
    (LP: #1795895)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 05 Oct 2018 00:08:30 +0000

Changed in ubuntu-themes (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for ubuntu-themes has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.