[SRU] Unable to rename tabs

This was fixed in lxterminal version 0.3.0-2, which is available in Artful but not Zesty.

As said before, the fix is in 0.3.0-2, but here's the diff between 0.3.0-1 and 0.3.0-2: http://launchpadlibrarian.net/318978332/lxterminal_0.3.0-1_0.3.0-2.diff.gz

Part of this diff was released in 0.3.0-1ubuntu0.1 as a security update. This was tracked in bug 1690416. The remaining delta (excluding the changelog) is as follows:

diff -Nru lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff
--- lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff 1970-01-01 00:00:00.000000000 +0000
+++ lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff 2017-05-09 04:13:07.000000000 +0000
@@ -0,0 +1,22 @@
+From: Yao Wei (魏銘廷) <email address hidden>
+Subject: fix: tab name renaming
+
+* fix: display dialog buttons for changing tab name
+
+Origin: upstream, https://git.lxde.org/gitweb/?p=lxde/lxterminal.git;a=commit;h=e2ad448556ee0f78ebdd0e36dc16e96702326fb6
+Bug: https://github.com/lxde/lxterminal/issues/30
+Bug-Debian: http://bugs.debian.org/862096
+
+--- a/src/lxterminal.c
++++ b/src/lxterminal.c
+@@ -573,8 +573,8 @@
+ _("Name Tab"),
+ GTK_WINDOW(terminal->window),
+ 0,
+- NULL, GTK_RESPONSE_CANCEL,
+- NULL, GTK_RESPONSE_OK,
++ _("_Cancel"), GTK_RESPONSE_CANCEL,
++ _("_OK"), GTK_RESPONSE_OK,
+ NULL);
+ gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_OK);
+ if (gtk_icon_theme_has_icon(gtk_icon_theme_get_default(), "lxterminal"))
diff -Nru lxterminal-0.3.0/debian/patches/series lxterminal-0.3.0/debian/patches/series
--- lxterminal-0.3.0/debian/patches/series 1970-01-01 00:00:00.000000000 +0000
+++ lxterminal-0.3.0/debian/patches/series 2017-05-09 04:13:07.000000000 +0000
@@ -0,0 +1,2 @@
01-cve-2016-10369.diff
+02-fix-tab-name-dialog.diff

I think the best option at this point is to force sync 0.3.0-2 from Buster (not Sid as 0.3.0-3 was uploaded and that is outside the scope of this SRU) to Zesty. It wouldn't necessarily make a difference (I believe) if we were to force sync versus just increasing the delta, but it seems cleaner to me.

Thoughts?

Hello Simon, or anyone else affected,

Accepted lxterminal into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lxterminal/0.3.0-1ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Unsubscribing sponsors since there is nothing left to sponsor.

I have tested 0.3.0-1ubuntu0.2 and it works fine.

Thanks!

This bug was fixed in the package lxterminal - 0.3.0-1ubuntu0.2

---------------
lxterminal (0.3.0-1ubuntu0.2) zesty; urgency=medium

  [ Yao Wei ]
  * Fix tab renaming dialog. (LP: #1703307)

 -- Simon Quigley <email address hidden> Tue, 11 Jul 2017 06:12:54 -0500

The verification of the Stable Release Update for lxterminal has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.