Offer to include testparm's analysis in bug reports
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
samba (Ubuntu) |
Fix Released
|
Wishlist
|
Andreas Hasenack |
Bug Description
It would be helpful to offer to include samba's testparm(1) analysis of the smb.conf config file in samba bug reports.
If the user agrees to attach smb.conf, then it's not really needed (bug triagers can run it themselves), but in the case of a refusal, having testparm run a quick sanity check on that file and include its report in the bug would save time.
I have a test branch that implements the following workflow:
- if the user refuses to attach smb.conf, ask a followup question about testparm
- this followup question asks if the user would allow us to run "testparm -s /etc/samba/smb.conf > /dev/null". This will capture testparm's analysis of the config file, show share names, show syntax errors, and give a good or bad result.
- the user can refuse to run testparm
- if the user agreed to attach smb.conf in the previous question, then we don't run testparm.
summary: |
- Offer to include testparm's analysis in but reports + Offer to include testparm's analysis in bug reports |
Attached is a quick diff showing the changes made for this proposal. This is the corresponding git branch: https:/ /code.launchpad .net/~ahasenack /ubuntu/ +source/ samba/+ git/samba/ +ref/apport- run-testparm