Ubuntu
squid-langpack package

Missing dep8 tests

Bug #1679403 reported by Joshua Powers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
squid-langpack (Ubuntu)
New
Wishlist
Unassigned

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

As of April 3, 2017, this source package did not contain package tests
in the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source squid-langpack zesty` and then
checking for the existence of 'debian/tests/' and
'debian/tests/control'. The package was also checked for 1) a test suite
declaration in the debian/control file, 2) any 'test', 'tests',
'testsuite', or 'test-suite' directories, 3) go tests (if applicable),
and 4) a test suite declared in a setup.py (if applicable).

If you feel this report is incorrect (e.g. this is a library or a source
only package) or the check above missed some other package level test
please reply explaining why and mark this bug as 'invalid'.

Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.

This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.

Thanks!

[1] http://packaging.ubuntu.com/html/auto-pkg-test.html

 affects ubuntu/squid-langpack
 status new
 importance wishlist
 tag needs-dep8

- ---
Joshua Powers
Ubuntu Server
Canonical Ltd

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJY4s02AAoJEIP8BxPaZgwlwlcP/3wRcL7sJ4eZXZOD2pNbIFDO
sfBSN4mRtjqXhloNsrAk4xYkP5gPOOITVhvyAywS5u0OlzlpgT3MwjSRJ8gLoMk7
YgZopX0MLPMKa91xIod3HeT2XxopJBXahKyWIl1UHbv5xzTEmRlGFDaEdLjmIjz4
juGJOc3CJ8MeRKFjZPZm57nvMBRj4qw6muZ4lj50zV0bQCR2qm8q4H6MHFAWov5K
xX0sLv2I6QYh5Vwc96C2t7AGf2cIA6f6hWwqh8MDfNor+mohqBnoXVVPL+QzWsMM
uCMZul6s5tZO2QuBVqejpOWipGdMpmQBf3Z0tdYAs2V8DbEw9wYZPYEsyuhoDlp4
0vnkCFmZoKmgNfzTV/2P6bu+CWU48eD3g2elrql9Okfc8veH7jPSlTdeOMBsti5t
0qZC0tAlWpWfvLquSLWeOP6TdO7qJvGvRh8Wj6jzMa/S5Fr9MGUECnxdHoWOl86x
7NONf7/I7zJZeu2aTp4pI4FuL50cau2Y7+ZwXlu7d76x+67tSNJPqIP1gEmOkVGL
Rb9HlZNRxvDN70u5dV3aqUtgvFUKJ33E7QDzrnaAQGimCm3HHN9iSup7lqxbUgK4
s5FHNf3UYIkF9MsB6/RnyhlinOvgRn7m0XV2166PivlcXukQG9+aqVW4bjuf2hS5
fR7NINv2TEZHPHTnxTWl
=OG7q
-----END PGP SIGNATURE-----

Tags: needs-dep8
Revision history for this message
Amos Jeffries (yadi) wrote :

The basic test that Squid application will start is already done by the squid package DEP-8 tests. Though that could be repeated as a test for this package with the simpler installation of only squid, squidclient and squid-langpack packages.

What seems to be missing is a test that the right Content-Language error response is returned by Squid given an Accept-Language input header. A default installation of squid should reject all traffic, so is easy to test for that.

Are there any other specific DEP-8 tests preferred for a package which simply installs translation files for another package?

Revision history for this message
Joshua Powers (powersj) wrote :

@yadi, thanks for looking at this! When I filed a number of bugs around missing dep8 tests I did my best to catch source packages that did not contain binaries/source-only.

I think your proposed test would give an uploader a greater sense of security when uploading a new version of the package. However, given how little the package has been updated in the past and that it does not contain binaries or depend on anything I believe the risk is low. Therefore I am also fine with closing as invalid as well.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.