Missing dep8 tests
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| sg3-utils (Ubuntu) |
Triaged
|
Wishlist
|
Unassigned | ||
Bug Description
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
As of April 3, 2017, this source package did not contain package tests
in the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source sg3-utils zesty` and then
checking for the existence of 'debian/tests/' and
'debian/
declaration in the debian/control file, 2) any 'test', 'tests',
'testsuite', or 'test-suite' directories, 3) go tests (if applicable),
and 4) a test suite declared in a setup.py (if applicable).
If you feel this report is incorrect (e.g. this is a library or a source
only package) or the check above missed some other package level test
please reply explaining why and mark this bug as 'invalid'.
Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.
This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.
Thanks!
[1] http://
affects ubuntu/sg3-utils
status new
importance wishlist
tag needs-dep8
- ---
Joshua Powers
Ubuntu Server
Canonical Ltd
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCAAGBQJ
leOyQh2otU/
kb8gJB3AEpjQQxv
GiqTWXsZwBpKdI3
1jexgORtchXFwNP
911sgSYzwurpUYT
pKSujgNGLaVU+
TL5+FUw2UOPyytX
6+gMwjIe3RZXHKJ
kfgbpBALQAd+
I2c+7MBYSwdiVVb
nIZ4nE4sC1KPTOR
=qS2t
-----END PGP SIGNATURE-----
| Bryce Harrington (bryce) wrote | #1 |
| Changed in sg3-utils (Ubuntu): | |
| status: | New → Triaged |
| Christian Ehrhardt (paelzer) wrote | #2 |
This is a collection of binary cli tools and bash scripts that do hardware-specific operations. There have only ever been 10 bugs filed against this package, and nearly all are packaging-related (e.g. sync requests.) Thus, this package may see limited benefit of having dep8 tests.
I think the extent of tests should just check installation of a handful of the most commonly used commands
That said, some simple smoke tests for common commands might be of some usefulness, and could be sufficient to close this bug. From looking at https:/
```
test -e /usr/bin/sg_dd
test -e /usr/bin/sg_map
test -e /usr/bin/sg_inq
test -e /usr/bin/sg_read
```
Probably safe to assume that these are representative enough that if they're installed, all the other utilities would be as well.
It's probably unreasonable to assume that the testing environments this runs in will be assured to have any SCSI devices available for the test. But, if that can be guaranteed, then it might be of use to run sg_inq as a basic smoke test.