Missing dep8 tests

Bug #1679329 reported by Joshua Powers
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
logwatch
New
Unknown
logwatch (Ubuntu)
Fix Released
Wishlist
Miriam España Acebal

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

As of April 3, 2017, this source package did not contain package tests
in the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source logwatch zesty` and then
checking for the existence of 'debian/tests/' and
'debian/tests/control'. The package was also checked for 1) a test suite
declaration in the debian/control file, 2) any 'test', 'tests',
'testsuite', or 'test-suite' directories, 3) go tests (if applicable),
and 4) a test suite declared in a setup.py (if applicable).

If you feel this report is incorrect (e.g. this is a library or a source
only package) or the check above missed some other package level test
please reply explaining why and mark this bug as 'invalid'.

Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.

This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.

Thanks!

[1] http://packaging.ubuntu.com/html/auto-pkg-test.html

 affects ubuntu/logwatch
 status new
 importance wishlist
 tag needs-dep8

- ---
Joshua Powers
Ubuntu Server
Canonical Ltd

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJY4scFAAoJEIP8BxPaZgwl5MMQAI+Kv9BQDrXVSc/YNeI7UbV5
4/xZG2T5bWNDhJ5mo9aFNBQ4hSuozfy2CFYdGjNYjk8yXn8TNZox0awvL5W5nJPg
Nd5r9uoWOIl8IW0bh4k7o8juxnF6CxV7vG1eiAGBdDjI4aAdZo6X/6przNQbhs1/
G7aMm6b9lMRoIKBd2qBRhc4wRTTkQIsJGJeMLSXLtHril4q+Dniei7CSivahHd7w
+nXXVg/pmWa2B/XSN80afE1JKE0BiN7AWkSqWWC/15em43D0aSX2tXGyNhRm0Yat
j+cRyUIB9VTjknyYxak+smSfzdSGBw4RTTPZfaMrivJMu+/lSuyzjh7poFGCEkBU
Hbw++eRWm8VNKGp5vAAnvc6eSW2y8bVBAFXe4FKA5SwWnFrORc8qT5Bm9O1/FRQ/
9CpmxP9x10pn4ik27Cpo0chgF5eK3PuC2NX4gmn1e92rPXVsxE+nVbgsZCc++7lQ
4UkSbEDGLXVTfi+DNU4nS7Y/yKriRSua3OgGrN2CjGtQm1HI3ruNstDUbZI0JcEt
OHVY/IsXa5XRYwKEABPigYVAaNvahJ3eEc9luGSVHZJr6vjj0ASdqzmHNxIxyxAi
lbRMU3rR742q3XG4J4lKwB7xXuyN3KV5JdwE7JJjScyXqoVb2XlNa+FLZ1+AS8uf
ii2QKrzzJCm3Pg6lEwLH
=Wshy
-----END PGP SIGNATURE-----

Tags: needs-dep8

Related branches

Revision history for this message
Bryce Harrington (bryce) wrote :

I'm not sure there's a whole lot of value to gain from a dep8 test of this package, it's basically just a collection of perl scripts.

Probably 90% of issues would be caught by just doing a syntax check on each of the Perl files (i.e. perl -c lib/Logwatch.pm; etc.)

A simple integration test for this might be to just run logwatch over a collection of sample config files, and verify the generated report includes stuff it should be flagging, and omits chaff that it shouldn't. Some recent logwatch SRUs are using this approach for their test cases.

Changed in logwatch (Ubuntu):
status: New → Triaged
Changed in logwatch (Ubuntu):
assignee: nobody → Miriam España Acebal (mirespace)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package logwatch - 7.5.5-1ubuntu3

---------------
logwatch (7.5.5-1ubuntu3) impish; urgency=medium

  * d/tests: Add autopkgtest DEP8 tests (LP: #1679329):
    - d/t/control: New file.
    - d/t/basic-checks: Test basic configuration and version.
    - d/t/syntax-check: Perl syntax checking for the logwatch's scripts.
    - d/t/detail: Check the amount of output when using low, med and
      high values with the detail flag.
    - d/t/su-l-check: Check if properly report when a user become root.
      + d/t/data/su-l: Log portion used in this test.
    - d/t/apparmor-unmatched-entries : Test for not logging as unmatched
      some lines for apparmor audit in kern.log.
      + d/t/data/unmatched-entries-apparmor_kern.log: Log portion
        used in the test (LP #1577948).
    - d/t/packages-and-report: Check if the corresponding section
      is present into logwatch report for a list of packages/services
      (now only for sshd).

 -- Miriam España Acebal <email address hidden> Thu, 29 Jul 2021 16:53:01 +0200

Changed in logwatch (Ubuntu):
status: Triaged → Fix Released
Changed in logwatch:
status: Unknown → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.