Ubuntu
libpam-mount package

Missing dep8 tests

Bug #1679327 reported by Joshua Powers
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libpam-mount (Ubuntu)
Confirmed
Wishlist
Unassigned
Bionic
Fix Released
Undecided
Unassigned
Cosmic
Fix Released
Undecided
Unassigned

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

As of April 3, 2017, this source package did not contain package tests
in the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source libpam-mount zesty` and then
checking for the existence of 'debian/tests/' and
'debian/tests/control'. The package was also checked for 1) a test suite
declaration in the debian/control file, 2) any 'test', 'tests',
'testsuite', or 'test-suite' directories, 3) go tests (if applicable),
and 4) a test suite declared in a setup.py (if applicable).

If you feel this report is incorrect (e.g. this is a library or a source
only package) or the check above missed some other package level test
please reply explaining why and mark this bug as 'invalid'.

Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.

This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.

Thanks!

[1] http://packaging.ubuntu.com/html/auto-pkg-test.html

 affects ubuntu/libpam-mount
 status new
 importance wishlist
 tag needs-dep8

- ---
Joshua Powers
Ubuntu Server
Canonical Ltd

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJY4sbXAAoJEIP8BxPaZgwlGQEQAJSgUwxNgByubMe5re9wCzGA
8Znd30VuBGeKO9gIeNObuUF1UJmrCuG4S33QsrTAEK8rDc7XqV8wZUTlYjembWr+
xpz0yW36w/Ys+7GLeeDaShHcshHjUzjBxGzM/n3O82gAkikDzFM7tm8P23+cBhzR
DnPt/+jsUtWTMTKnfFvhkSilRsS8stILHvQUWHQZ/VGUR77r1cC7jdwHaxlgYHYz
yh+G3RVY+eRZU0817pP3pH9CuJAdN6cwjT5hvLodGGqdMy/i+/ee50wAnvsY2CeC
UupMQazWOy6wVNkBultmfJjfkPe8uWTgw8v55TTF4fLpBLzxxFcOC3+rp5ofe2As
6o6INEds7+MCGuoFsR+VRuLoTgBw7iM70a7DZQkZYuSqFKBO9Ng6omFVDQuvOMJI
zfQo7q8soN734D1cJ+pZy8OY2beP89P+vp+3IDybpwKmoPSbfWYhfAxGjm9LvydO
IwUVpCL+xoVJclYVkg6N0KwueEnbmEEE14PY2AlE7+hYKber0wIEJdUmyHOS2nGV
oAIiptKqN8jDsWmBACWaIp8Goaq3D+Uft/Ob2YNftM6Ve7eszpiKMjRpIv1nt+GI
Te0UidoxwrGeb/pukCtO76pI8bcnm1VeXuL7/w0fEfQfl+O1ugVd7bwhj02KsOwI
MXaH4XDETiDwkEyggu8l
=Pxmj
-----END PGP SIGNATURE-----

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

will be fixed as part of bug 1804408 for SRUs and hopefully via [1] in Debian to then sync into Ubuntu (otherwise we add a Delta for a short while).

[1]: https://salsa.debian.org/debian/libpam-mount/merge_requests/1

Changed in libpam-mount (Ubuntu Bionic):
status: New → Triaged
Changed in libpam-mount (Ubuntu Cosmic):
status: New → Triaged
Changed in libpam-mount (Ubuntu):
status: New → Confirmed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Joshua, or anyone else affected,

Accepted libpam-mount into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libpam-mount/2.16-5ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libpam-mount (Ubuntu Cosmic):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The tests are defined and running now as seen on https://people.canonical.com/~ubuntu-archive/proposed-migration/cosmic/update_excuses.html

Since that link will pass here one example: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic/cosmic/amd64/libp/libpam-mount/20190214_084047_dca47@/log.gz

Thereby setting verified for this ...

tags: added: verification-done verification-done-cosmic
removed: verification-needed verification-needed-cosmic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for libpam-mount has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libpam-mount - 2.16-5ubuntu0.1

---------------
libpam-mount (2.16-5ubuntu0.1) cosmic; urgency=medium

  * d/p/0015-Use-crypt_get_type-to-get-type-and-support-CRYPT_LUK.patch:
    allow more than just LUKS1 by detecting the type (LP: #1804408)
  * d/tests/control, d/tests/local-luks: add autopkgtest for luks1/luks2
    automount on user login. (LP: #1679327)

 -- Christian Ehrhardt <email address hidden> Wed, 06 Feb 2019 09:56:49 +0100

Changed in libpam-mount (Ubuntu Cosmic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Joshua, or anyone else affected,

Accepted libpam-mount into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libpam-mount/2.16-3ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libpam-mount (Ubuntu Bionic):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-bionic
removed: verification-done
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Test executed fine on the SRU from proposed:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/libp/libpam-mount/20190225_143346_e53d2@/log.gz

Setting verified

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libpam-mount - 2.16-3ubuntu0.1

---------------
libpam-mount (2.16-3ubuntu0.1) bionic; urgency=medium

  * d/p/0015-Use-crypt_get_type-to-get-type-and-support-CRYPT_LUK.patch:
    allow more than just LUKS1 by detecting the type (LP: #1804408)
  * d/tests/control, d/tests/local-luks: add autopkgtest for luks1/luks2
    automount on user login. (LP: #1679327)

 -- Christian Ehrhardt <email address hidden> Wed, 06 Feb 2019 10:02:48 +0100

Changed in libpam-mount (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.