Missing dep8 tests

Bug #1677881 reported by Joshua Powers
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
krb5 (Ubuntu)
Fix Released
Wishlist
Andreas Hasenack

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

As of March 29, 2017, this source package did not contain dep8 tests in
the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source krb5 zesty` and then
checking for the existence of 'debian/tests/' and
'debian/tests/control'.

Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.

This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.

[1] http://packaging.ubuntu.com/html/auto-pkg-test.html

 affects ubuntu/krb5
 status new
 importance wishlist
 tag needs-dep8

- ---
Joshua Powers
Ubuntu Server
Canonical Ltd

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJY3YGVAAoJEIP8BxPaZgwlCIEP/36uotG3iLNIh5/fPc2FDzwV
hqK5CLKbCLqlX7RmzkSzO303hJ051Q6uWIb1ZcnvZShO4h2mrQfyXXmWBXO3So/2
imYe6Pg3j9v1aNYCxpvWKL6VIpN5beADCoWlAS9P89qSIdyEYTiaL6HFHzbA5hck
7rtMhHnzw16mkT+ttZ39f4kqZ9jqqV1je0lPyCI3L+UicswkdeymHeZAZSkG13lW
uSi5SVLFDpDeWq/23Ohj0tacLZbpBKG4vScRQ7+Me3ieGnC0gii8C1luXGPWpS9v
CvW1JLPbuo3yHooBzJw6YAYI2TiWyNjtO2/9ESPxcmn+tPn7iXoeTBIstlQC2iY0
fvoUrmxUjSJafgCyZE1NNy8gTlFLObpMP/qZPtw7YLKaD9t64+JZUK4vzSNr1tY5
ltCXFf0mneUrUjTOS1Io+vigiBbMEIFuUjEXT3DxGEybf8rrl6fJdCD++1L0NTXR
ImfhCBgSEYBrluRLHu1tGftin7wKgarl7uWLzZxGeJ/MiXkX0eWIgOVoXaQq6gnR
HR7XF1x9x1VJYi2CGMrDDWSHWDHgXC5UOcBz/KLMSPMcyQakXyRrw1Hqplj3G3PM
OkqR8uLWUYfTZvrVvnSj4jJPNRSiBOz95FFbfMZ43yxoE5F6QBhztwgcJC8/g+bn
zu94s0Hiyv+yxmptMwgX
=ibX0
-----END PGP SIGNATURE-----

Tags: needs-dep8

Related branches

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Since this package is currently a sync from Debian, and I want their opinion on these tests first, I submitted an MP for Debian here: https://salsa.debian.org/debian/krb5/merge_requests/2

Changed in krb5 (Ubuntu):
assignee: nobody → Andreas Hasenack (ahasenack)
status: New → In Progress
Revision history for this message
Sam Hartman (hartmans) wrote : Re: [Bug 1677881] Re: Missing dep8 tests

Hi.
For whatever reason I'm not getting mail when an MP is opened in the
krb5 gitlab.
In general, i think Debian uses its BTS as the todo system of record
moreso than gitlab MPs. I know for myself and I suspect a lot of other
debian developers, a wishlist bug against a package would be the best
way for me to consider a patch.

That said, since I'm also looking at launchpad, I've reviewed the MP.

Other than the license question I raised there, I think this is a great
thing to include.
I've been swamped by non-Debian life events, but I'm mostly through that
and will dedicate a day to catching up on Debian in the next couple of
weeks.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package krb5 - 1.16-2ubuntu1

---------------
krb5 (1.16-2ubuntu1) cosmic; urgency=medium

  * Add DEP8 tests (LP: #1677881):
    - d/t/util: common functions used in the tests
    - d/t/control, d/t/kinit: simple kinit test
    - d/t/control, d/t/slapd-gssapi: DEP8 test for service principals

 -- Andreas Hasenack <email address hidden> Fri, 06 Jul 2018 15:39:44 -0300

Changed in krb5 (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Robie Basak (racb) wrote :

FWIW, this test correctly caught a regression, fixed in openldap 2.4.56+dfsg-1ubuntu2. Good job :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.