Missing dep8 tests

Bug #1677818 reported by Joshua Powers
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fetchmail (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

As of March 29, 2017, this source package did not contain dep8 tests in
the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source fetchmail zesty` and then
checking for the existence of 'debian/tests/' and
'debian/tests/control'.

Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.

This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.

[1] http://packaging.ubuntu.com/html/auto-pkg-test.html

 affects ubuntu/fetchmail
 status new
 importance wishlist
 tag needs-dep8

- ---
Joshua Powers
Ubuntu Server
Canonical Ltd

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJY3XhgAAoJEIP8BxPaZgwlh8AP/i0H7XItFEk4C7A3farT0l9R
dypbWoMZMTd3tp1j3lCG/HkHsQ/1XPBfJnUydZndxGFueSqhcouZDiyyW2zWztl2
1/1Ykuf94prG6gUgNlA7yGVLmvdwJKpC1sRg8mG7kkcQXP4coHrprEnZqRkUlnAs
6o2gmtSO4GE3yPyFPxRlKKYICEx1Cn3ZNKQygikhkqAqXK1zvRq7/+Ia867JxQoU
V3LWi3pXsnpFckgmXYMQEJbVxbHQ0w9XkFXT3tH9jJNoJGW0lZ5g3vHmR6FeuB5X
UvspfOXB7ALWQsRNbTSsrnvRd/yOXbQiYmxGY2GHbKrMoaTF4ath8Mu6lD/kzsbe
9OYpOXDSt2JeYrMUvGfY0PrpA76Bq7McWQkr6eiZts4z/psejvlx2Iq8UiGAr12R
IsZYlqVpJJOIbo6wlSotq268NUMRP6kCHgbQnuC+x12b3NyIEN2EHQkWMeEkwpM4
Sn6cduNxo+zRJ5VBPMbEY9YQHyQSOF3VhhSQLWG0Hx+khxf4nJv/4oh8RPVvDtOH
HuGIUZWKDQL2NsrnOlE5e4I8F2lS9f4C9Xv6vyQF8CFMdZvSuOijFsm2RV9YPRTD
sav6wTGiZyHXBZrf1bjVxMBxuvoboWrOAvmPXGiLjUItr8U0n33cPJ/yPiHGq1n/
h2KFyNpGiTEhfhcTJWF0
=69sQ
-----END PGP SIGNATURE-----

Tags: needs-dep8

Related branches

Revision history for this message
Bryce Harrington (bryce) wrote :

As fetchmail is a service, it should have (at least) three types of tests:

1. Check that primary bits are installed, and that fetchmail --version / --help aren't erroring.

2. Check that the service is up

3. Check operation by setting up a local POP3 mail service, sending an email to it, and verifying fetchmail fetches the email. Dovecot includes some dep8 tests that could be repurposed for setting up the mail service here.

Extra credit would repeat #3 but with IMAP and/or SSL.

I don't think fetchmailconf is worth testing; it appears to be an X11 utility without command line operational functionality.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fetchmail - 6.4.0~beta4-3ubuntu1

---------------
fetchmail (6.4.0~beta4-3ubuntu1) eoan; urgency=medium

  * Merge with Debian unstable. Remaining changes:
    - d/p/sni-support.patch: TLS: set hostname for SNI. Thanks to Matthias
      Andree <email address hidden> (LP #1798786)
  * Added Changes:
    - d/p/clang-robustness.patch: Backport clang null pointer checks from upstream
      to prevent potential segfaults.
    - d/p/set-umask-for-fetchids.patch: Backport upstream fix to set umask
      properly before writing the .fetchids file.
    - d/p/tests: Add preliminary/basic dep8 tests to check installation and
      service operation.
      (Partial fix for LP: #1677818)

fetchmail (6.4.0~beta4-3) unstable; urgency=medium

  * Backport fix potential SIGSEGV in pop3_delete (closes: #921450).
  * Backport native name verification for OpenSSL.

fetchmail (6.4.0~beta4-2) unstable; urgency=medium

  * Upload to Sid.
  * Update Standards-Version to 4.3.0 .

fetchmail (6.4.0~beta4-1) experimental; urgency=medium

  * New major upstream beta release:
    - improved TLS support (closes: #768843).
  * Update watch file.
  * Disable Vcs-* fields for now.
  * Update debhelper level to 11:
    - remove dh-autoreconf build dependency,
    - remove autotools-dev build dependency,
    - don't specify parallel to debhelper,
    - specify restart-after-upgrade to dh_installinit .
  * Update Standards-Version to 4.1.4 .

  [ Russell Coker <email address hidden> ]
  * Run restorecon after creating directory from init script (closes: #752598).

  [ Nicolas Boulenguez <email address hidden> ]
  * Packaging updates (closes: #895366):
    - rename d/init to d/fetchmail.init, as recommended by policy,
    - give standard formatting to header of 01_fetchmailconf.patch ,
    - remove obsolete debian/pycompat ,
    - fix typo in manpage,
    - delegate installation of ppp and logcheck scripts to debhelper,
    - delegate manpages from dh_install to more specialized
      dh_installmanpages ,
    - install contrib files and resolvconf directly without intermediate copy
      in debian/tmp ,
    - switch copyright to format 1.0 and add some missing licenses.
    - delegate buggy installation of README.contrib to debhelper,
    - per policy 4.0.0, use invoke-rc.d instead of calling /etc/init.d/*
      directly,
    - rules: drop paragraphe preparing unused variable CONFFLAGS ,
    - rules: simplify some variable affectations,
    - delegate build flags stuff to dpkg-buildflags .

  [ Kevin Ryde <email address hidden> ]
  * Let fetchmail-mode run hook after other settings (closes: #710319).

 -- Bryce Harrington <email address hidden> Sun, 16 Jun 2019 18:45:16 -0700

Changed in fetchmail (Ubuntu):
status: New → Fix Released
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks like the upload closed the bug, but as mentioned there's at least one more test needing written before we can consider this complete.

Changed in fetchmail (Ubuntu):
status: Fix Released → In Progress
Bryce Harrington (bryce)
Changed in fetchmail (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fetchmail - 6.4.16-1ubuntu1

---------------
fetchmail (6.4.16-1ubuntu1) hirsute; urgency=medium

  * d/t/control: Invoke upstream testsuite via make check.
  * d/t/control, d/t/operation, d/t/mock-pop3-server.py: Add DEP8 test
    for checking fetchmail's POP3 functionality.
    (LP: #1677818)

 -- Bryce Harrington <email address hidden> Thu, 04 Mar 2021 18:40:28 +0000

Changed in fetchmail (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.