Missing dep8 tests

Bug #1677781 reported by Joshua Powers
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cyrus-sasl2 (Ubuntu)
Fix Released
Medium
Andreas Hasenack
Jammy
Fix Released
Undecided
Lena Voytek

Bug Description

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

As of March 29, 2017, this source package did not contain dep8 tests in
the current development release of Ubuntu, named Zesty. This was
determined by running `pull-lp-source cyrus-sasl2 zesty` and then
checking for the existence of 'debian/tests/' and
'debian/tests/control'.

Test automation is essential to higher levels of quality and confidence
in updates to packages. dep8 tests [1] specify how automatic testing can
be integrated into packages and then run by package maintainers before
new uploads.

This defect is to report the absence of these tests and to report the
opportunity as a potential item for development by both new and
experienced contributors.

[1] http://packaging.ubuntu.com/html/auto-pkg-test.html

 affects ubuntu/cyrus-sasl2
 status new
 importance wishlist
 tag needs-dep8

- ---
Joshua Powers
Ubuntu Server
Canonical Ltd

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJY3XaTAAoJEIP8BxPaZgwlJr8P/j8yn8mXWnAIiXUgHX7jBIGj
JuMQGO5wwcfHRxOwJEOlsO/SIATUN1L1BB84anP7Bp4cfLqXonF8eKFPkEotwaf1
3wADCH98EwLuSyJOaKXsTQHppAKdJ6UEW4jHvfhYizenEWssPfCQdg68LSGZ2enR
wD9ZhZgjwJIpLbqDTp7ygklR0htf4ZAFq/vIcyLykT6qagVE3xC8SAgd+7tb/fYe
4PYfqgGso/qpL0v6JL+YkCKH/aiMYV+HD45o1NcUbGdoiuUa9jpeYSSTP/9OgWpY
nALDXe/dJZT/wz5Zv0cy6sGRh7gtjVqI0608WAM00Jp8CmFX60z4yrq/3t37wKbz
iDQF4HyltqfCNF5oQ6xva9xAq/c2tyP8nBHzQ+ZtH/o1hyS/JdgoR38OojldyUc5
WzcTFL+h612ZVZVNm4lqBpg/0dpEkwXTE9KczyB5kSr5VVz0WXtjU5wFxKMdZpr5
Gq9uM+fHU4YHQqfGGZxmHFOgz7tCAyEsZEzpnPiYvoSksj3tJMkQG7FbIISltort
CBAwLIt1hLR9g4T3p0e4ipCJf6kL/yZR3kMGhsjbDe012bTaC8ZeLG7VYmWkBaxY
ieFMZIxmGgCq7KjDfNPh9JEmCtNgenkEOu6BszZK+gwmhL/AxVuuNRdd5OeBGy3G
WY9JzBOc6MUi46Hh9ZN5
=szTz
-----END PGP SIGNATURE-----

Related branches

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

We were recently hit by bug #1956833, where GSS-SPNEGO was suddenly disabled and nobody noticed until an app tried to use it.

For that case, I'm thinking about a very simple test that would be like this:

for algo in $ALGORITHMS; do
  saslpluginviewer -m $algo > /dev/null || {
    echo "Algorithm $algo not available"
    exit 1
  }
done

And ALGORITHMS is a list of the algorithms we expect to always be available, like:
  SCRAM-SHA-1 SCRAM-SHA-256 GS2-IAKERB GS2-KRB5 GSS-SPNEGO GSSAPI DIGEST-MD5 EXTERNAL CRAM-MD5 NTLM PLAIN LOGIN ANONYMOUS

tags: added: bitesize
Changed in cyrus-sasl2 (Ubuntu):
status: New → Triaged
Changed in cyrus-sasl2 (Ubuntu):
assignee: nobody → Andreas Hasenack (ahasenack)
Changed in cyrus-sasl2 (Ubuntu):
status: Triaged → In Progress
importance: Wishlist → Medium
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sent new dep8 tests to debian, and then synced the package back into ubuntu:
https://launchpad.net/ubuntu/+source/cyrus-sasl2/2.1.28+dfsg-5

Revision history for this message
Andreas Hasenack (ahasenack) wrote :
Changed in cyrus-sasl2 (Ubuntu):
status: In Progress → Fix Released
Lena Voytek (lvoytek)
Changed in cyrus-sasl2 (Ubuntu Jammy):
assignee: nobody → Lena Voytek (lvoytek)
status: New → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Joshua, or anyone else affected,

Accepted cyrus-sasl2 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cyrus-sasl2/2.1.27+dfsg2-3ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in cyrus-sasl2 (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (cyrus-sasl2/2.1.27+dfsg2-3ubuntu1.1)

All autopkgtests for the newly accepted cyrus-sasl2 (2.1.27+dfsg2-3ubuntu1.1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

python-bonsai/1.3.0+ds-3build1 (armhf)
librdkafka/1.8.0-1build1 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#cyrus-sasl2

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

The tests are green, except for i386 which has "always" been red due to dependency problems.

The new tests ran fine in all architectures:

(paste from amd64, it's the same for the others)
autopkgtest [00:21:02]: @@@@@@@@@@@@@@@@@@@@ summary
pluginviewer PASS
saslauthd PASS
gssapi PASS
shared-secret-mechs PASS

Jammy verification succeeded.

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cyrus-sasl2 - 2.1.27+dfsg2-3ubuntu1.1

---------------
cyrus-sasl2 (2.1.27+dfsg2-3ubuntu1.1) jammy; urgency=medium

  * Add SASL channel binding support for GSSAPI and GSS-SPNEGO
    (LP: #1912256):
    - d/p/0034-channel-binding-gssapi-gss-spnego.patch: add SASL channel
      binding support for GSSAPI and GSS-SPNEGO
    - d/p/0035-Add-support-for-setting-max-ssf-0-to-GSS-SPNEGO-1.patch:
      allow setting maxssf to 0 when using GSS-SPNEGO inside SSL/TLS
    - d/p/0035-Add-support-for-setting-max-ssf-0-to-GSS-SPNEGO-2.patch:
      be more conformant to RFC4752
  * Add some DEP8 tests (LP: #1677781):
    - d/t/{control,saslauthd}: saslauthd tests with multiple mechanisms
    - d/t/{control,gssapi}: test for SASL GSSAPI using OpenLDAP
    - d/t/{control,pluginviewer}: test available mechanisms
    - d/t/{control,shared-secret-mechs}: test shared secret mechanisms

 -- Lena Voytek <email address hidden> Wed, 19 Oct 2022 14:06:40 -0700

Changed in cyrus-sasl2 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for cyrus-sasl2 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.