empty strings as option values are badly quoted
Bug #906897 reported by
Vincent Ladeuil
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Medium
|
Vincent Ladeuil | ||
Bug Description
While migrating the branch location options I came across a weird edge case where an empty value is seen as '""' instead of ''.
The root cause is rather involved (related to configobj making quoting depends on automagic list values *and* option expansion).
Related branches
lp:~vila/bzr/906897-quoting-stores
- Jelmer Vernooij (community): Approve
-
Diff: 695 lines (+220/-162)7 files modifiedbzrlib/branch.py (+1/-3)
bzrlib/config.py (+99/-36)
bzrlib/plugins/po_merge/po_merge.py (+1/-2)
bzrlib/tests/blackbox/test_config.py (+7/-6)
bzrlib/tests/test_config.py (+94/-114)
doc/developers/configuration.txt (+14/-1)
doc/en/release-notes/bzr-2.5.txt (+4/-0)
| Changed in bzr: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| tags: | added: config |
Revision history for this message
| Vincent Ladeuil (vila) wrote | #1 |
| Changed in bzr: | |
| assignee: | nobody → Vincent Ladeuil (vila) |
| status: | Confirmed → In Progress |
| Changed in bzr: | |
| milestone: | none → 2.5b5 |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Some tests in blackbox/
Namely: configobj provides a list_values option at build time that is used to decide whether or not :
- values are quoted
- values are transformed into list values if they contain a coma (handwave)