session slugs containing + have broken etherpad links
Bug #855826 reported by
Alan Bell
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Summit |
Fix Released
|
Critical
|
Unassigned |
Bug Description
for example:
http://
the pad links below the page point at http://
http://
The former does a redirect to a url swapping the + for a - the latter is a 404 page.
Related branches
lp:~james-w/summit/fix-etherpad-urls
- Michael Hall (community): Approve
-
Diff: 110 lines (+63/-3)2 files modifiedsummit/schedule/models/meetingmodel.py (+9/-3)
summit/schedule/tests.py (+54/-0)
Changed in summit: | |
status: | New → Triaged |
importance: | Undecided → Critical |
Changed in summit: | |
status: | Triaged → Fix Committed |
Changed in summit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
etherpad mangles Pad IDs with the following regular expression /[^a-zA- Z0-9\-] /g, '-');
return str.replace(
if we apply that to the slugs we can generate URLS with valid pad IDS