Launcher icon highlighting should not switch off as soon the cursor moves after the app spread appears.
Bug #727902 reported by
John Lea
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Committed
|
High
|
John Lea | ||
| Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| 7.2 |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Bug Description
[Impact]
When dragging a file to an application with multiple windows open and the spread is triggered, any movement of the mouse switches off the selective highlighting and dimming of valid/non-valid drop receptacles.
[Test Case]
1) Open two windows instances of the same application (say firefox)
2) Drag a file from the file-manager or the desktop and hover the firefox icon
3) After one second the firefox icon is hovered, the spread will occur
4) Dragging the icon outside the launcher and in the spread area (both over a window or
not) should keep the desaturated icons as they were before.
[Regression Potential]
Launcher icon might be not saturated again when exiting from spread.
--------------
Description.
When a file is dragged and held over a application icon in the Launcher a spread of the app windows appear. The user can then drag and drop the file on to one of the windows to specify the window in which they would like the file to be loaded.
The bug is that after the spread appears, any movement of the mouse switches off the selective highlighting and dimming of valid/non-valid drop receptacles.
Desired behaviour
- The highlighting and dimming of Launcher icons should persist until the user drops the file.
- Note that the 'spread when a item is held over a launcher icon' behaviour seems to be broken in the Oneiric final freeze release (nothing happens).
Related branches
lp:~azzar1/unity/dnd-enhancements
- Jason Smith (community): Approve
-
Diff: 1269 lines (+524/-203)14 files modifiedplugins/unityshell/src/AbstractLauncherIcon.h (+4/-2)
plugins/unityshell/src/BamfLauncherIcon.cpp (+99/-69)
plugins/unityshell/src/BamfLauncherIcon.h (+11/-5)
plugins/unityshell/src/DNDCollectionWindow.cpp (+63/-0)
plugins/unityshell/src/DNDCollectionWindow.h (+55/-0)
plugins/unityshell/src/DndData.cpp (+63/-0)
plugins/unityshell/src/DndData.h (+71/-0)
plugins/unityshell/src/Launcher.cpp (+120/-94)
plugins/unityshell/src/Launcher.h (+10/-8)
plugins/unityshell/src/LauncherIcon.cpp (+2/-2)
plugins/unityshell/src/LauncherIcon.h (+10/-8)
plugins/unityshell/src/MockLauncherIcon.h (+2/-2)
plugins/unityshell/src/TrashLauncherIcon.cpp (+11/-11)
plugins/unityshell/src/TrashLauncherIcon.h (+3/-2)
lp:~3v1n0/unity/dnd-launcher-icon-fixes
- PS Jenkins bot (community): Approve (continuous-integration)
- Christopher Townsend: Approve
- Brandon Schaefer (community): Approve
-
Diff: 313 lines (+76/-43)10 files modifieddash/DashController.cpp (+3/-1)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+15/-14)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+19/-2)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
plugins/unityshell/src/unityshell.cpp (+6/-15)
unity-shared/PluginAdapter.cpp (+27/-8)
lp:~unity-team/unity/7.2.2
- Marco Trevisan (Treviño): Approve
-
Diff: 3472 lines (+1152/-478)54 files modifiedUnityCore/GnomeSessionManager.cpp (+32/-0)
UnityCore/GnomeSessionManagerImpl.h (+4/-0)
UnityCore/SessionManager.h (+4/-0)
dash/DashController.cpp (+3/-1)
debian/changelog (+59/-0)
hud/HudController.cpp (+1/-0)
launcher/AbstractLauncherIcon.h (+3/-2)
launcher/ApplicationLauncherIcon.cpp (+20/-19)
launcher/ApplicationLauncherIcon.h (+0/-1)
launcher/Launcher.cpp (+26/-10)
launcher/LauncherIcon.cpp (+7/-3)
launcher/LauncherIcon.h (+2/-1)
launcher/SwitcherView.cpp (+54/-31)
launcher/SwitcherView.h (+3/-4)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+1/-0)
lockscreen/LockScreenAbstractShield.h (+0/-1)
lockscreen/LockScreenController.cpp (+2/-3)
lockscreen/LockScreenShield.cpp (+0/-6)
lockscreen/LockScreenShield.h (+0/-1)
lockscreen/UserPromptView.cpp (+8/-99)
lockscreen/UserPromptView.h (+1/-13)
panel/PanelIndicatorEntryView.cpp (+7/-0)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+3/-0)
plugins/unityshell/src/GesturalWindowSwitcher.h (+1/-0)
plugins/unityshell/src/unityshell.cpp (+57/-50)
plugins/unityshell/src/unityshell.h (+2/-0)
po/POTFILES.in (+1/-0)
po/unity.pot (+70/-3)
shortcuts/ShortcutController.cpp (+4/-6)
shortcuts/ShortcutView.cpp (+113/-48)
shortcuts/ShortcutView.h (+9/-3)
shutdown/SessionButton.cpp (+30/-5)
shutdown/SessionButton.h (+5/-0)
shutdown/SessionController.cpp (+2/-0)
shutdown/SessionView.cpp (+68/-27)
shutdown/SessionView.h (+5/-0)
tests/test-gestures/LockScreenControllerMock.h (+43/-0)
tests/test-gestures/sed_script_switcher (+2/-0)
tests/test-gestures/unityshell_mock.h (+8/-1)
tests/test_lockscreen_controller.cpp (+0/-1)
tests/test_switcher_view.cpp (+1/-2)
tests/test_unity_window_view.cpp (+9/-9)
unity-shared/EMConverter.cpp (+2/-2)
unity-shared/IMTextEntry.cpp (+7/-0)
unity-shared/IMTextEntry.h (+2/-0)
unity-shared/PluginAdapter.cpp (+43/-10)
unity-shared/RawPixel.cpp (+1/-1)
unity-shared/TextInput.cpp (+178/-4)
unity-shared/TextInput.h (+19/-4)
unity-shared/UnityWindowStyle.cpp (+135/-62)
unity-shared/UnityWindowStyle.h (+35/-20)
unity-shared/UnityWindowView.cpp (+53/-25)
unity-shared/UnityWindowView.h (+6/-0)
- Unity Team: Pending requested
-
Diff: 1674 lines (+1380/-30) (has conflicts)7 files modifiedCMakeLists.txt (+5/-0)
ChangeLog (+1162/-0)
debian/changelog (+77/-26)
debian/control (+1/-1)
po/unity.pot (+70/-3)
shutdown/SessionView.cpp (+55/-0)
shutdown/SessionView.h (+10/-0)
| Changed in ayatana-design: | |
| status: | New → Fix Committed |
| importance: | Undecided → Critical |
| importance: | Critical → High |
| assignee: | nobody → John Lea (johnlea) |
| tags: | added: udt |
Revision history for this message
| David Barth (dbarth) wrote | #1 |
| Changed in unity: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| milestone: | none → 3.6.6 |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
| Changed in unity (Ubuntu): | |
| status: | New → Triaged |
| Changed in unity: | |
| milestone: | 3.6.6 → 3.6.8 |
| Changed in unity: | |
| milestone: | 3.6.8 → 3.8 |
| Changed in unity: | |
| milestone: | 3.8 → 3.8.2 |
| tags: | added: ffe |
| tags: | added: udo |
| Changed in unity: | |
| milestone: | 3.8.2 → ux-backlog-1 |
| importance: | Low → Medium |
| assignee: | nobody → Jason Smith (jassmith) |
| tags: | added: backlog |
| Changed in unity: | |
| assignee: | Jason Smith (jassmith) → Andrea Azzarone (andyrock) |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Andrea Azzarone (andyrock) |
| Changed in unity: | |
| status: | Triaged → In Progress |
| Changed in unity (Ubuntu): | |
| status: | Triaged → In Progress |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Changed in unity (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in unity: | |
| status: | Fix Released → Fix Committed |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| John Lea (johnlea) wrote | #2 |
| Changed in unity: | |
| status: | Fix Released → Confirmed |
| description: | updated |
| Changed in unity (Ubuntu): | |
| status: | Fix Released → Confirmed |
| tags: | added: onew |
| description: | updated |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | #3 |
| Changed in unity: | |
| status: | Confirmed → Fix Committed |
| status: | Fix Committed → Confirmed |
Revision history for this message
| John Lea (johnlea) wrote | #4 |
| tags: | added: udp |
| Changed in unity: | |
| milestone: | none → backlog |
| Changed in ayatana-design: | |
| status: | Fix Released → Fix Committed |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | #5 |
| Changed in unity: | |
| status: | Confirmed → Triaged |
| Changed in unity (Ubuntu): | |
| status: | Confirmed → Triaged |
| Changed in unity: | |
| milestone: | backlog → none |
| tags: | added: exbacklog |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in unity: | |
| milestone: | none → 7.2.1 |
| assignee: | Andrea Azzarone (andyrock) → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity (Ubuntu): | |
| assignee: | Andrea Azzarone (andyrock) → Marco Trevisan (Treviño) (3v1n0) |
| Changed in unity: | |
| status: | Triaged → In Progress |
| Changed in unity (Ubuntu): | |
| status: | Triaged → In Progress |
| tags: | added: dnd |
| Changed in unity: | |
| milestone: | 7.2.1 → 7.2.2 |
| Changed in unity: | |
| milestone: | 7.2.2 → 7.3.0 |
| status: | In Progress → Fix Committed |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| description: | updated |
To post a comment you must log in.
Regular bug, not a design change request.