Don't auto-linkify non-existent bug reports
Bug #4595 reported by
Matthew Paul Thomas
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Nigel Babu | ||
Bug Description
Malone autolinkifies the above text, and then gives it the tooltip "No such bug". Malone shouldn't link to a bug report while simultaneously admitting that it knows the bug report doesn't exist.
Related branches
lp:~nigelbabu/launchpad/4595-upgrade-bug-linking
- Benji York (community): Approve (code)
- Stuart Bishop (community): Approve
-
Diff: 410 lines (+109/-57)9 files modifiedlib/lp/app/browser/linkchecker.py (+22/-1)
lib/lp/app/browser/stringformatter.py (+1/-1)
lib/lp/app/browser/tests/test_linkchecker.py (+46/-18)
lib/lp/app/browser/tests/test_stringformatter.py (+4/-4)
lib/lp/app/browser/tests/test_webservice.py (+1/-1)
lib/lp/app/doc/displaying-paragraphs-of-text.txt (+28/-28)
lib/lp/app/javascript/lp-links.js (+3/-0)
lib/lp/bugs/tests/test_bugs_webservice.py (+2/-2)
lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt (+2/-2)
| Changed in malone: | |
| assignee: | nobody → bradb |
| status: | New → Accepted |
| Changed in malone: | |
| assignee: | bradb → nobody |
| affects: | malone → launchpad-web |
| Changed in launchpad-web: | |
| importance: | Medium → Low |
| tags: | added: tales |
| tags: | added: easy ui |
Revision history for this message
| Nigel Babu (nigelbabu) wrote | #1 |
Revision history for this message
| Matthew Paul Thomas (mpt) wrote | #2 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| Changed in launchpad: | |
| assignee: | nobody → Nigel Babu (nigelbabu) |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Nigel Babu (nigelbabu) wrote | #4 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't see the tooltip anymore. Can this bug be closed then?