pushing to a packaging branch can't create a new package
Bug #386596 reported by
Robert Collins
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Aaron Bentley |
Bug Description
bzr push bzr
+ssh://
bzr: ERROR: Permission denied:
"/~libcpuinfo-
source package: 'libcpuinfo'.
Pushing should simply create the sourcepackagename (as we're looking at removing that table anyway, this is consistent with that, and consistent with the existing dput behaviour (allows new packages from anyone to be created).
Related branches
lp:~abentley/launchpad/push-creates-package
- Abel Deuring (community): Approve (code)
-
Diff: 543 lines (+162/-40)15 files modifiedlib/canonical/launchpad/xmlrpc/configure.zcml (+3/-0)
lib/canonical/launchpad/xmlrpc/faults.py (+11/-0)
lib/lp/code/tests/helpers.py (+14/-0)
lib/lp/code/xmlrpc/codehosting.py (+11/-0)
lib/lp/code/xmlrpc/tests/test_codehosting.py (+25/-5)
lib/lp/codehosting/inmemory.py (+21/-8)
lib/lp/codehosting/tests/test_acceptance.py (+19/-9)
lib/lp/codehosting/vfs/branchfs.py (+2/-5)
lib/lp/codehosting/vfs/tests/test_branchfs.py (+13/-2)
lib/lp/registry/errors.py (+5/-0)
lib/lp/registry/interfaces/person.py (+4/-8)
lib/lp/registry/model/person.py (+1/-1)
lib/lp/registry/model/sourcepackagename.py (+8/-1)
lib/lp/registry/tests/test_person.py (+1/-1)
lib/lp/registry/tests/test_sourcepackagename.py (+24/-0)
tags: | added: principia |
tags: | added: not-pie-critical |
Changed in launchpad: | |
assignee: | nobody → Aaron Bentley (abentley) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
On another axis, it's consistently restrictive -- we don't let you create anything other than branches via the SSH server.
I talked to beuno about this (being a user-visible change, it needs a UI review). He suggested that we only create the package when --create-prefix or some other option is passed to bzr, to avoid creating packages as a result of typos.
Another approach, which we didn't discuss, is for the codehosting server to create the branch without any special option, but to trigger some client-side warning saying that it s doing so, and point to a way of moving the branch to the correct package and undoing the creation of the package. This is probably more complicated to implement.