shared repositories and 403 http servers

Bug #342119 reported by Vincent Ladeuil
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Wishlist
Unassigned

Bug Description

As encountered at https://answers.launchpad.net/launchpad/+question/63191, some http servers may reply 'Server refuses to fulfill the request (403 Forbidden) ' when we probe for the .bzr/repository/shared-storage file.

As discussed with lifelees, we could relax the definition of repository.is_shared by catching such transport exceptions since previous accesses have already validated that we can access whatever we need here.

Vincent Ladeuil (vila)
Changed in bzr:
assignee: nobody → vila
status: New → In Progress
importance: Undecided → Low
Revision history for this message
Vincent Ladeuil (vila) wrote :

A bit of feedback here: I first thought this can be easily addressed without changing the contract which is that the boolean to decide if a repository is shared is implemented by the existence of a file.

It turns out (trying to write the tests made that clear) that interpreting a 403 forbidden error as the absence of a file is too large and can't be simply addressed at the http transport level (i.e. make it a special case for http only).

Since this is arguably a server configuration problem and that there is a possible work around (make the repository shared even for a single branch), I think there is no urgency to fix that bug and that we should change the contract instead and find another implementation for shared repository property (which is a more invasive change and requires a format bump).

Changed in bzr:
importance: Low → Wishlist
status: In Progress → Confirmed
Revision history for this message
Vincent Ladeuil (vila) wrote :

Upon reflexion, I think using a file to implement a boolean is a waste and should be addressed in a future format.
Until then, since the bug wasn't metoo'ed, I don't plan to work on it in the foreseeable future.

Changed in bzr:
assignee: Vincent Ladeuil (vila) → nobody
assignee: nobody → Vincent Ladeuil (vila)
assignee: Vincent Ladeuil (vila) → nobody
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.