Please merge ldapscripts 2.0.8-2 (universe) from Debian unstable (main)

Bug #2049311 reported by Sudip Mukherjee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ldapscripts (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Please merge ldapscripts 2.0.8-2 (universe) from Debian unstable (main)

Explanation of the Ubuntu delta:

Carry forward one previous Ubuntu specific change.
1. replaced /etc/libnss-ldap.conf references by /etc/ldap.conf

Related branches

Changed in ldapscripts (Ubuntu):
status: New → In Progress
assignee: nobody → Sudip Mukherjee (sudipmuk)
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

debdiff from Debian 2.0.8-2 is attached. I can upload the debdiff between ldapscripts_2.0.8-1ubuntu2 and this version if necessary.

Changed in ldapscripts (Ubuntu):
status: In Progress → Confirmed
assignee: Sudip Mukherjee (sudipmuk) → nobody
Revision history for this message
Paride Legovini (paride) wrote :

Hello and thanks for working at this merge. By looking at the history of the package what I see is that:

1. At some point Ubuntu delta was introduced to replace a reference to /etc/libnss-ldap.conf with /etc/ldap.conf. The reason for this is unclear to me (no bug references in d/changelog). Example diff:

https://git.launchpad.net/ubuntu/+source/ldapscripts/commit/?id=ab326cc6a8e9edfb8dba5c7ea5e219ade59be612

2. In the Debian revision 2.0.1-2 that reference to /etc/libnss-ldap.conf was dropped, likely as part of the changes which pertain to this d/changelog entry:

  * Depend on nslcd instead of libnss-ldap, and us it's config.
      (Closes: #610971, #681266.)

Still the Ubuntu delta was partially retained, see:

https://git.launchpad.net/ubuntu/+source/ldapscripts/commit/?id=5a2fbdb26d849043c81a06afddd5ec858788aeb6

My impression is that this is not correct.

So I have two questions now:

1. Do we still need an Ubuntu delta here, given that 2.0.1-2 dropped the dependency on libnss-ldap? If we don't, let's just sync the package.

2. If it turns out that we still need a delta, do we agree that the current one is wrong and needs to be adapted?

Thanks!

Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

Seems like you are right. The delta was introduced as part of #582797 and at that time the d/runtime.debian from Debian package looked like https://sources.debian.org/src/ldapscripts/1.9.0-2/debian/runtime.debian/#L26 which directly used "/etc/libnss-ldap.conf". But the current version uses "/etc/nslcd.conf" and Ubuntu also uses "/etc/nslcd.conf" for nslcd, so this should be a sync now.

Revision history for this message
Dan Bungert (dbungert) wrote :

Syncing, thanks!

Dan Bungert (dbungert)
Changed in ldapscripts (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Graham Inggs (ginggs) wrote (last edit ):

Sync was sponsored, unsubscribing ubuntu-sponsors.

Changed in ldapscripts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.