build failure due to failing pytest case

Bug #2036292 reported by Chris Peterson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-future (Ubuntu)
Fix Released
Undecided
Dan Bungert

Bug Description

This package fails to build on mantic due to a failing pytest case when running Python3.11. This is because Python3.11 changed the thrown error when encountering null bytes in python source code from a ValueError to a SyntaxError, which isn't handle in the test case.

Tags: patch
Revision history for this message
Chris Peterson (cpete) wrote :
Dan Bungert (dbungert)
Changed in python-future (Ubuntu):
assignee: nobody → Dan Bungert (dbungert)
status: New → In Progress
Revision history for this message
Dan Bungert (dbungert) wrote :

Thanks for the fix, Chris.

Some notes from review:

* https://ubuntu-packaging-guide.readthedocs.io/en/latest/ubuntu-packaging-guide/traditional-packaging.html#creating-a-debdiff has some suggestions on naming the debdiff, this is not blocking upload though.
* In the comment there is "# and SyntaxError in 3.11=<:", which looks like it was cut off. Double check the intended text please, and create a new debdiff.
* the debian/patches/series has a trailing new line, which also would not have blocked upload (I would have just fixed and uploaded) but since I'm asking for the comment fix, would be good to do.

Revision history for this message
Chris Peterson (cpete) wrote :

Dan,

Thank you for your comments. To address them:

- I've revised the debdiff naming scheme, please see on attached.
- This was an effort to keep the line length <80 characters. I've re-worded the comment to make it clear that it was a continuation.
- I have removed the new line from the debian/patches/series file.

Additionally, I found a proposed fix for this in the upstream and included a link in the patch header.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "mypatch.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Dan Bungert (dbungert) wrote :

Uploaded, thanks!

One tweak I did was to fix the changelog for Firstname Lastname instead of lp username, the rest was fine.

Changed in python-future (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-future - 0.18.2-6ubuntu2

---------------
python-future (0.18.2-6ubuntu2) mantic; urgency=medium

  * Fix build failure due to failing pytest case (LP: #2036292)

 -- Chris Peterson <email address hidden> Fri, 15 Sep 2023 15:33:03 -0700

Changed in python-future (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.