subiquity

dos ptable & storage ver 1: swap flag not handled

Bug #2004609 reported by rp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
subiquity
Confirmed
Undecided
Unassigned
curtin (Ubuntu)
Fix Committed
Undecided
Unassigned

Bug Description

Using a "Custom storage layout", if a swap partition is added, it gets installed with type 83 instead of 82. Some of our later processes fail since they depend on the swap partition having type 82.

Related branches

~dbungert/curtin:lp-2004609-swap-size-dropped
Server Team CI bot: Approve (continuous-integration)
Michael Hudson-Doyle: Approve
Diff: 138 lines (+77/-6)
4 files modified
curtin/commands/block_meta.py (+5/-3)
curtin/swap.py (+3/-3)
tests/integration/test_block_meta.py (+13/-0)
tests/unittests/test_commands_block_meta.py (+56/-0)
Revision history for this message
Dan Bungert (dbungert) wrote :

We'll need a little more information than that. Version used, logs, all the normal stuff please.
I see that curtin is using type 82 when creating swap partitions so from this description there isn't anything I can tell you.

Changed in subiquity:
status: New → Incomplete
Revision history for this message
Dan Bungert (dbungert) wrote :

/var/log/installer has the stuff we're interested in.

Revision history for this message
rp (oripi) wrote :

zip file containing /var/log/installer is attached.

Revision history for this message
Dan Bungert (dbungert) wrote :

Thank you so much. I can reproduce this with the included info.

In the logs is:
Not creating swap: suggested size was 0

It's not so much that the swap partition has the wrong type, it's that swap wasn't set up period.

Changed in subiquity:
status: Incomplete → Confirmed
summary: - swap partition gets installed with type 83 instead of 82
+ dos ptable: dropping swap size, resulting in no swap setup
Changed in curtin (Ubuntu):
status: New → Confirmed
Revision history for this message
Dan Bungert (dbungert) wrote : Re: dos ptable: dropping swap size, resulting in no swap setup

Oh, and ignore the size is 0 bit, you did nothing wrong and the size info was dropped along the way.

Dan Bungert (dbungert)
summary: - dos ptable: dropping swap size, resulting in no swap setup
+ dos ptable & storage ver 1: swap flag not handled
Dan Bungert (dbungert)
Changed in curtin (Ubuntu):
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.