NVIDIA desktop drivers not installed

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
https://iso.qa.ubuntu.com/qatracker/reports/bugs/1998376

Looking at the logs (and skipping the stuff related to snapd/seed/systems), the call to /source did not include a value for "search_drivers". It defaults to false (see https://github.com/canonical/subiquity/pull/1287); resulting in no third-party drivers to be suggested for installation.

2022-11-30 17:26:36,782 INFO aiohttp.access:233 [30/Nov/2022:17:26:36 +0000] "POST /source?source_id=%22ubuntu-desktop%22 HTTP/1.1" 200 189 "-" "Dart/2.18 (dart:io)"

I'm marking the bug invalid for Subiquity since there is nothing obvious to do on our end.

Reopening for Subiquity since despite what I mentioned above, we see the drivers (for server) being installed:

2022-11-30 17:33:11,157 DEBUG root:37 start: subiquity/Install/install/postinstall/ubuntu-drivers-install: installing third-party drivers
2022-11-30 17:33:11,158 DEBUG subiquitycore.utils:114 astart_command called: ['systemd-run', '--wait', '--same-dir', '--property', 'SyslogIdentifier=subiquity_log.2936', '--property', 'PrivateMounts=yes', '--setenv', 'PATH=/snap/ubuntu-desktop-installer/696/bin/subiquity/bin:/snap/ubuntu-desktop-installer/696/bin/subiquity/usr/bin:/snap/ubuntu-desktop-installer/696/bin:/snap/ubuntu-desktop-installer/696/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin', '--setenv', 'PYTHONPATH=/snap/ubuntu-desktop-installer/696/lib/python3.8/site-packages:/snap/ubuntu-desktop-installer/696/usr/lib/python3/dist-packages:/snap/ubuntu-desktop-installer/696/usr/lib/python3/site-packages:', '--setenv', 'PYTHON=/snap/ubuntu-desktop-installer/696/usr/bin/python3.8', '--setenv', 'SNAP=/snap/ubuntu-desktop-installer/696', '--', '/snap/ubuntu-desktop-installer/696/usr/bin/python3.8', '-m', 'curtin', '--showtrace', '-vvv', '--set', 'json:reporting={"subiquity": {"type": "journald", "identifier": "curtin_event.2936.8"}}', 'in-target', '-t', '/target', '--', 'ubuntu-drivers', 'install', '--gpgpu']

The presence of --gpgpu in this command is what makes Subiquity install the wrong drivers (i.e., server vs desktop).

The logic is based on the value of the client_variant variable. This variable is initialized to "server" and then can be overwritten by a POST request to /meta/client_variant ; which we can see in the logs.

2022-11-30 17:23:02,729 INFO aiohttp.access:233 [30/Nov/2022:17:23:02 +0000] "POST /meta/client_variant?variant=%22desktop%22 HTTP/1.1" 200 189 "-" "Dart/2.18 (dart:io)"

My assumption is that we read the client_variant variable too soon and don't re-read it after the desktop installer supplies a value for us.

Pull request: https://github.com/canonical/subiquity/pull/1505

> The logic is based on the value of the client_variant variable. This variable is initialized to "server" and then can be overwritten by a POST request to /meta/client_variant ; which we can see in the logs.
>
> 2022-11-30 17:23:02,729 INFO aiohttp.access:233 [30/Nov/2022:17:23:02 +0000] "POST /meta/client_variant?variant=%22desktop%22 HTTP/1.1" 200 189 "-" "Dart/2.18 (dart:io)"
>
> My assumption is that we read the client_variant variable too soon and don't re-read it after the desktop installer supplies a value for us

I actually mixed up source variant and client variant. The former reflects the type of image that we are installing. The latter reflects whether we are running a TUI or desktop based install.

When installing drivers, we want the drivers installed to match the source variant and not the client variant.

Therefore, the call to /meta/client_variant is not relevant, but the call to /source is what matters.

We believe this issue has been resolved in Subiquity 23.04.2.

If you had tested this with a pre-final version of Ubuntu 23.04, it's
recommended to download the final install media.

For testing with Ubuntu Server 22.04.x or 20.04.x, when running
Subiquity, you should offered a new version of the installer. Please
take that update to version 23.04.2 or later to get the fix.

If this is still a problem for you, please make a comment and set the state
back to New. Thank you for the bug report.