Remove the "Movim Stack" from Eoan for failing (and thereby blocking) with newer symfony

Bug #1842019 reported by Christian Ehrhardt 
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
movim (Debian)
Fix Released
Unknown
movim (Ubuntu)
Fix Released
Undecided
Unassigned
php-illuminate-container (Ubuntu)
Fix Released
Undecided
Unassigned
php-illuminate-database (Ubuntu)
Fix Released
Undecided
Unassigned
php-illuminate-support (Ubuntu)
Fix Released
Undecided
Unassigned
php-nesbot-carbon (Debian)
Fix Released
Unknown
php-nesbot-carbon (Ubuntu)
Fix Released
Undecided
Unassigned
php-robmorgan-phinx (Debian)
Fix Released
Unknown
php-robmorgan-phinx (Ubuntu)
Fix Released
Undecided
Unassigned
ratchetphp (Debian)
Fix Released
Unknown
ratchetphp (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

TL;DR:
- the packages brought in for movim a few years back patched out support for 4.0 and
  then never updated again.
- the packages brought in illuminate seem totally broken (tarball does
  not match any upstream release)

Solutions:
- remove movim/ratchedphp/php-robmorgan-phinx/php-illuminate-*/php-nesbot-carbon
OR
- update to fix those packages (details below)
  - movim needs - new major version 0.15 needed
  - php-nesbot-carbon - use actual upstream content and rebuild
  - ratchetphp - revert Debian patch and rebuild
  - php-robmorgan-phinx - revert Debian patch and rebuild (new
upstream available)

Currently no one seems to step up and take care of it, while at the same time
a) usage count of this seems rather low
b) the prime install guide leans towards docker compose based install

I guess we are fine to take the newer versions once someone got to them, but right now for Eoan we should remove it to get things in -proposed to settle.

Therefore hereby I request to remove from Eoan the source packages (and their binaries):
- php-illuminate-support
- php-illuminate-contracts
- php-illuminate-database
- php-nesbot-carbon
- php-robmorgan-phinx
- ratchetphp
- movim

--- Details ---

All the packages this is filed against are incompatible with newer symfony, and in general we'd want the newer symfony in Eoan for all its other reverse dependencies.

Ubuntu Versions of symfony present atm in Eoan:
 3.4.22+dfsg-2ubuntu1 release
 4.3.3+dfsg-3ubuntu3 proposed

Breaks autopkgtests against older symfony
People need to trigger tests to run against new symfony all the time. But even with that symfony will not be able to migrate.

Also entanglement happens, for example phploc depends on the new symfony to migrate

To have symfony migrate there are a few conflicts to resolve:
Per: => https://people.canonical.com/~ubuntu-archive/proposed-migration/update_output.txt

- movim php-symfony-console (<< 4~~)
- php-cboden-ratchet php-symfony-http-foundation (<< 4~~),
php-symfony-routing (<< 4~~)
- php-illuminate-support (via php-nesbot-carbon)
- php-nesbot-carbon php-symfony-translation (<< 4~~)
- php-robmorgan-phinx php-symfony-console (<< 4~~),
php-symfony-config (<< 4~~), php-symfony-yaml (<< 4~~)

So we need to analyze/fix source packages:
- movim
- ratchetphp
- php-nesbot-carbon
- php-robmorgan-phinx

All four are currently broken the same way in debian/sid - no
bug/removal request filed there.
All four seem rather stable/slow-update as they almost all have the
same versions in stable, testing, unstable, disco, eoan
None was present before that time, only movim got a few updates.
All others are stuck on their "initial release" upload.

While not individually, together as a group those packages are
actually leave packages, full rev-dep check shows

movim -> ratchetphp
     \-> php-robmorgan-phinx
     \-> php-illuminate-database -> php-illuminate-support -> php-nesbot-carbon

None other depends on this "group" of packages.

Here the full reverse dependencies:
$ reverse-depends src:php-illuminate-support -r eoan
Reverse-Depends
===============
* php-illuminate-container (for php-illuminate-support)
* php-illuminate-database (for php-illuminate-support)

$ reverse-depends src:php-illuminate-contracts -r eoan
Reverse-Depends
===============
* php-illuminate-container (for php-illuminate-contracts)
* php-illuminate-database (for php-illuminate-contracts)
* php-illuminate-support (for php-illuminate-contracts)

$ reverse-depends src:php-illuminate-database -r eoan
Reverse-Depends
===============
* movim (for php-illuminate-database)

$ reverse-depends src:php-nesbot-carbon -r eoan
Reverse-Depends
===============
* php-illuminate-support (for php-nesbot-carbon)

$ reverse-depends src:php-robmorgan-phinx -r eoan
Reverse-Depends
===============
* movim (for php-robmorgan-phinx)

$ reverse-depends src:ratchetphp -r eoan
Reverse-Depends
===============
* movim (for php-cboden-ratchet)

$ reverse-depends src:movim -r eoan
No reverse dependencies found

--- Check each package details individually for their issues ---

1. movim
- Debian/Ubuntu 0.14.1-5
- Upstream v0.15 (July 28)
- Symfony dependency fixes:
  => https://github.com/movim/movim/commit/a80bba27fa2983afd702fabcb91a3f11e85df58d
  => https://github.com/movim/movim/commit/98e4825ad20296af531106bb1d5697408924d5a6

The latter already is part of 0.14.1 but not in the tarball used by Debian.
It seems "their build" used the new components already in 0.14.1 (=>
composer.lock)
But the composer.json wasn't updated yet hence it is outdated and things like
  debian/control:30: ${phpcomposer:Debian-require},
pull in the too old dependencies.

Note: it seems no actual changes were needed, but just patching
composer.json still seems to dangerous.
Solution:
a) update to 0.15 (FFE)
b) remove from Eoan
    Removal would already make all other non-needed as well
c) update composer.json to accept v4
    (might be ok - as it seems upstream 0.14.1 was built with symfony 4)
    Rebuild then will pick up versions through ${phpcomposer:Debian-require}

2. ratchetphp
- Debian/Ubuntu 0.4.1-2
- Upstream 0.4.1
  - no release since dec 2017
  - 8 commits since release in dec 2017

Upstream changelog states for 0.4.1:
* Support Symfony 4
  => https://github.com/ratchetphp/Ratchet/commit/82f2505b13d7130780e54dd2bbfba0e165a651c1#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR13
 So this should work with symfony 4, the reason it doesn't is in the packaging:

Debian carries:
debian/patches/fix_deps.patch:12:- , "symfony/http-foundation":
"^2.6|^3.0|^4.0"
debian/patches/fix_deps.patch:13:- , "symfony/routing": "^2.6|^3.0|^4.0"
debian/patches/fix_deps.patch:14:+ , "symfony/http-foundation": "^3.0"
debian/patches/fix_deps.patch:15:+ , "symfony/routing": "^3.0"
Unfortunately this has no bug-link, discussion or anything else.

Solution:
a) drop the patch and rebuild - ${phpcomposer:Debian-require} will
pick new things up.
b) removal along movim

3. php-nesbot-carbon
- Debian/Ubuntu 1.27.0-1
- Upstream 2.23.1

Symfony support is in actually since 1.23.0
=> https://github.com/briannesbitt/Carbon/commit/23d299fdc24e8e7ff7f239846a9f8398ffb5a263
And it should be in 1.27 that we have:
$ git show 1.27.0:composer.json | grep symfony
        "symfony/translation": "~2.6 || ~3.0 || ~4.0"
Note: 1.26 would have been a stable release with much more updates

What is in the Archive clearly isn't 1.27
=> https://github.com/briannesbitt/Carbon/archive/1.27.0.zip
$ grep symfony composer.json
        "symfony/translation": "~2.6 || ~3.0 || ~4.0"

There never was an upstream tarball for 1.27 (d/watch finds nothing,
only a zip file).
And the used content of the tarball never really existed, upstream went
    "symfony/translation": "~2.6"
    "symfony/translation": "~2.6|~3.0"
    "symfony/translation": "~2.6 || ~3.0 || ~4.0"
        "symfony/translation": "^4.0"
        "symfony/translation": "^3.4 || ^4.0"

Solution:
a) replace with real upstream source of 1.27, maybe something much newer.
b) removal along movim

4. php-robmorgan-phinx
- Debian/Ubuntu 0.9.2-1
- Upstream 0.11.0

Symfony support exists since
=> https://github.com/cakephp/phinx/commit/02e1888765ecfcd2760e484e1b8fe95f938b34a2
But again:
$ git tag --contains 02e1888765ecfcd2760e484e1b8fe95f938b34a2
[...]
v0.9.2

As with ratchedphp this is reverted in Debian.
debian/patches/pkg-php-tools-deficiency-workaround.diff:10:-
"symfony/console": "^2.8|^3.0|^4.0",
debian/patches/pkg-php-tools-deficiency-workaround.diff:11:-
"symfony/config": "^2.8|^3.0|^4.0",
debian/patches/pkg-php-tools-deficiency-workaround.diff:12:-
"symfony/yaml": "^2.8|^3.0|^4.0"
debian/patches/pkg-php-tools-deficiency-workaround.diff:13:+
"symfony/console": "^3.0",
debian/patches/pkg-php-tools-deficiency-workaround.diff:14:+
"symfony/config": "^3.0",
debian/patches/pkg-php-tools-deficiency-workaround.diff:15:+
"symfony/yaml": "^3.0"

Here at least the filename gives an indication what might have
happened "pkg-php-tools-deficiency-workaround".
I'd hope that this is resolved and could be reverted+rebuilt.
Otherwise at least make it "only 4.0" instead of "only 3.0"

Solution:
a) drop the patch and rebuild - ${phpcomposer:Debian-require} will
pick new things up.
b) removal along movim

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI: I think the bug is complete enough and ready for processing, so I subscribed ubuntu-archive to handle this request. If there is anything to discuss please reach out to me.

description: updated
Revision history for this message
Steve Langasek (vorlon) wrote :

Christian, please also file a bug in Debian against the packages which have direct dependencies on old symfony and are broken by this, so that the Debian maintainer knows they need to take action (which is not automatically apparent to a maintainer just because their package is uninstallable in unstable).

Severity: serious / Tags: sid is appropriate for such bugs.

This is not a blocker for the removals from Ubuntu, it's just good community practice.

Revision history for this message
Steve Langasek (vorlon) wrote :

Removing packages from eoan:
 movim 0.14.1-5 in eoan
  movim 0.14.1-5 in eoan amd64
  movim 0.14.1-5 in eoan arm64
  movim 0.14.1-5 in eoan armhf
  movim 0.14.1-5 in eoan i386
  movim 0.14.1-5 in eoan ppc64el
  movim 0.14.1-5 in eoan s390x
Comment: Incompatible with symfony 4 and blocks transition; LP: #1842019
1 package successfully removed.

Changed in movim (Ubuntu):
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing packages from eoan:
 php-illuminate-container 5.7.27-1 in eoan
  php-illuminate-container 5.7.27-1 in eoan amd64
  php-illuminate-container 5.7.27-1 in eoan arm64
  php-illuminate-container 5.7.27-1 in eoan armhf
  php-illuminate-container 5.7.27-1 in eoan i386
  php-illuminate-container 5.7.27-1 in eoan ppc64el
  php-illuminate-container 5.7.27-1 in eoan s390x
Comment: Depends on php-illuminate-support -> php-nesbot-carbon, which is incompatible with symfony 4 and blocks transition; LP: #1842019

affects: php-illuminate-contracts (Ubuntu) → php-illuminate-container (Ubuntu)
Changed in php-illuminate-container (Ubuntu):
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing packages from eoan:
 php-illuminate-database 5.7.27-1 in eoan
  php-illuminate-database 5.7.27-1 in eoan amd64
  php-illuminate-database 5.7.27-1 in eoan arm64
  php-illuminate-database 5.7.27-1 in eoan armhf
  php-illuminate-database 5.7.27-1 in eoan i386
  php-illuminate-database 5.7.27-1 in eoan ppc64el
  php-illuminate-database 5.7.27-1 in eoan s390x
Comment: Depends on php-illuminate-support -> php-nesbot-carbon, which is incompatible with symfony 4 and blocks transition; LP: #1842019
1 package successfully removed.

Changed in php-illuminate-database (Ubuntu):
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing packages from eoan:
 php-illuminate-support 5.7.27-1 in eoan
  php-illuminate-support 5.7.27-1 in eoan amd64
  php-illuminate-support 5.7.27-1 in eoan arm64
  php-illuminate-support 5.7.27-1 in eoan armhf
  php-illuminate-support 5.7.27-1 in eoan i386
  php-illuminate-support 5.7.27-1 in eoan ppc64el
  php-illuminate-support 5.7.27-1 in eoan s390x
Comment: Depends on php-nesbot-carbon, which is incompatible with symfony 4 and blocks transition; LP: #1842019
1 package successfully removed.

Changed in php-illuminate-support (Ubuntu):
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing packages from eoan:
 php-nesbot-carbon 1.27.0-1 in eoan
  php-nesbot-carbon 1.27.0-1 in eoan amd64
  php-nesbot-carbon 1.27.0-1 in eoan arm64
  php-nesbot-carbon 1.27.0-1 in eoan armhf
  php-nesbot-carbon 1.27.0-1 in eoan i386
  php-nesbot-carbon 1.27.0-1 in eoan ppc64el
  php-nesbot-carbon 1.27.0-1 in eoan s390x
Comment: Incompatible with symfony 4 and blocks transition; LP: #1842019
1 package successfully removed.

Changed in php-nesbot-carbon (Ubuntu):
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing packages from eoan:
 php-robmorgan-phinx 0.9.2-1 in eoan
  php-robmorgan-phinx 0.9.2-1 in eoan amd64
  php-robmorgan-phinx 0.9.2-1 in eoan arm64
  php-robmorgan-phinx 0.9.2-1 in eoan armhf
  php-robmorgan-phinx 0.9.2-1 in eoan i386
  php-robmorgan-phinx 0.9.2-1 in eoan ppc64el
  php-robmorgan-phinx 0.9.2-1 in eoan s390x
Comment: Incompatible with symfony 4 and blocks transition; LP: #1842019
1 package successfully removed.

Changed in php-robmorgan-phinx (Ubuntu):
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing packages from eoan:
 ratchetphp 0.4.1-2 in eoan
  php-cboden-ratchet 0.4.1-2 in eoan amd64
  php-cboden-ratchet 0.4.1-2 in eoan arm64
  php-cboden-ratchet 0.4.1-2 in eoan armhf
  php-cboden-ratchet 0.4.1-2 in eoan i386
  php-cboden-ratchet 0.4.1-2 in eoan ppc64el
  php-cboden-ratchet 0.4.1-2 in eoan s390x
Comment: Incompatible with symfony 4 and blocks transition; LP: #1842019
1 package successfully removed.

Changed in ratchetphp (Ubuntu):
status: New → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI - reported to Debian as bugs
939190, 939191, 939192, 939193

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I linked the debian bugs here to get updates in a single place if something happens on these.

Changed in movim (Debian):
status: Unknown → New
Changed in ratchetphp (Debian):
status: Unknown → New
Changed in php-robmorgan-phinx (Debian):
status: Unknown → New
Changed in php-nesbot-carbon (Debian):
status: Unknown → New
Changed in php-robmorgan-phinx (Debian):
status: New → Fix Released
Changed in php-nesbot-carbon (Debian):
status: New → Fix Released
Changed in movim (Debian):
status: New → Fix Released
Changed in ratchetphp (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.